From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B47233857707 for ; Thu, 22 Jun 2023 05:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B47233857707 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687412980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rI3FJa7zhSv4+XAhayXZKIdtDD30hZ/eSFozb8im/+I=; b=EfZaVZ+EPBmvImBgwErElb3l8JP0VFpZcFioeMSXpjJ5Iqnls/AIdztSPKQxTk1Nu7DJ0s tFUQ+NFVKWeO4p6dGAX8OdZOwZXHFDve6GCJoPMKPeUVPmx/p9xpQ8tu1F+cqeChGYLXen ZzaO3IMcwADGTIlH1Ast8FSM/gIQAlg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-uCeVBQvWNt2LbQl2Gw1Luw-1; Thu, 22 Jun 2023 01:49:38 -0400 X-MC-Unique: uCeVBQvWNt2LbQl2Gw1Luw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f9b8e0896aso13292585e9.0 for ; Wed, 21 Jun 2023 22:49:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687412977; x=1690004977; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rI3FJa7zhSv4+XAhayXZKIdtDD30hZ/eSFozb8im/+I=; b=aZsSnl/M0pvqHLPWuXxrQ7CKIidvmucMznzQXWMn+KJOOYeyObWmreR64lETdWNcU2 0sKzP8GY+4t3cBJ7RG0g9bAIuvzOh34alt3eUI6N0SsBpKKIKK0X0TrxsX941kv7ZO6g J+qTooNGCpExQjsC3pAn5Vs6XRRt1t1BY9cUS1HjbWN+CfWSjAXghSDCFrYGpnoVy/AD VDrFaxq8AtcP+c6+mFNCUGsLvDj/ivBErKVTfu71ivTyKQkdas7jOF91l6YV5SsVrVKO 9b3CRmFXzT8sSa2n1pwPMHB+XczICLZkMJDtl4hINhmKnPHqQhb0r+VeVc3SXgyJTaR1 XGXg== X-Gm-Message-State: AC+VfDylOhZ9jbg4DNryej4va1Wf8ODykFB4kwNPfq/W5NdJ0ZGNPW53 4LosaI29/aIR8TVZLDplHfsMbByAAzPGwhWikByskf5JN3J3UJIMV9Ea+4hOHFDVGpICRMir9E8 7MhvaRjZU33T7gb07ewbRhz8fjxq/3Hphmw== X-Received: by 2002:a1c:6a04:0:b0:3f7:e7a5:5bc5 with SMTP id f4-20020a1c6a04000000b003f7e7a55bc5mr13872550wmc.24.1687412977678; Wed, 21 Jun 2023 22:49:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6OLxbfXcRYRJwb4RLszSlFZdOxKmDAwYl4QsD1iGN+3lIcPX/5OJUF+OOs0E2+PJdKb4NeBClYLpMhapiQJ1w= X-Received: by 2002:a1c:6a04:0:b0:3f7:e7a5:5bc5 with SMTP id f4-20020a1c6a04000000b003f7e7a55bc5mr13872544wmc.24.1687412977512; Wed, 21 Jun 2023 22:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20230522185622.537454-1-aldyh@redhat.com> <20230522185622.537454-2-aldyh@redhat.com> <3feb043e-bae6-513d-247b-ed0c23d0d21a@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Thu, 22 Jun 2023 07:49:28 +0200 Message-ID: Subject: Re: [PATCH] Implement ipa_vr hashing. To: Martin Jambor , GCC patches Cc: Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000001d451b05feb17330" X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001d451b05feb17330 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ping*2 On Wed, Jun 14, 2023, 14:11 Aldy Hernandez wrote: > PING > > On Sat, Jun 10, 2023 at 10:30=E2=80=AFPM Aldy Hernandez wrote: > > > > > > > > On 5/29/23 16:51, Martin Jambor wrote: > > > Hi, > > > > > > On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote: > > >> Implement hashing for ipa_vr. When all is said and done, all these > > >> patches incurr a 7.64% slowdown for ipa-cp, with is entirely covered > by > > >> the similar 7% increase in this area last week. So we get type > agnostic > > >> ranges with "infinite" range precision close to free. > > > > > > Do you know why/where this slow-down happens? Do we perhaps want to > > > limit the "infiniteness" a little somehow? > > > > I addressed the slow down in another mail. > > > > > > > > Also, jump functions live for a long time, have you looked at how > memory > > > hungry they become? I hope that the hashing would be good at > preventing > > > any issues. > > > > On a side-note, the caching does help. On a (mistaken) hunch, I had > > played around with removing caching for everything but UNDEFINED/VARYING > > and zero/nonzero to simplify things, but the cache hit ratio was still > > surprisingly high (+80%). So good job there :-). > > > > > > > > Generally, I think I OK with the patches if the impact on memory is n= ot > > > too bad, though I guess they depend on the one I looked at last week, > so > > > we may focus on that one first. > > > > I'm not sure whether this was an OK for the other patches, given you > > approved the first patch, so I'll hold off until you give the go-ahead. > > > > Thanks. > > Aldy > --0000000000001d451b05feb17330--