From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 18B3D3857C71 for ; Fri, 23 Sep 2022 06:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18B3D3857C71 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663916209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4zZU9POfRE4eOi0c5D3J8FNM8Osws74OnfoLsSfOSIw=; b=g2zefQRt4gCR11koT+J2mPYl4mWl4dP/n66A8UZmxI98dxynUrMfH8pe4QGvfZDtGh3bBQ dnXIf+Yp4z50g97Ikc8Xuc8JL93VcX9Nk0cY/XnelJ/cbTLMym/W0ceKc0U1eBg3+zmvYG oZjIMsI3frYlk5Pg3Hx98geUYSGEEco= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-29-o4GoqRMFPnqC8n7yLT3cFA-1; Fri, 23 Sep 2022 02:56:45 -0400 X-MC-Unique: o4GoqRMFPnqC8n7yLT3cFA-1 Received: by mail-ot1-f69.google.com with SMTP id l19-20020a056830055300b006560190b2feso5552662otb.12 for ; Thu, 22 Sep 2022 23:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=4zZU9POfRE4eOi0c5D3J8FNM8Osws74OnfoLsSfOSIw=; b=EgF+RFwguxdJqG5H/Z2DOW40PAe4iWGPryF5zz0MSBlswMKnB7AZUoN32bxT87k3Wa Ikv7gaPXGnuvyaLzGoBGV2DK8HT9rWhxYaL70YQ4ZArdR5mVfF5d6Y60438RHADz8gfn OVo1lbuO48aBmfGteMQXoAXp2fwIOUUIIsV9+e0BglGNkDEJeJzjURbAbvjGFaK8ZF+e Dwt3vx1G1ZID+wIPNDHCIKrhTHP8NI3OPfcI205dfzkkEH37chq/2GKNM0MCPIwUoY4p U2ZApRoQGjpa7BYWJRDMR8LdckfvXzYI3po0kVc8hX3u0j9ClENsr9UTHlu7g/mSA13r fU7w== X-Gm-Message-State: ACrzQf3cFPmPsvgOWI9qDgElRUvK+Ec5IqTjezqGZpXbeQShLdNE1z/f kD8rrbi+UaD9ZKafWr3UdHCtmIFn9mLs4c/znUqanEUpZup90FGk3bU1U058d6VlkUON34GE1ml um83QxpdeEFlijw5DZmRRM9PhbbTbWoQbIg== X-Received: by 2002:a05:6808:650:b0:34f:b81f:960 with SMTP id z16-20020a056808065000b0034fb81f0960mr8163277oih.36.1663916205162; Thu, 22 Sep 2022 23:56:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5BYT6d48W/8Nxp27Ep30JWzD7ItEs0lpuXVH29FKLIIGkb64sDjBCJLbQpdpZggYPvkl3ivVU/tH5QVCn3c4A= X-Received: by 2002:a05:6808:650:b0:34f:b81f:960 with SMTP id z16-20020a056808065000b0034fb81f0960mr8163272oih.36.1663916204928; Thu, 22 Sep 2022 23:56:44 -0700 (PDT) MIME-Version: 1.0 References: <20220922164911.2566143-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Fri, 23 Sep 2022 08:56:32 +0200 Message-ID: Subject: Re: [PATCH] frange: dump hex values when dumping FP numbers. To: Jakub Jelinek Cc: GCC patches , Richard Biener , Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000055130505e952ae67" X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000055130505e952ae67 Content-Type: text/plain; charset="UTF-8" On Thu, Sep 22, 2022 at 11:04 PM Jakub Jelinek wrote: > > On Thu, Sep 22, 2022 at 06:49:10PM +0200, Aldy Hernandez wrote: > > It has been suggested that if we start bumping numbers by an ULP when > > calculating open ranges (for example the numbers less than 3.0) that > > dumping these will become increasingly harder to read, and instead we > > should opt for the hex representation. I still find the floating > > point representation easier to read for most numbers, but perhaps we > > could have both? > > > > With this patch this is the representation for [15.0, 20.0]: > > > > [frange] float [1.5e+1 (0x0.fp+4), 2.0e+1 (0x0.ap+5)] > > > > Would you find this useful, or should we stick to the hex > > representation only (or something altogether different)? > > I think dumping both is the way to go, but real_to_hexadecimal doesn't > do anything useful with decimal floats, so that part should be > guarded on !DECIMAL_FLOAT_TYPE_P (type). Remember that decimal floats are not supported for frange, but I suppose it's good form to guard the print for when we do. > > Why do you build a tree + dump_generic_node for decimal instead of > real_to_decimal_for_mode ? Honestly, cause I was too lazy. That code is inherited from irange and I figured it's just a dumping routine, but I'm happy to fix it. > The former I think calls: > char string[100]; > real_to_decimal (string, &d, sizeof (string), 0, 1); > so perhaps: > char s[100]; > real_to_decimal_for_mode (s, &r, sizeof (string), 0, 1, TYPE_MODE (type)); > pp_string (pp, "%s", s); > if (!DECIMAL_FLOAT_TYPE_P (type)) > { > real_to_hexadecimal (s, &r, sizeof (s), 0, 1); > pp_printf (pp, " (%s)", s); > } > ? Thanks. I'm retesting the following and will commit if it succeeds since we seem to have overwhelming consensus :). Aldy --00000000000055130505e952ae67 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-frange-dump-hex-values-when-dumping-FP-numbers.patch" Content-Disposition: attachment; filename="0001-frange-dump-hex-values-when-dumping-FP-numbers.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8e4putq0 RnJvbSAyZjA1MjkwNDQxMmJiZTU4MjFlZTMxMDA2N2FkNzZiNTI5ODBkOGUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogVGh1LCAyMiBTZXAgMjAyMiAxODowNzowMyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGZyYW5n ZTogZHVtcCBoZXggdmFsdWVzIHdoZW4gZHVtcGluZyBGUCBudW1iZXJzLgoKSXQgaGFzIGJlZW4g c3VnZ2VzdGVkIHRoYXQgaWYgd2Ugc3RhcnQgYnVtcGluZyBudW1iZXJzIGJ5IGFuIFVMUCB3aGVu CmNhbGN1bGF0aW5nIG9wZW4gcmFuZ2VzIChmb3IgZXhhbXBsZSB0aGUgbnVtYmVycyBsZXNzIHRo YW4gMy4wKSB0aGF0CmR1bXBpbmcgdGhlc2Ugd2lsbCBiZWNvbWUgaW5jcmVhc2luZ2x5IGhhcmRl ciB0byByZWFkLCBhbmQgaW5zdGVhZCB3ZQpzaG91bGQgb3B0IGZvciB0aGUgaGV4IHJlcHJlc2Vu dGF0aW9uLiAgSSBzdGlsbCBmaW5kIHRoZSBmbG9hdGluZwpwb2ludCByZXByZXNlbnRhdGlvbiBl YXNpZXIgdG8gcmVhZCBmb3IgbW9zdCBudW1iZXJzLCBidXQgcGVyaGFwcyB3ZQpjb3VsZCBoYXZl IGJvdGg/CgpXaXRoIHRoaXMgcGF0Y2ggdGhpcyBpcyB0aGUgcmVwcmVzZW50YXRpb24gZm9yIFsx NS4wLCAyMC4wXToKCiAgICAgW2ZyYW5nZV0gZmxvYXQgWzEuNWUrMSAoMHgwLmZwKzQpLCAyLjBl KzEgKDB4MC5hcCs1KV0KCldvdWxkIHlvdSBmaW5kIHRoaXMgdXNlZnVsLCBvciBzaG91bGQgd2Ug c3RpY2sgdG8gdGhlIGhleApyZXByZXNlbnRhdGlvbiBvbmx5PwoKVGVzdGVkIG9uIHg4Ni02NCBM aW51eC4KCmdjYy9DaGFuZ2VMb2c6CgoJKiB2YWx1ZS1yYW5nZS1wcmV0dHktcHJpbnQuY2MgKHZy YW5nZV9wcmludGVyOjpwcmludF9yZWFsX3ZhbHVlKTogTmV3LgoJKHZyYW5nZV9wcmludGVyOjp2 aXNpdCk6IENhbGwgcHJpbnRfcmVhbF92YWx1ZS4KCSogdmFsdWUtcmFuZ2UtcHJldHR5LXByaW50 Lmg6IE5ldyBwcmludF9yZWFsX3ZhbHVlLgotLS0KIGdjYy92YWx1ZS1yYW5nZS1wcmV0dHktcHJp bnQuY2MgfCAxOSArKysrKysrKysrKysrKystLS0tCiBnY2MvdmFsdWUtcmFuZ2UtcHJldHR5LXBy aW50LmggIHwgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2djYy92YWx1ZS1yYW5nZS1wcmV0dHktcHJpbnQuY2MgYi9n Y2MvdmFsdWUtcmFuZ2UtcHJldHR5LXByaW50LmNjCmluZGV4IGViNzQ0MjIyOWJhLi44Y2JlOTdi NzZmZCAxMDA2NDQKLS0tIGEvZ2NjL3ZhbHVlLXJhbmdlLXByZXR0eS1wcmludC5jYworKysgYi9n Y2MvdmFsdWUtcmFuZ2UtcHJldHR5LXByaW50LmNjCkBAIC0xMTcsNiArMTE3LDE5IEBAIHZyYW5n ZV9wcmludGVyOjpwcmludF9pcmFuZ2VfYml0bWFza3MgKGNvbnN0IGlyYW5nZSAmcikgY29uc3QK ICAgcHBfc3RyaW5nIChwcCwgYnVmKTsKIH0KIAordm9pZAordnJhbmdlX3ByaW50ZXI6OnByaW50 X3JlYWxfdmFsdWUgKHRyZWUgdHlwZSwgY29uc3QgUkVBTF9WQUxVRV9UWVBFICZyKSBjb25zdAor eworICBjaGFyIHNbMTAwXTsKKyAgcmVhbF90b19kZWNpbWFsX2Zvcl9tb2RlIChzLCAmciwgc2l6 ZW9mIChzKSwgMCwgMSwgVFlQRV9NT0RFICh0eXBlKSk7CisgIHBwX3N0cmluZyAocHAsIHMpOwor ICBpZiAoIURFQ0lNQUxfRkxPQVRfVFlQRV9QICh0eXBlKSkKKyAgICB7CisgICAgICByZWFsX3Rv X2hleGFkZWNpbWFsIChzLCAmciwgc2l6ZW9mIChzKSwgMCwgMSk7CisgICAgICBwcF9wcmludGYg KHBwLCAiICglcykiLCBzKTsKKyAgICB9Cit9CisKIC8vIFByaW50IGFuIGZyYW5nZS4KIAogdm9p ZApAQCAtMTQxLDExICsxNTQsOSBAQCB2cmFuZ2VfcHJpbnRlcjo6dmlzaXQgKGNvbnN0IGZyYW5n ZSAmcikgY29uc3QKICAgYm9vbCBoYXNfZW5kcG9pbnRzID0gIXIua25vd25faXNuYW4gKCk7CiAg IGlmIChoYXNfZW5kcG9pbnRzKQogICAgIHsKLSAgICAgIGR1bXBfZ2VuZXJpY19ub2RlIChwcCwK LQkJCSBidWlsZF9yZWFsICh0eXBlLCByLmxvd2VyX2JvdW5kICgpKSwgMCwgVERGX05PTkUsIGZh bHNlKTsKKyAgICAgIHByaW50X3JlYWxfdmFsdWUgKHR5cGUsIHIubG93ZXJfYm91bmQgKCkpOwog ICAgICAgcHBfc3RyaW5nIChwcCwgIiwgIik7Ci0gICAgICBkdW1wX2dlbmVyaWNfbm9kZSAocHAs Ci0JCQkgYnVpbGRfcmVhbCAodHlwZSwgci51cHBlcl9ib3VuZCAoKSksIDAsIFRERl9OT05FLCBm YWxzZSk7CisgICAgICBwcmludF9yZWFsX3ZhbHVlICh0eXBlLCByLnVwcGVyX2JvdW5kICgpKTsK ICAgICB9CiAgIHBwX2NoYXJhY3RlciAocHAsICddJyk7CiAgIHByaW50X2ZyYW5nZV9uYW4gKHIp OwpkaWZmIC0tZ2l0IGEvZ2NjL3ZhbHVlLXJhbmdlLXByZXR0eS1wcmludC5oIGIvZ2NjL3ZhbHVl LXJhbmdlLXByZXR0eS1wcmludC5oCmluZGV4IDIwYzI2NTk4ZmU3Li5hOWFlNWE3YjRjYyAxMDA2 NDQKLS0tIGEvZ2NjL3ZhbHVlLXJhbmdlLXByZXR0eS1wcmludC5oCisrKyBiL2djYy92YWx1ZS1y YW5nZS1wcmV0dHktcHJpbnQuaApAQCAtMzIsNiArMzIsNyBAQCBwcml2YXRlOgogICB2b2lkIHBy aW50X2lyYW5nZV9ib3VuZCAoY29uc3Qgd2lkZV9pbnQgJncsIHRyZWUgdHlwZSkgY29uc3Q7CiAg IHZvaWQgcHJpbnRfaXJhbmdlX2JpdG1hc2tzIChjb25zdCBpcmFuZ2UgJikgY29uc3Q7CiAgIHZv aWQgcHJpbnRfZnJhbmdlX25hbiAoY29uc3QgZnJhbmdlICYpIGNvbnN0OworICB2b2lkIHByaW50 X3JlYWxfdmFsdWUgKHRyZWUgdHlwZSwgY29uc3QgUkVBTF9WQUxVRV9UWVBFICZyKSBjb25zdDsK IAogICBwcmV0dHlfcHJpbnRlciAqcHA7CiB9OwotLSAKMi4zNy4xCgo= --00000000000055130505e952ae67--