From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EA24D3858C83 for ; Mon, 7 Nov 2022 15:38:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA24D3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667835523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpWFRH3hcWyNQydokqdoSXKpR38AiRpSpILJ2SU69Xg=; b=eLJkuObvnGUTAnZHR787vB8s7oZUZqEL+Dqcz2FGRB+GAep226dVBqIe5E/MSOENFaKhSO b4XuxRjYHIqVCGS+O6WDhWQYWsOUtrudCaWm7ArDBZ682FpEzyN4O3ewjqsLuYz71hmyW6 ZWZEbh2DACKuuwUdBEUvmc6LP8uzVTI= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-592-1G86pCfWPBaGyadP5HP-ig-1; Mon, 07 Nov 2022 10:38:42 -0500 X-MC-Unique: 1G86pCfWPBaGyadP5HP-ig-1 Received: by mail-yb1-f200.google.com with SMTP id t9-20020a5b03c9000000b006cff5077dc9so11498129ybp.3 for ; Mon, 07 Nov 2022 07:38:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LpWFRH3hcWyNQydokqdoSXKpR38AiRpSpILJ2SU69Xg=; b=WOZrjd8HdnVn8p3ojAaxGGdnxWN6vtAob1igTGSynt4UaEZo/xFv/4yzPVHUguwM2z O2SvqBdcuNVPo42meIlu+qc54psmVbytEQ+WdjAsys999eQMV2l4on76de2On/j41Tcs Y4PMbGCxVFEeiE/WNkKoDo8XuDBFObht8FofuJtJU/jYreYz/SkaEhTjmwqHo1wqPTq5 hf9V/KI16CNDx984SMojWkQzHb3Z9c7wDfjiB0znN5MMS7BsoVSGD21+3gmjAJ9JsbnM TmQJVqODQe1wXmFbTpM/ybiF7kBX0uQclwpoG0b3HrPKEygnfFG1jlcSDB3m4KYhpcDn NkGQ== X-Gm-Message-State: ACrzQf3PhCBpsivny1pjcPykVNgpLm2j9JkMQ6CGDlIgGuvqSts4arSi OkQUw6Rki2LV496Jg3XLaZD3wvu0FtppwnDb2qRfyfEE3bRBbVfhhj4bctmDgbkaVYiE0ge5nqL 9igigQrtmt0qm1APA8G3xMKqI7dJbcATwHg== X-Received: by 2002:a81:1086:0:b0:36f:ce5a:982 with SMTP id 128-20020a811086000000b0036fce5a0982mr49342667ywq.158.1667835521640; Mon, 07 Nov 2022 07:38:41 -0800 (PST) X-Google-Smtp-Source: AMsMyM5Mma8+BL9VGqPLqjjEnKBwEOYwwNnQ5rpOlZQE9w8818xaF/akLUateFzlXH9PGAeZnk9H+wfGkXSZ0ALfFDY= X-Received: by 2002:a81:1086:0:b0:36f:ce5a:982 with SMTP id 128-20020a811086000000b0036fce5a0982mr49342648ywq.158.1667835521410; Mon, 07 Nov 2022 07:38:41 -0800 (PST) MIME-Version: 1.0 References: <20221013123649.474497-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Mon, 7 Nov 2022 16:38:29 +0100 Message-ID: Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. To: Jakub Jelinek Cc: "MacLeod, Andrew" , GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000cc50d005ece33778" X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000cc50d005ece33778 Content-Type: text/plain; charset="UTF-8" Fair enough. How's this? Tested on x86-64 Linux. LAPACK regression testing as well. On Mon, Nov 7, 2022 at 1:56 PM Jakub Jelinek wrote: > > On Mon, Nov 07, 2022 at 01:48:28PM +0100, Aldy Hernandez wrote: > > On Mon, Nov 7, 2022 at 1:43 PM Jakub Jelinek wrote: > > > > > > On Mon, Nov 07, 2022 at 01:35:35PM +0100, Aldy Hernandez wrote: > > > > Let me see if I understand you correctly... > > > > > > > > real_isdenormal is always returning false for our uses in frange? So > > > > instead of using real_isdenormal in flush_denormals_to_zero, perhaps > > > > we should be using: > > > > > > > > REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin > > > > > > > > ?? > > > > > > > > Could we perhaps make real_isdenormal always work for all values? Is > > > > that possible? > > > > > > Yes. Or have real_isdenormal_target for the uses in real.cc > > > which would be private to real.cc and would do what real_isdenormal > > > currently does, and then real_isdenormal with the above definition > > > (well, r->cl == rvc_normal && ...). > > > > If the REAL_EXP(r)... definition works for everyone, can't we just use > > that? Or do you think there'd be a measurable performance impact? > > It doesn't work alone. > > Either denormals are in normalized form, then > r->cl == rvc_normal && REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin > is true, or they are in denormal form, then > r->cl == rvc_normal && (r->sig[SIGSZ-1] & SIG_MSB) == 0 > is true. > > You could use > r->cl == rvc_normal > && (REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin > || (r->sig[SIGSZ-1] & SIG_MSB) == 0) > but that would be waste of compile time both in real.cc and outside of > real.cc. > > Jakub > --000000000000cc50d005ece33778 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Provide-normalized-and-denormal-format-version-of-re.patch" Content-Disposition: attachment; filename="0001-Provide-normalized-and-denormal-format-version-of-re.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_la6y6p9x0 RnJvbSBkMjE0YmNkZmYyY2I5MGFkMWViODA4ZDI5YmRhNmZiOThkNTEwYjRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogTW9uLCA3IE5vdiAyMDIyIDE0OjE4OjU3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gUHJvdmlk ZSBub3JtYWxpemVkIGFuZCBkZW5vcm1hbCBmb3JtYXQgdmVyc2lvbiBvZgogcmVhbF9pc2Rlbm9y bWFsLgoKSW1wbGVtZW50IHJlYWxfaXNkZW5vcm1hbF90YXJnZXQoKSB0byBiZSB1c2VkIHdpdGhp biByZWFsLmNjIHdoZXJlIHRoZQphcmd1bWVudCBpcyBrbm93biB0byBiZSBpbiBkZW5vcm1hbCBm b3JtYXQuICBSZXdyaXRlIHJlYWxfaXNkZW5vcm1hbCgpCmZvciB1c2Ugb3V0c2lkZSBvZiByZWFs LmNjIHdoZXJlIHRoZSBhcmd1bWVudCBpcyBrbm93biB0byBiZQpub3JtYWxpemVkLgoKZ2NjL0No YW5nZUxvZzoKCgkqIHJlYWwuY2MgKHJlYWxfaXNkZW5vcm1hbF90YXJnZXQpOiBOZXcuCgkoZW5j b2RlX2llZWVfc2luZ2xlKTogVXNlIHJlYWxfaXNkZW5vcm1hbF90YXJnZXQuCgkoZW5jb2RlX2ll ZWVfZG91YmxlKTogU2FtZS4KCShlbmNvZGVfaWVlZV9leHRlbmRlZCk6IFNhbWUuCgkoZW5jb2Rl X2llZWVfcXVhZCk6IFNhbWUuCgkoZW5jb2RlX2llZWVfaGFsZik6IFNhbWUuCgkoZW5jb2RlX2Fy bV9iZmxvYXRfaGFsZik6IFNhbWUuCgkqIHZhbHVlLXJhbmdlLmNjIChmcmFuZ2U6OmZsdXNoX2Rl bm9ybWFsc190b196ZXJvKTogU2FtZS4KCSogcmVhbC5oIChyZWFsX2lzZGVub3JtYWwpOiBSZXdy aXRlIHRvIGxvb2sgYXQgbW9kZS4KLS0tCiBnY2MvcmVhbC5jYyAgICAgICAgfCAyMiArKysrKysr KysrKysrKysrLS0tLS0tCiBnY2MvcmVhbC5oICAgICAgICAgfCAgNyArKysrLS0tCiBnY2MvdmFs dWUtcmFuZ2UuY2MgfCAgNSArKystLQogMyBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCsp LCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nY2MvcmVhbC5jYyBiL2djYy9yZWFsLmNj CmluZGV4IGFhZTdjMzM1ZDU5Li4wNThiMGI4ZGNiNCAxMDA2NDQKLS0tIGEvZ2NjL3JlYWwuY2MK KysrIGIvZ2NjL3JlYWwuY2MKQEAgLTExMSw2ICsxMTEsMTYgQEAgc3RhdGljIGNvbnN0IFJFQUxf VkFMVUVfVFlQRSAqIHJlYWxfZGlnaXQgKGludCk7CiBzdGF0aWMgdm9pZCB0aW1lc19wdGVuIChS RUFMX1ZBTFVFX1RZUEUgKiwgaW50KTsKIAogc3RhdGljIHZvaWQgcm91bmRfZm9yX2Zvcm1hdCAo Y29uc3Qgc3RydWN0IHJlYWxfZm9ybWF0ICosIFJFQUxfVkFMVUVfVFlQRSAqKTsKKworLyogRGV0 ZXJtaW5lIHdoZXRoZXIgYSBmbG9hdGluZy1wb2ludCB2YWx1ZSBYIGlzIGEgZGVub3JtYWwuICBS IGlzCisgICBleHBlY3RlZCB0byBiZSBpbiBkZW5vcm1hbCBmb3JtLCBzbyB0aGlzIGZ1bmN0aW9u IGlzIG9ubHkKKyAgIG1lYW5pbmdmdWwgYWZ0ZXIgYSBjYWxsIHRvIHJvdW5kX2Zvcl9mb3JtYXQu ICAqLworCitpbmxpbmUgYm9vbAorcmVhbF9pc2Rlbm9ybWFsX3RhcmdldCAoY29uc3QgUkVBTF9W QUxVRV9UWVBFICpyKQoreworICByZXR1cm4gKHItPnNpZ1tTSUdTWi0xXSAmIFNJR19NU0IpID09 IDA7Cit9CiAMCiAvKiBJbml0aWFsaXplIFIgd2l0aCBhIHBvc2l0aXZlIHplcm8uICAqLwogCkBA IC0yOTYyLDcgKzI5NzIsNyBAQCBlbmNvZGVfaWVlZV9zaW5nbGUgKGNvbnN0IHN0cnVjdCByZWFs X2Zvcm1hdCAqZm10LCBsb25nICpidWYsCiB7CiAgIHVuc2lnbmVkIGxvbmcgaW1hZ2UsIHNpZywg ZXhwOwogICB1bnNpZ25lZCBsb25nIHNpZ24gPSByLT5zaWduOwotICBib29sIGRlbm9ybWFsID0g cmVhbF9pc2Rlbm9ybWFsIChyKTsKKyAgYm9vbCBkZW5vcm1hbCA9IHJlYWxfaXNkZW5vcm1hbF90 YXJnZXQgKHIpOwogCiAgIGltYWdlID0gc2lnbiA8PCAzMTsKICAgc2lnID0gKHItPnNpZ1tTSUdT Wi0xXSA+PiAoSE9TVF9CSVRTX1BFUl9MT05HIC0gMjQpKSAmIDB4N2ZmZmZmOwpAQCAtMzE4Myw3 ICszMTkzLDcgQEAgZW5jb2RlX2llZWVfZG91YmxlIChjb25zdCBzdHJ1Y3QgcmVhbF9mb3JtYXQg KmZtdCwgbG9uZyAqYnVmLAogewogICB1bnNpZ25lZCBsb25nIGltYWdlX2xvLCBpbWFnZV9oaSwg c2lnX2xvLCBzaWdfaGksIGV4cDsKICAgdW5zaWduZWQgbG9uZyBzaWduID0gci0+c2lnbjsKLSAg Ym9vbCBkZW5vcm1hbCA9IHJlYWxfaXNkZW5vcm1hbCAocik7CisgIGJvb2wgZGVub3JtYWwgPSBy ZWFsX2lzZGVub3JtYWxfdGFyZ2V0IChyKTsKIAogICBpbWFnZV9oaSA9IHNpZ24gPDwgMzE7CiAg IGltYWdlX2xvID0gMDsKQEAgLTM0NDEsNyArMzQ1MSw3IEBAIGVuY29kZV9pZWVlX2V4dGVuZGVk IChjb25zdCBzdHJ1Y3QgcmVhbF9mb3JtYXQgKmZtdCwgbG9uZyAqYnVmLAogCQkgICAgICBjb25z dCBSRUFMX1ZBTFVFX1RZUEUgKnIpCiB7CiAgIHVuc2lnbmVkIGxvbmcgaW1hZ2VfaGksIHNpZ19o aSwgc2lnX2xvOwotICBib29sIGRlbm9ybWFsID0gcmVhbF9pc2Rlbm9ybWFsIChyKTsKKyAgYm9v bCBkZW5vcm1hbCA9IHJlYWxfaXNkZW5vcm1hbF90YXJnZXQgKHIpOwogCiAgIGltYWdlX2hpID0g ci0+c2lnbiA8PCAxNTsKICAgc2lnX2hpID0gc2lnX2xvID0gMDsKQEAgLTM5NzIsNyArMzk4Miw3 IEBAIGVuY29kZV9pZWVlX3F1YWQgKGNvbnN0IHN0cnVjdCByZWFsX2Zvcm1hdCAqZm10LCBsb25n ICpidWYsCiB7CiAgIHVuc2lnbmVkIGxvbmcgaW1hZ2UzLCBpbWFnZTIsIGltYWdlMSwgaW1hZ2Uw LCBleHA7CiAgIHVuc2lnbmVkIGxvbmcgc2lnbiA9IHItPnNpZ247Ci0gIGJvb2wgZGVub3JtYWwg PSByZWFsX2lzZGVub3JtYWwgKHIpOworICBib29sIGRlbm9ybWFsID0gcmVhbF9pc2Rlbm9ybWFs X3RhcmdldCAocik7CiAgIFJFQUxfVkFMVUVfVFlQRSB1OwogCiAgIGltYWdlMyA9IHNpZ24gPDwg MzE7CkBAIC00NzI5LDcgKzQ3MzksNyBAQCBlbmNvZGVfaWVlZV9oYWxmIChjb25zdCBzdHJ1Y3Qg cmVhbF9mb3JtYXQgKmZtdCwgbG9uZyAqYnVmLAogewogICB1bnNpZ25lZCBsb25nIGltYWdlLCBz aWcsIGV4cDsKICAgdW5zaWduZWQgbG9uZyBzaWduID0gci0+c2lnbjsKLSAgYm9vbCBkZW5vcm1h bCA9IHJlYWxfaXNkZW5vcm1hbCAocik7CisgIGJvb2wgZGVub3JtYWwgPSByZWFsX2lzZGVub3Jt YWxfdGFyZ2V0IChyKTsKIAogICBpbWFnZSA9IHNpZ24gPDwgMTU7CiAgIHNpZyA9IChyLT5zaWdb U0lHU1otMV0gPj4gKEhPU1RfQklUU19QRVJfTE9ORyAtIDExKSkgJiAweDNmZjsKQEAgLTQ4NDMs NyArNDg1Myw3IEBAIGVuY29kZV9hcm1fYmZsb2F0X2hhbGYgKGNvbnN0IHN0cnVjdCByZWFsX2Zv cm1hdCAqZm10LCBsb25nICpidWYsCiB7CiAgIHVuc2lnbmVkIGxvbmcgaW1hZ2UsIHNpZywgZXhw OwogICB1bnNpZ25lZCBsb25nIHNpZ24gPSByLT5zaWduOwotICBib29sIGRlbm9ybWFsID0gcmVh bF9pc2Rlbm9ybWFsIChyKTsKKyAgYm9vbCBkZW5vcm1hbCA9IHJlYWxfaXNkZW5vcm1hbF90YXJn ZXQgKHIpOwogCiAgIGltYWdlID0gc2lnbiA8PCAxNTsKICAgc2lnID0gKHItPnNpZ1tTSUdTWi0x XSA+PiAoSE9TVF9CSVRTX1BFUl9MT05HIC0gOCkpICYgMHg3ZjsKZGlmZiAtLWdpdCBhL2djYy9y ZWFsLmggYi9nY2MvcmVhbC5oCmluZGV4IDMwNmU5NTkzODY2Li5iMTRiY2RkM2ZkZSAxMDA2NDQK LS0tIGEvZ2NjL3JlYWwuaAorKysgYi9nY2MvcmVhbC5oCkBAIC0yODYsMTEgKzI4NiwxMiBAQCBl eHRlcm4gYm9vbCByZWFsX2lzbmFuIChjb25zdCBSRUFMX1ZBTFVFX1RZUEUgKik7CiAvKiBEZXRl cm1pbmUgd2hldGhlciBhIGZsb2F0aW5nLXBvaW50IHZhbHVlIFggaXMgYSBzaWduYWxpbmcgTmFO LiAgKi8KIGV4dGVybiBib29sIHJlYWxfaXNzaWduYWxpbmdfbmFuIChjb25zdCBSRUFMX1ZBTFVF X1RZUEUgKik7CiAKLS8qIERldGVybWluZSB3aGV0aGVyIGEgZmxvYXRpbmctcG9pbnQgdmFsdWUg WCBpcyBhIGRlbm9ybWFsLiAgKi8KKy8qIERldGVybWluZSB3aGV0aGVyIGZsb2F0aW5nLXBvaW50 IHZhbHVlIFIgaXMgYSBkZW5vcm1hbC4gIFRoaXMKKyAgIGZ1bmN0aW9uIGlzIG9ubHkgdmFsaWQg Zm9yIG5vcm1hbGl6ZWQgdmFsdWVzLiAgKi8KIGlubGluZSBib29sCi1yZWFsX2lzZGVub3JtYWwg KGNvbnN0IFJFQUxfVkFMVUVfVFlQRSAqcikKK3JlYWxfaXNkZW5vcm1hbCAoY29uc3QgUkVBTF9W QUxVRV9UWVBFICpyLCBtYWNoaW5lX21vZGUgbW9kZSkKIHsKLSAgcmV0dXJuIHItPmNsID09IHJ2 Y19ub3JtYWwgJiYgKHItPnNpZ1tTSUdTWi0xXSAmIFNJR19NU0IpID09IDA7CisgIHJldHVybiBy LT5jbCA9PSBydmNfbm9ybWFsICYmIFJFQUxfRVhQIChyKSA8IFJFQUxfTU9ERV9GT1JNQVQgKG1v ZGUpLT5lbWluOwogfQogCiAvKiBEZXRlcm1pbmUgd2hldGhlciBhIGZsb2F0aW5nLXBvaW50IHZh bHVlIFggaXMgZmluaXRlLiAgKi8KZGlmZiAtLWdpdCBhL2djYy92YWx1ZS1yYW5nZS5jYyBiL2dj Yy92YWx1ZS1yYW5nZS5jYwppbmRleCBhODU1YWFmNjI2Yy4uODU5YzdmYjRhZjkgMTAwNjQ0Ci0t LSBhL2djYy92YWx1ZS1yYW5nZS5jYworKysgYi9nY2MvdmFsdWUtcmFuZ2UuY2MKQEAgLTI2Niwx NSArMjY2LDE2IEBAIGZyYW5nZTo6Zmx1c2hfZGVub3JtYWxzX3RvX3plcm8gKCkKICAgaWYgKHVu ZGVmaW5lZF9wICgpIHx8IGtub3duX2lzbmFuICgpKQogICAgIHJldHVybjsKIAorICBtYWNoaW5l X21vZGUgbW9kZSA9IFRZUEVfTU9ERSAodHlwZSAoKSk7CiAgIC8vIEZsdXNoIFt4LCAtREVOT1JN QUxdIHRvIFt4LCAtMC4wXS4KLSAgaWYgKHJlYWxfaXNkZW5vcm1hbCAoJm1fbWF4KSAmJiByZWFs X2lzbmVnICgmbV9tYXgpKQorICBpZiAocmVhbF9pc2Rlbm9ybWFsICgmbV9tYXgsIG1vZGUpICYm IHJlYWxfaXNuZWcgKCZtX21heCkpCiAgICAgewogICAgICAgbV9tYXggPSBkY29uc3QwOwogICAg ICAgaWYgKEhPTk9SX1NJR05FRF9aRVJPUyAobV90eXBlKSkKIAltX21heC5zaWduID0gMTsKICAg ICB9CiAgIC8vIEZsdXNoIFsrREVOT1JNQUwsIHhdIHRvIFsrMC4wLCB4XS4KLSAgaWYgKHJlYWxf aXNkZW5vcm1hbCAoJm1fbWluKSAmJiAhcmVhbF9pc25lZyAoJm1fbWluKSkKKyAgaWYgKHJlYWxf aXNkZW5vcm1hbCAoJm1fbWluLCBtb2RlKSAmJiAhcmVhbF9pc25lZyAoJm1fbWluKSkKICAgICBt X21pbiA9IGRjb25zdDA7CiB9CiAKLS0gCjIuMzguMQoK --000000000000cc50d005ece33778--