From: Aldy Hernandez <aldyh@redhat.com>
To: Jeff Law <jeffreyalaw@gmail.com>,
Richard Biener <richard.guenther@gmail.com>,
Michael Matz <matz@suse.de>
Cc: Andrew MacLeod <amacleod@redhat.com>,
GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC] More jump threading restrictions in the presence of loops.
Date: Thu, 14 Oct 2021 11:25:53 +0200 [thread overview]
Message-ID: <CAGm3qMVccpQDFpt6aF99qnKwp7aUMMnRs+AMkNdtrLsRh_n3Rg@mail.gmail.com> (raw)
In-Reply-To: <CAGm3qMU3=7RnqZDsVhodmd0svhis9o6pU_iSLU_089==t09J6g@mail.gmail.com>
PING.
Note, that there are no PRs and nothing really dependent on this
patch. This has just been suggested as the right thing to do wrt
loops.
This patch fixes 6 XFAILs in our testsuite and has the added
side-effect of fixing the aarch64 bootstrap problem (though the
problem in the uninit code is still there).
This is a fundamental change in what we've traditionally allowed for
jump threading, but I think it's a good thing. It also paves the way
for combining the validity models for both the forward and the
backward threaders.
I am happy to field the PRs this may bring about, since every change
in the cost model has us questioning whether we should or shouldn't
thread a path. But I may need some help from y'all if there's a
missing thread that causes a regression in some other pass. That
being said, most of the issues that have come with the threader
changes haven't been because we thread less, but because we thread
more-- so perhaps restricting things is a good thing ;-).
Aldy
On Wed, Oct 6, 2021 at 12:22 PM Aldy Hernandez <aldyh@redhat.com> wrote:
>
> [Here go the bits by Richi, tested on x86-64 Linux, and ongoing tests
> on aarch64 and ppc64le.]
>
> There is a lot of fall-out from this patch, as there were many threading
> tests that assumed the restrictions introduced by this patch were valid.
> Some tests have merely shifted the threading to after loop
> optimizations, but others ended up with no threading opportunities at
> all. Surprisingly some tests ended up with more total threads. It was
> a crapshoot all around.
>
> On a postive note, there are 6 tests that no longer XFAIL, and one
> guality test which now passes.
>
> I would appreciate someone reviewing the test changes. I am unsure
> whether some of the tests should be removed, XFAILed, or some other
> thing.
>
> I felt a bit queasy about such a fundamental change wrt threading, so I
> ran it through my callgrind test harness (.ii files from a bootstrap).
> There was no change in overall compilation, DOM, or the VRP threaders.
>
> However, there was a slight increase of 1.63% in the backward threader.
> I'm pretty sure we could reduce this if we incorporated the restrictions
> into their profitability code. This way we could stop the search when
> we ran into one of these restrictions. Not sure it's worth it at this
> point.
>
> Note, that this ad-hoc testing is not meant to replace a more thorough
> SPEC, etc test.
>
> Tested on x86-64 Linux.
>
> OK pending tests on aarch64 and ppc64le?
>
> Co-authored-by: Richard Biener <rguenther@suse.de>
next prev parent reply other threads:[~2021-10-14 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 9:43 Aldy Hernandez
2021-10-04 13:31 ` Jeff Law
2021-10-04 13:36 ` Aldy Hernandez
2021-10-04 15:30 ` Jeff Law
2021-10-04 16:29 ` Michael Matz
2021-10-05 11:22 ` Richard Biener
2021-10-05 12:43 ` Michael Matz
2021-10-05 14:56 ` Jeff Law
2021-10-05 13:33 ` Aldy Hernandez
2021-10-05 15:10 ` Jeff Law
2021-10-05 16:08 ` Jeff Law
2021-10-05 16:22 ` Aldy Hernandez
2021-10-06 13:15 ` Andreas Schwab
2021-10-06 13:47 ` Aldy Hernandez
2021-10-06 15:03 ` Martin Sebor
2021-10-06 16:22 ` Aldy Hernandez
2021-10-06 17:03 ` Aldy Hernandez
2021-10-06 19:11 ` Martin Sebor
2021-10-06 23:00 ` Jeff Law
2021-10-06 23:06 ` Jeff Law
2021-10-07 8:15 ` Aldy Hernandez
2021-10-07 13:35 ` Jeff Law
2021-10-06 10:22 ` Aldy Hernandez
2021-10-14 9:25 ` Aldy Hernandez [this message]
2021-10-14 14:23 ` Jeff Law
2021-10-17 1:32 ` Jeff Law
2021-10-18 10:14 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm3qMVccpQDFpt6aF99qnKwp7aUMMnRs+AMkNdtrLsRh_n3Rg@mail.gmail.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=matz@suse.de \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).