From: Aldy Hernandez <aldyh@redhat.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH][pushed] VR: add missing override keyworks
Date: Tue, 16 Aug 2022 11:08:58 +0200 [thread overview]
Message-ID: <CAGm3qMVch0qmGj1ea+VCB3d8jNvVov3enHYzRqTaDhN-ZHERDQ@mail.gmail.com> (raw)
In-Reply-To: <97b4d7cd-2cf3-13a0-9c77-c9d1176f6a4f@suse.cz>
Thanks.
On Tue, Aug 16, 2022 at 11:07 AM Martin Liška <mliska@suse.cz> wrote:
>
> Pushing as it follows the same pattern as:
>
> virtual void set (tree, tree, value_range_kind = VR_RANGE) override;
>
> Martin
>
> Address:
>
> gcc/value-range-equiv.h:57:8: warning: 'set_undefined' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> gcc/value-range-equiv.h:58:8: warning: 'set_varying' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>
> gcc/ChangeLog:
>
> * value-range-equiv.h (class value_range_equiv):
> ---
> gcc/value-range-equiv.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/value-range-equiv.h b/gcc/value-range-equiv.h
> index 0a52d1372a1..ad8c640b15b 100644
> --- a/gcc/value-range-equiv.h
> +++ b/gcc/value-range-equiv.h
> @@ -54,8 +54,8 @@ class GTY((user)) value_range_equiv : public value_range
> bool equal_p (const value_range_equiv &, bool ignore_equivs) const;
>
> /* Types of value ranges. */
> - void set_undefined ();
> - void set_varying (tree);
> + void set_undefined () override;
> + void set_varying (tree) override;
>
> /* Equivalence bitmap methods. */
> bitmap equiv () const { return m_equiv; }
> --
> 2.37.1
>
prev parent reply other threads:[~2022-08-16 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 9:07 Martin Liška
2022-08-16 9:08 ` Aldy Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm3qMVch0qmGj1ea+VCB3d8jNvVov3enHYzRqTaDhN-ZHERDQ@mail.gmail.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).