* [PATCH][pushed] VR: add missing override keyworks
@ 2022-08-16 9:07 Martin Liška
2022-08-16 9:08 ` Aldy Hernandez
0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2022-08-16 9:07 UTC (permalink / raw)
To: gcc-patches
Pushing as it follows the same pattern as:
virtual void set (tree, tree, value_range_kind = VR_RANGE) override;
Martin
Address:
gcc/value-range-equiv.h:57:8: warning: 'set_undefined' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/value-range-equiv.h:58:8: warning: 'set_varying' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/ChangeLog:
* value-range-equiv.h (class value_range_equiv):
---
gcc/value-range-equiv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/value-range-equiv.h b/gcc/value-range-equiv.h
index 0a52d1372a1..ad8c640b15b 100644
--- a/gcc/value-range-equiv.h
+++ b/gcc/value-range-equiv.h
@@ -54,8 +54,8 @@ class GTY((user)) value_range_equiv : public value_range
bool equal_p (const value_range_equiv &, bool ignore_equivs) const;
/* Types of value ranges. */
- void set_undefined ();
- void set_varying (tree);
+ void set_undefined () override;
+ void set_varying (tree) override;
/* Equivalence bitmap methods. */
bitmap equiv () const { return m_equiv; }
--
2.37.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][pushed] VR: add missing override keyworks
2022-08-16 9:07 [PATCH][pushed] VR: add missing override keyworks Martin Liška
@ 2022-08-16 9:08 ` Aldy Hernandez
0 siblings, 0 replies; 2+ messages in thread
From: Aldy Hernandez @ 2022-08-16 9:08 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches, Andrew MacLeod
Thanks.
On Tue, Aug 16, 2022 at 11:07 AM Martin Liška <mliska@suse.cz> wrote:
>
> Pushing as it follows the same pattern as:
>
> virtual void set (tree, tree, value_range_kind = VR_RANGE) override;
>
> Martin
>
> Address:
>
> gcc/value-range-equiv.h:57:8: warning: 'set_undefined' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> gcc/value-range-equiv.h:58:8: warning: 'set_varying' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>
> gcc/ChangeLog:
>
> * value-range-equiv.h (class value_range_equiv):
> ---
> gcc/value-range-equiv.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/value-range-equiv.h b/gcc/value-range-equiv.h
> index 0a52d1372a1..ad8c640b15b 100644
> --- a/gcc/value-range-equiv.h
> +++ b/gcc/value-range-equiv.h
> @@ -54,8 +54,8 @@ class GTY((user)) value_range_equiv : public value_range
> bool equal_p (const value_range_equiv &, bool ignore_equivs) const;
>
> /* Types of value ranges. */
> - void set_undefined ();
> - void set_varying (tree);
> + void set_undefined () override;
> + void set_varying (tree) override;
>
> /* Equivalence bitmap methods. */
> bitmap equiv () const { return m_equiv; }
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 9:07 [PATCH][pushed] VR: add missing override keyworks Martin Liška
2022-08-16 9:08 ` Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).