From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A66853858C2F for ; Tue, 8 Nov 2022 23:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A66853858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667948756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ztu/8INEm8LzOUR0dTuRGsaEf7iF3h9Uk1aR1mp5gRQ=; b=dlToT3FnUluD2ZRh1VCl5jINeLAFC2aSMOe2HXu2K9msHkrWiGSAzjYQXuRzubkkdNDSRm WgkkPPoxWSM4PRjKkCXxGXy8DR7p/andLCxBRnKSCI5dH0yIWSTz+FXxnOzpeXSGFBFMP6 HndNFdCexJvtb7RbY/Q8BU6Htuz8HJY= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-258-3vHyI3cBMOG5fyt-Wg8eSw-1; Tue, 08 Nov 2022 18:05:55 -0500 X-MC-Unique: 3vHyI3cBMOG5fyt-Wg8eSw-1 Received: by mail-yb1-f200.google.com with SMTP id p66-20020a257445000000b006ca0ba7608fso15165716ybc.7 for ; Tue, 08 Nov 2022 15:05:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ztu/8INEm8LzOUR0dTuRGsaEf7iF3h9Uk1aR1mp5gRQ=; b=HY32fZ+6lIXdxdYWqimHodH2YU+o8TtGmtBSl+e+q4z6xBQbbEOe+/BWZm/gu20g9/ wbl4+gr5HWZcnInLp/kxfiQS0TjWfIWGfbrTBBSWpEF9dfqL26iIJrwX/LnqV3+cMtl4 Jvd2Y6apx2u8PzjDSmNBYULjGquoRFBcw1I2XbPotVs3PdX0H/AXpPkNQme+MSCGCV/U /R0kLX+AxH8jw6TB8ySY0gR/mu5j36CnPmFUqp/q+01cBLKje0F5q2IPasO5gQtTrgfX P8yrirzQWH+aRyKLbivvhR8e2kADa14uy8NcR0L9z42oOsKfVVruvBEKiU2m9DW3qYRE x1AQ== X-Gm-Message-State: ACrzQf3Mkn34m8D0gFP2GMxAOsnffjCxCP6Oa2dXyguaUlErdCTkgFTT iDOn+F3CEx27vt/az7GxQdPF3GDhj0p8FzsuHC54Tq1pVvfqtW4mtHZe6pJ44qt9ubX6Q+hLlle jQgu0b3pAlR35nhRACBHqiQFO9st0UbemZQ== X-Received: by 2002:a81:7c06:0:b0:369:2064:9762 with SMTP id x6-20020a817c06000000b0036920649762mr1037867ywc.154.1667948754670; Tue, 08 Nov 2022 15:05:54 -0800 (PST) X-Google-Smtp-Source: AMsMyM63VFZF3/5DKCa/I6Xx0h3fQGQbEG2793Zg2492LqNJtwOt3HB66wbsUU3h08tQcIz4wI6x+old0uoTJcrt6TY= X-Received: by 2002:a81:7c06:0:b0:369:2064:9762 with SMTP id x6-20020a817c06000000b0036920649762mr1037864ywc.154.1667948754383; Tue, 08 Nov 2022 15:05:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aldy Hernandez Date: Wed, 9 Nov 2022 00:05:43 +0100 Message-ID: Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. To: Jakub Jelinek Cc: GCC patches , Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sigh, one more thing. There are further possibilities for a NAN result, even if the operands are !NAN and the result from frange_arithmetic is free of NANs. Adding different signed infinities. For example, [-INF,+INF] + [-INF,+INF] has the possibility of adding -INF and +INF, which is a NAN. Since we end up calling frange arithmetic on the lower bounds and then on the upper bounds, we miss this, and mistakenly think we're free of NANs. I have a patch in testing, but FYI, in case anyone notices this before I get around to it tomorrow. Aldy On Tue, Nov 8, 2022 at 3:11 PM Jakub Jelinek wrote: > > On Tue, Nov 08, 2022 at 03:06:53PM +0100, Aldy Hernandez wrote: > > +// If either operand is a NAN, set R to the combination of both NANs > > +// signwise and return TRUE. > > This comment doesn't describe what it does now. > If either operand is a NAN, set R to NAN with unspecified sign bit and return > TRUE. > ? > > Other than this LGTM. > > Jakub >