public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
	Richard Biener <richard.guenther@gmail.com>,
	 Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] Handle > INF and < INF correctly in range-op-float.cc
Date: Tue, 6 Sep 2022 09:49:55 +0200	[thread overview]
Message-ID: <CAGm3qMVeTQFbovfbvQwnDkREFW1ZweXEWrM19gTaz9HWF=2YLw@mail.gmail.com> (raw)
In-Reply-To: <Yxb6T6NoDmOQMvRu@tucnak>

On Tue, Sep 6, 2022 at 9:44 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Tue, Sep 06, 2022 at 09:40:59AM +0200, Aldy Hernandez wrote:
> > if (x <= Inf)
>
> This will be [-Inf, Inf] !NAN on the true side and
> NAN (either sign) on the false side indeed.
>
> > if (x < -Inf)
>
> will be NAN (either sign) on the true side and
> [-Inf, Inf] !NAN on the false side.

Sweet, that's exactly what I thought, thus the patch.

Furthermore, for !HONOR_NANS I would expect the NAN sides above to be
UNDEFINED/unreachable.  That is, the false side of x <= Inf when
!HONOR_NANS is unreachable.

Agreed?

Aldy


  reply	other threads:[~2022-09-06  7:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  7:29 Aldy Hernandez
2022-09-06  7:35 ` Jakub Jelinek
2022-09-06  7:40   ` Aldy Hernandez
2022-09-06  7:44     ` Jakub Jelinek
2022-09-06  7:49       ` Aldy Hernandez [this message]
2022-09-06  7:59         ` Jakub Jelinek
2022-09-06 11:47           ` Aldy Hernandez
2022-09-06 12:06             ` Jakub Jelinek
2022-09-06 12:17               ` Richard Biener
2022-09-06 12:32                 ` Aldy Hernandez
2022-09-06 12:38               ` Koning, Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGm3qMVeTQFbovfbvQwnDkREFW1ZweXEWrM19gTaz9HWF=2YLw@mail.gmail.com' \
    --to=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).