From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 761EA386CE40 for ; Thu, 30 Jun 2022 08:43:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 761EA386CE40 Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-195-p_IQr--kMqOgEikfq5XIZA-1; Thu, 30 Jun 2022 04:43:07 -0400 X-MC-Unique: p_IQr--kMqOgEikfq5XIZA-1 Received: by mail-oi1-f198.google.com with SMTP id cj16-20020a0568081b9000b00335bed54cfaso953466oib.16 for ; Thu, 30 Jun 2022 01:43:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mYuR8UphsCkl5ZEHUxJxDz91USvoWIfv/AFUuxvhlQE=; b=7b+JznPIwKfVnKTT3uRO/rte3Lw0BWQPI1n7r4uDmvP8DKw50DeogwUw/0tcpMxc9A 8FsI/cvR62tZPUN/vD4Kw4iVtwdH4341Md+Iobicqhzt2Rgz21vx1Aau6b+fOE8buEeB E49uGPmZFCimhC+bCNI0ER/+qX8L+j8qB4WsqZ8tsv+uIy8PuAeN8M8jQQZEkw1hfyob ezMbKpZYQ5QpSv1ST/JNGXipgJY1EZoMP+xfGWMPmKwifD3JxZ/Z2UV1Cq2Fkz6J39Xn aNuxg0Jeolh6XdK0vmLtipnQa2EFEBE9UUy28SH+cZphci1+Ikm/4cNT61QOl69wlQi3 YBUQ== X-Gm-Message-State: AJIora9H8CDOB8j5LAuUDutNC3xqJIhffiSpx4Ke1p5y+ugM/GS01a7N 2sCa6xgP5oH3lkrP8sXEIdM+IE9COQ946vR2WVHMHG2qwp8qxdub32GadGG+NKa7AdsGvgZLPhP h+Z+q8O8s00KiUdurk2N+0+ksb8HX6PuS/g== X-Received: by 2002:a05:6808:1a26:b0:335:63ee:7c32 with SMTP id bk38-20020a0568081a2600b0033563ee7c32mr5699809oib.36.1656578586971; Thu, 30 Jun 2022 01:43:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1snd3JGK1cA6aXo7O2FDU5GLRkGSdpewJ3wB+VJR8pRL9JihWtHfPf6Bnha4mxQ1tS9EQtCElc85u1t/lpeGcM= X-Received: by 2002:a05:6808:1a26:b0:335:63ee:7c32 with SMTP id bk38-20020a0568081a2600b0033563ee7c32mr5699801oib.36.1656578586768; Thu, 30 Jun 2022 01:43:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aldy Hernandez Date: Thu, 30 Jun 2022 10:42:55 +0200 Message-ID: Subject: Re: [PATCH][pushed] remove dead member variable in dom_jt_state To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: gcc-patches , Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 08:43:10 -0000 Anything dealing with the hybrid threader could probably use a little clean up. I've neglected to do so, as I'm hoping to nuke the forward threader altogether and replace it with the backwards threader. However, in order to do this, we need to implement prange (pointers) and frange (floats) to handle the slack currently being picked up by DOM. Anywhoo...thanks for doing this. Aldy On Thu, Jun 30, 2022 at 10:29 AM Martin Li=C5=A1ka wrote: > > Hi. > > I'm going to push the following clean-up. > > Martin > > gcc/ChangeLog: > > * tree-ssa-dom.cc (pass_dominator::execute): Remove m_ranger as > it is unused. > --- > gcc/tree-ssa-dom.cc | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc > index dcaf4672b66..9b6520fd2dd 100644 > --- a/gcc/tree-ssa-dom.cc > +++ b/gcc/tree-ssa-dom.cc > @@ -588,9 +588,8 @@ record_edge_info (basic_block bb) > class dom_jt_state : public jt_state > { > public: > - dom_jt_state (const_and_copies *copies, avail_exprs_stack *avails, > - gimple_ranger *ranger) > - : m_copies (copies), m_avails (avails), m_ranger (ranger) > + dom_jt_state (const_and_copies *copies, avail_exprs_stack *avails) > + : m_copies (copies), m_avails (avails) > { > } > void push (edge e) override > @@ -613,7 +612,6 @@ public: > private: > const_and_copies *m_copies; > avail_exprs_stack *m_avails; > - gimple_ranger *m_ranger; > }; > > void > @@ -794,7 +792,7 @@ pass_dominator::execute (function *fun) > gimple_ranger *ranger =3D enable_ranger (fun); > path_range_query path_query (/*resolve=3D*/true, ranger); > dom_jt_simplifier simplifier (avail_exprs_stack, ranger, &path_query); > - dom_jt_state state (const_and_copies, avail_exprs_stack, ranger); > + dom_jt_state state (const_and_copies, avail_exprs_stack); > jump_threader threader (&simplifier, &state); > dom_opt_dom_walker walker (CDI_DOMINATORS, > &threader, > -- > 2.36.1 >