* [PATCH] Remove unused variable.
@ 2021-05-13 9:06 Martin Liška
2021-05-13 13:43 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Martin Liška @ 2021-05-13 9:06 UTC (permalink / raw)
To: gcc-patches
Addresses the following clang warning:
gcc/tree-ssa-dom.c:652:33: warning: private field 'm_simplifier' is not used [-Wunused-private-field]
Ready for master?
Thanks
gcc/ChangeLog:
* tree-ssa-dom.c: Remove m_simplifier.
---
gcc/tree-ssa-dom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gcc/tree-ssa-dom.c b/gcc/tree-ssa-dom.c
index 11b86b2a326..075b1ccb9de 100644
--- a/gcc/tree-ssa-dom.c
+++ b/gcc/tree-ssa-dom.c
@@ -649,7 +649,6 @@ private:
void test_for_singularity (gimple *, avail_exprs_stack *);
- dom_jump_threader_simplifier *m_simplifier;
jump_threader *m_threader;
evrp_range_analyzer *m_evrp_range_analyzer;
};
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused variable.
2021-05-13 9:06 [PATCH] Remove unused variable Martin Liška
@ 2021-05-13 13:43 ` Jeff Law
2021-05-13 19:48 ` Aldy Hernandez
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2021-05-13 13:43 UTC (permalink / raw)
To: Martin Liška, gcc-patches
On 5/13/2021 3:06 AM, Martin Liška wrote:
> Addresses the following clang warning:
> gcc/tree-ssa-dom.c:652:33: warning: private field 'm_simplifier' is
> not used [-Wunused-private-field]
>
> Ready for master?
> Thanks
>
> gcc/ChangeLog:
>
> * tree-ssa-dom.c: Remove m_simplifier.
I wonder if Aldy's refactor accidentally dropped the ephemeral
simplifications based on the threading path equivalences which is what I
think this is supposed to be supporting. Given that the refactor didn't
cause any regressions, if that capability did get dropped, it couldn't
be too important anymore.
OK for the trunk,
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused variable.
2021-05-13 13:43 ` Jeff Law
@ 2021-05-13 19:48 ` Aldy Hernandez
0 siblings, 0 replies; 3+ messages in thread
From: Aldy Hernandez @ 2021-05-13 19:48 UTC (permalink / raw)
To: Jeff Law; +Cc: Martin Liška, gcc-patches
On Thu, May 13, 2021 at 9:43 AM Jeff Law via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> On 5/13/2021 3:06 AM, Martin Liška wrote:
> > Addresses the following clang warning:
> > gcc/tree-ssa-dom.c:652:33: warning: private field 'm_simplifier' is
> > not used [-Wunused-private-field]
> >
> > Ready for master?
> > Thanks
> >
> > gcc/ChangeLog:
> >
> > * tree-ssa-dom.c: Remove m_simplifier.
>
> I wonder if Aldy's refactor accidentally dropped the ephemeral
> simplifications based on the threading path equivalences which is what I
> think this is supposed to be supporting. Given that the refactor didn't
> cause any regressions, if that capability did get dropped, it couldn't
> be too important anymore.
The dom_opt_dom_walker is instantiated with a threader, which contains
a simplifier. So it got shuffled around, but the functionality should
still be there.
Thanks for catching this Martin.
Aldy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-13 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 9:06 [PATCH] Remove unused variable Martin Liška
2021-05-13 13:43 ` Jeff Law
2021-05-13 19:48 ` Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).