From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E075F3857011 for ; Mon, 12 Sep 2022 13:13:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E075F3857011 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662988380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=leDVAx9KOR3aQXB9bxC8B+1vDt+Bj65vgzRuSyfmTuk=; b=eApKR8rpIh+YZGCFLOHB6tb4nmevmi1eT9SOGY32bJC/PjygSthhRigQoIDa6Ru4lW8AFW wlQEO/AQrIpf4a+QZY2+EUABa/Z93OYZimMIQWA1BnhrrMZCil2uAqPpjQE8uwOgVZQODz qjlkbGidsXMQ4UhqojaRYYok3SP7vDk= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-359-uTLwDddAN96qSWgJ_2BapA-1; Mon, 12 Sep 2022 09:12:59 -0400 X-MC-Unique: uTLwDddAN96qSWgJ_2BapA-1 Received: by mail-oo1-f71.google.com with SMTP id f6-20020a4a9206000000b0044e001dc716so4268884ooh.20 for ; Mon, 12 Sep 2022 06:12:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=leDVAx9KOR3aQXB9bxC8B+1vDt+Bj65vgzRuSyfmTuk=; b=AOUJ0z5WKmwE9oDLa9ZVywrSzd9FanW9xLjOnxCKeLBElyEJ49pvroF7LfrXiz0RH7 iDqRWoiL6ErASmKgF2pTs9zmpr80KujUX/TxY/2pSITjMRTCXofuHq0WCjXA++I2tPAR VO9GRKIhfcIXjKcGIDT7MiaIV61Bi8rLd/7CfviGQJ74yjMWJ3Tx9EtNuR8xuCpvvz0Z 5cvWuI/leJQVvF0zd0iiFk/09escsG8vA6IKsne5NWOUe5OQ6407fkVALHeBogWTNmTb OLBB//zwgzvWPsYrH0cMStJvioaK+Gb8kIJLDibqdsoMVkmNzFSMSwRRy3XTHACi1pDc LaAQ== X-Gm-Message-State: ACgBeo2pCWEJ8GuDX2m7mtr0AGVP7OazCiAEMvZ9A8yJNXYo/9gvdedW 2IafMgeVZQn6spxeUBx4Qg8m5+laQr6YP5IH6icOMK0TghJrn6aXey5OGL8zskFRPCOSnUGk+SL IrYkMZBMEsR8stJdUrgp/6xJmImRk0/iU7g== X-Received: by 2002:a05:6870:160c:b0:12b:9663:67ca with SMTP id b12-20020a056870160c00b0012b966367camr2582286oae.36.1662988378443; Mon, 12 Sep 2022 06:12:58 -0700 (PDT) X-Google-Smtp-Source: AA6agR5nLICLVcCB5rg+D+1fz6NtzaAPGZ+pUZjXQNLx+sr9jSAh3eEJqLnBrwVgIxB8RZtOEH5Y8hXebDzOrqUE5QQ= X-Received: by 2002:a05:6870:160c:b0:12b:9663:67ca with SMTP id b12-20020a056870160c00b0012b966367camr2582274oae.36.1662988378216; Mon, 12 Sep 2022 06:12:58 -0700 (PDT) MIME-Version: 1.0 References: <20220908062759.3610257-1-aldyh@redhat.com> <7BAA2838-822A-4DF0-B712-00C265DFECEC@gmail.com> <20220912084147.v54scz6dbnlxsijv@lug-owl.de> In-Reply-To: <20220912084147.v54scz6dbnlxsijv@lug-owl.de> From: Aldy Hernandez Date: Mon, 12 Sep 2022 15:12:46 +0200 Message-ID: Subject: Re: [PATCH] Implement known/maybe fpclassify like API for frange. To: Jan-Benedict Glaw Cc: Paul Koning , Richard Biener , Jakub Jelinek , GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Sep 12, 2022 at 10:48 AM Jan-Benedict Glaw wrote: > > Hi Aldy! > > On Thu, 2022-09-08 12:56:24 +0200, Aldy Hernandez via Gcc-patches wrote: > > > From 795baa0b044953e9f198f49e379374d633f43b47 Mon Sep 17 00:00:00 2001 > > From: Aldy Hernandez > > Date: Thu, 8 Sep 2022 08:11:43 +0200 > > Subject: [PATCH] Implement known/maybe fpclassify like API for frange. > > > > gcc/ChangeLog: > > > > * gimple-range-fold.cc > > (fold_using_range::range_of_builtin_int_call): Use fpclassify like API. > > * range-op-float.cc (finite_operand_p): Same. > > (finite_operands_p): Same. > > (foperator_lt::fold_range): Same. > > (foperator_le::fold_range): Same. > > (foperator_gt::fold_range): Same. > > (foperator_ge::fold_range): Same. > > (foperator_unordered::fold_range): Same. > > (foperator_unordered::op1_range): Same. > > (foperator_ordered::fold_range): Same. > > * value-range.cc (frange::set_nan): Same. > > (frange::set_signbit): Same. > > (frange::union_): Same. > > (frange::intersect): Same. > > (frange::operator==): Same. > > (frange::singleton_p): Same. > > (frange::verify_range): Same. > > (range_tests_nan): Same. > > (range_tests_floats): Same. > > * value-range.h(frange::known_finite): New. > > (frange::maybe_inf): New. > > (frange::known_inf): New. > > (frange::maybe_nan): New. > > (frange::known_nan): New. > > (frange::known_signbit): New. > > --- > > gcc/gimple-range-fold.cc | 19 +++--- > > gcc/range-op-float.cc | 26 ++++---- > > gcc/value-range.cc | 126 +++++++++++++++++++++++---------------- > > gcc/value-range.h | 78 +++++++++++++++++++++++- > > 4 files changed, 170 insertions(+), 79 deletions(-) > > This triggers a selftest failure for pdp11: > > .../gcc/configure --prefix=... --enable-werror-always --enable-languages=all --disable-gcov --disable-shared --disable-threads --target=pdp11-aout --without-headers I have just pushed a patch to fix this. I have also added -ffinite-math-only selftests to my list of testing requirements for all future frange work. Thanks for reporting this. Aldy