From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4CAA43858D33 for ; Wed, 1 Mar 2023 10:10:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CAA43858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677665457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LT5bIQ/5/SoZrMuSW5At29+EOh79DKaR82sYtVa7+2Q=; b=BIOyyjZxQkb4EXi31F2eVOizcrpO1G91HIkthdQqoq7uoWAVF3/HPkT0USawOxJ4a5eu4B mnYGMd9v38t4rippyfsXefnuilcnddp4OeAwrh284FOuxAWtTlL8B+M/lochR67PJAiT/4 R6DrDfhoLO6gkHjQz/oAZpR5C4GKd/A= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-512-gweqUXSPMzaGlhU4lJHk8w-1; Wed, 01 Mar 2023 05:10:55 -0500 X-MC-Unique: gweqUXSPMzaGlhU4lJHk8w-1 Received: by mail-ed1-f72.google.com with SMTP id y24-20020aa7ccd8000000b004be3955a42eso189591edt.22 for ; Wed, 01 Mar 2023 02:10:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677665454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LT5bIQ/5/SoZrMuSW5At29+EOh79DKaR82sYtVa7+2Q=; b=oG/ZGzMIiluWu6z2OxU29+gTBePyPTMkrXZmcjw78Wn/WgetTy5T2UeYWpIDpP8RfS sJN8riUHOoAtyXYpTJVmH9vtSF9ppgw7AF2T94cY3GFHKDXqd/bjUKl+qlvO8Lglsid1 ArLdu5pe1LPW0KJrfEq+YU4q1XRBKM/FYw8qhzDshNfiAAf5UJB4GBZP7aFTbOdbMK5S Jvuwxa1m6tUzTBUbxi85TPfeQQqBJm/W2vPUC3+sSXkFNGWPWI/BBILJjon2q5O+x+I6 xUcfwlGAeuLzhxXosYVn/ozPruxpJn0fA42L4bJwwdKx0QxnnNkcBCs0usrJXvVD5dQF w0gA== X-Gm-Message-State: AO0yUKWGnzXYNMwOZSwIlz7IvQMIO4vZ7WH6YIxHVuPRNR1u1FoCci8o Ale2MZynWyffD/4tst8HqJJflc1QK++A+5q5vQqHOKGtEf4Ikgsmt/SPQcTMWThYRm1dgAZh/zq Yu7/l4mo7PN0Ie4xqml5kQGpJUqdG7GhZNRpr/Yo= X-Received: by 2002:a17:906:1582:b0:8b1:7de9:b39b with SMTP id k2-20020a170906158200b008b17de9b39bmr2998549ejd.1.1677665454228; Wed, 01 Mar 2023 02:10:54 -0800 (PST) X-Google-Smtp-Source: AK7set/AH2s4jtcvrJhUqzluolyE94ks5+hxvbQWqfl1y+Vw+0Z1VbtI3mjOFpjTpwB3OEtcxsYo0VNXRLu8FWBBV0M= X-Received: by 2002:a17:906:1582:b0:8b1:7de9:b39b with SMTP id k2-20020a170906158200b008b17de9b39bmr2998546ejd.1.1677665453976; Wed, 01 Mar 2023 02:10:53 -0800 (PST) MIME-Version: 1.0 References: <20230228134725.02E8813440@imap2.suse-dmz.suse.de> In-Reply-To: <20230228134725.02E8813440@imap2.suse-dmz.suse.de> From: Aldy Hernandez Date: Wed, 1 Mar 2023 11:10:43 +0100 Message-ID: Subject: Re: [PATCH 2/5] fend off anti-ranges from value-range-storage To: Richard Biener Cc: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK. Thanks. On Tue, Feb 28, 2023 at 2:48=E2=80=AFPM Richard Biener via Gcc-patches wrote: > > The following avoids the need to special-case storage requirement > and copying for irange_storage_slot by making sure we canonicalize > such ranges to int_range<2>. > > * tree-ssanames.cc (range_info_set_range): If receiving > an anti-range recurse with a temporary int_range<2>. > * value-range-storage.cc (irange_storage_slot::size): > Assert we're not asking for a VR_ANTI_RANGE. > --- > gcc/tree-ssanames.cc | 3 +++ > gcc/value-range-storage.cc | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gcc/tree-ssanames.cc b/gcc/tree-ssanames.cc > index 08aa166ef17..23468958586 100644 > --- a/gcc/tree-ssanames.cc > +++ b/gcc/tree-ssanames.cc > @@ -127,6 +127,9 @@ range_info_get_range (tree name, vrange &r) > inline bool > range_info_set_range (tree name, const vrange &r) > { > + if (r.kind () =3D=3D VR_ANTI_RANGE) > + return range_info_set_range (name, int_range<2> (as_a (r)))= ; > + > if (!range_info_p (name) || !range_info_fits_p (name, r)) > { > if (range_info_p (name)) > diff --git a/gcc/value-range-storage.cc b/gcc/value-range-storage.cc > index bf23f6dd476..79ab2921a03 100644 > --- a/gcc/value-range-storage.cc > +++ b/gcc/value-range-storage.cc > @@ -182,7 +182,7 @@ irange_storage_slot::get_irange (irange &r, tree type= ) const > size_t > irange_storage_slot::size (const irange &r) > { > - gcc_checking_assert (!r.undefined_p ()); > + gcc_checking_assert (!r.undefined_p () && r.kind () !=3D VR_ANTI_RANGE= ); > > unsigned prec =3D TYPE_PRECISION (r.type ()); > unsigned n =3D num_wide_ints_needed (r); > -- > 2.35.3 >