From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 049C93858D1E for ; Wed, 9 Nov 2022 06:59:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 049C93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667977185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X76R5Oada5JKL1GqAG+zaNSmDwdMtk60h2otAWZcXzs=; b=P/whx/M+KjXGSxLkKXaQyyVnjHMp6mS5dLyT1gkUkNFDnxODNVOrqBclcxHnataMN9d2eX PpZaEk6uDVpa2jD2W1ztqv0OrdfZIAe6zbKp//8msG/1Xs89rtCUgXA/zqHNivq0eFrfoD 6eKODmUtT7uOX5qOYNcrXpBgYZ/ouSY= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-650-snxqLwRGNwaz5TlQK99xxA-1; Wed, 09 Nov 2022 01:59:43 -0500 X-MC-Unique: snxqLwRGNwaz5TlQK99xxA-1 Received: by mail-yb1-f198.google.com with SMTP id h67-20020a252146000000b006ccc4702068so16131594ybh.12 for ; Tue, 08 Nov 2022 22:59:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X76R5Oada5JKL1GqAG+zaNSmDwdMtk60h2otAWZcXzs=; b=bZNl7hL//eToMjYg5Xi79B/KBhbmvWhMiSVJWrruAe32E99O+66nJ6MBmFeAhroA3A C5w9+NsGtCbjSXu94DP5lA4JELOyiUv8SMVypjzykOjVbMIQqszrwYsMoUmLHJd9wkrD 0VDq4hUGqKno33teM+M2NLzjvV57Fryg6JAHVw0I+eTGIQxWnmk2fbNzdQJ3GK2GNN36 M2MN/uKeNEe0OZt08JujZxuKzs0ympo6HIL2vkEWOHir6xi5WOTaBVFQj/yppy9QmIgv ei+0TPXR41m36ir/ukIe2GKMLEwSeFjAvnTH8fGLHlL2Dcolnnra+2oVOD1fi/h3HmKD pDgg== X-Gm-Message-State: ACrzQf2+LqGzwZXFgmA3/njY+QTSX4G66G02yYSGRnuA/4W7orJEr14o HF+GItq9kZe9kmhy5i8GRKl6/Os8kNsEwnzltCQpKeFrUbsCXUHAFo8tk/z1A1h132e4BhYt30e JNu5zx7GBQjkuPvdWAj8OeSgN9zvRfkbbQQ== X-Received: by 2002:a0d:cdc2:0:b0:34d:101b:53c with SMTP id p185-20020a0dcdc2000000b0034d101b053cmr58074692ywd.444.1667977183353; Tue, 08 Nov 2022 22:59:43 -0800 (PST) X-Google-Smtp-Source: AMsMyM4yNvnAXgW/hNzNAJa/B1jL1uisGiAF/6vNW1ahWqxw5isPr6cTSVAjnTREx0rl8h8s4uLSQIxfPq/uXLKSie0= X-Received: by 2002:a0d:cdc2:0:b0:34d:101b:53c with SMTP id p185-20020a0dcdc2000000b0034d101b053cmr58074682ywd.444.1667977183084; Tue, 08 Nov 2022 22:59:43 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aldy Hernandez Date: Wed, 9 Nov 2022 07:59:31 +0100 Message-ID: Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. To: Jakub Jelinek Cc: GCC patches , Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="0000000000007df09d05ed0433f8" X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007df09d05ed0433f8 Content-Type: text/plain; charset="UTF-8" This patch fixes the oversight. Tested on x86-64 Linux. Pushed. On Wed, Nov 9, 2022 at 12:05 AM Aldy Hernandez wrote: > > Sigh, one more thing. > > There are further possibilities for a NAN result, even if the operands > are !NAN and the result from frange_arithmetic is free of NANs. > Adding different signed infinities. > > For example, [-INF,+INF] + [-INF,+INF] has the possibility of adding > -INF and +INF, which is a NAN. Since we end up calling frange > arithmetic on the lower bounds and then on the upper bounds, we miss > this, and mistakenly think we're free of NANs. > > I have a patch in testing, but FYI, in case anyone notices this before > I get around to it tomorrow. > > Aldy > > On Tue, Nov 8, 2022 at 3:11 PM Jakub Jelinek wrote: > > > > On Tue, Nov 08, 2022 at 03:06:53PM +0100, Aldy Hernandez wrote: > > > +// If either operand is a NAN, set R to the combination of both NANs > > > +// signwise and return TRUE. > > > > This comment doesn't describe what it does now. > > If either operand is a NAN, set R to NAN with unspecified sign bit and return > > TRUE. > > ? > > > > Other than this LGTM. > > > > Jakub > > --0000000000007df09d05ed0433f8 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-range-op-float-Set-NAN-possibility-for-INF-INF-and-v.patch" Content-Disposition: attachment; filename="0001-range-op-float-Set-NAN-possibility-for-INF-INF-and-v.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_la9aitxr0 RnJvbSA2OGIwNjE1YmUyYWFmZjNhOGNlOTFiYTdjZDBmNjllYmJkOTM3MDJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogVHVlLCA4IE5vdiAyMDIyIDIzOjQyOjA0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gW3Jhbmdl LW9wLWZsb2F0XSBTZXQgTkFOIHBvc3NpYmlsaXR5IGZvciBJTkYgKyAoLUlORikgYW5kCiB2aWNl IHZlcnNhLgoKU29tZSBjb21iaW5hdGlvbnMgb2Ygb3BlcmF0aW9ucyBjYW4geWllbGQgYSBOQU4g ZXZlbiBpZiBubyBvcGVyYW5kcwpoYXZlIHRoZSBwb3NzaWJsaXR5IG9mIGEgTkFOLiAgRm9yIGV4 YW1wbGUsIFstSU5GXSArIFsrSU5GXSA9IE5BTiBhbmQKdmljZSB2ZXJzYS4KCkZvciBbLUlORiwr SU5GXSArIFstSU5GLCtJTkZdLCBmcmFuZ2VfYXJpdGhtZXRpYyB3aWxsIG5vdCByZXR1cm4gYQpO QU4sIGFuZCBzaW5jZSB0aGUgb3BlcmFuZHMgaGF2ZSBubyBwb3NzaWJpbGl0eSBvZiBhIE5BTiwg d2Ugd2lsbAptaXN0YWtlbmx5IGFzc3VtZSB0aGUgcmVzdWx0IGNhbm5vdCBoYXZlIGEgTkFOLiAg VGhpcyBmaXhlcyB0aGUKb3ZlcnNpZ2h0LgoKZ2NjL0NoYW5nZUxvZzoKCgkqIHJhbmdlLW9wLWZs b2F0LmNjIChmb3BlcmF0b3JfcGx1czo6Zm9sZF9yYW5nZSk6IFNldCBOQU4gZm9yCglhZGRpdGlv biBvZiBkaWZmZXJlbnQgc2lnbmVkIGluZmluaXRpZXMuCgkocmFuZ2Vfb3BfZmxvYXRfdGVzdHMp OiBOZXcgdGVzdC4KLS0tCiBnY2MvcmFuZ2Utb3AtZmxvYXQuY2MgfCAyNiArKysrKysrKysrKysr KysrKysrKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9nY2MvcmFuZ2Utb3AtZmxvYXQuY2MgYi9nY2MvcmFuZ2Utb3At ZmxvYXQuY2MKaW5kZXggM2JjNmNjODg0OWQuLjgyODJjOTEyZmM0IDEwMDY0NAotLS0gYS9nY2Mv cmFuZ2Utb3AtZmxvYXQuY2MKKysrIGIvZ2NjL3JhbmdlLW9wLWZsb2F0LmNjCkBAIC0xODYzLDcg KzE4NjMsMjEgQEAgZm9wZXJhdG9yX3BsdXM6OmZvbGRfcmFuZ2UgKGZyYW5nZSAmciwgdHJlZSB0 eXBlLAogCiAgIHIuc2V0ICh0eXBlLCBsYiwgdWIpOwogCi0gIGlmIChsYl9uYW4gfHwgdWJfbmFu KQorICAvLyBTb21lIGNvbWJpbmF0aW9ucyBjYW4geWllbGQgYSBOQU4gZXZlbiBpZiBubyBvcGVy YW5kcyBoYXZlIHRoZQorICAvLyBwb3NzaWJpbGl0eSBvZiBhIE5BTi4KKyAgYm9vbCBtYXliZV9u YW47CisgIC8vIFstSU5GXSArIFsrSU5GXSA9IE5BTgorICBpZiAocmVhbF9pc2luZiAoJm9wMS5s b3dlcl9ib3VuZCAoKSwgdHJ1ZSkKKyAgICAgICYmIHJlYWxfaXNpbmYgKCZvcDIudXBwZXJfYm91 bmQgKCksIGZhbHNlKSkKKyAgICBtYXliZV9uYW4gPSB0cnVlOworICAvLyBbK0lORl0gKyBbLUlO Rl0gPSBOQU4KKyAgZWxzZSBpZiAocmVhbF9pc2luZiAoJm9wMS51cHBlcl9ib3VuZCAoKSwgZmFs c2UpCisJICAgJiYgcmVhbF9pc2luZiAoJm9wMi5sb3dlcl9ib3VuZCAoKSwgdHJ1ZSkpCisgICAg bWF5YmVfbmFuID0gdHJ1ZTsKKyAgZWxzZQorICAgIG1heWJlX25hbiA9IGZhbHNlOworCisgIGlm IChsYl9uYW4gfHwgdWJfbmFuIHx8IG1heWJlX25hbikKICAgICAvLyBLZWVwIHRoZSBkZWZhdWx0 IE5BTiAod2l0aCBhIHZhcnlpbmcgc2lnbikgc2V0IGJ5IHRoZSBzZXR0ZXIuCiAgICAgOwogICBl bHNlIGlmICghb3AxLm1heWJlX2lzbmFuICgpICYmICFvcDIubWF5YmVfaXNuYW4gKCkpCkBAIC0x OTYwLDYgKzE5NzQsMTYgQEAgcmFuZ2Vfb3BfZmxvYXRfdGVzdHMgKCkKICAgcjEgPSBmcmFuZ2Vf ZmxvYXQgKCItMSIsICItMCIpOwogICByMS51cGRhdGVfbmFuIChmYWxzZSk7CiAgIEFTU0VSVF9F USAociwgcjEpOworCisgIC8vIFstSU5GLCtJTkZdICsgWy1JTkYsK0lORl0gY291bGQgYmUgYSBO QU4uCisgIHJhbmdlX29wX2hhbmRsZXIgcGx1cyAoUExVU19FWFBSLCBmbG9hdF90eXBlX25vZGUp OworICByMC5zZXRfdmFyeWluZyAoZmxvYXRfdHlwZV9ub2RlKTsKKyAgcjEuc2V0X3Zhcnlpbmcg KGZsb2F0X3R5cGVfbm9kZSk7CisgIHIwLmNsZWFyX25hbiAoKTsKKyAgcjEuY2xlYXJfbmFuICgp OworICBwbHVzLmZvbGRfcmFuZ2UgKHIsIGZsb2F0X3R5cGVfbm9kZSwgcjAsIHIxKTsKKyAgaWYg KEhPTk9SX05BTlMgKGZsb2F0X3R5cGVfbm9kZSkpCisgICAgQVNTRVJUX1RSVUUgKHIubWF5YmVf aXNuYW4gKCkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBzZWxmdGVzdAotLSAKMi4zOC4xCgo= --0000000000007df09d05ed0433f8--