From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8834E3856DE4 for ; Tue, 2 Aug 2022 11:54:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8834E3856DE4 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-385-4fiH_tAVMGSQlORT5CdM3A-1; Tue, 02 Aug 2022 07:54:24 -0400 X-MC-Unique: 4fiH_tAVMGSQlORT5CdM3A-1 Received: by mail-oo1-f70.google.com with SMTP id y1-20020a4a2d01000000b00440ac492c43so899070ooy.21 for ; Tue, 02 Aug 2022 04:54:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=9qA597/57DQZ5C+s6Ry36EuuWV4adxDWi2MdVo04PkM=; b=Gj8p4ctLinqoaX9Ak96mr4SSTHqrxmj866df9YZREnAhK/2xvqlbvSmnciZrtsmTuB M/A+90YmjgUd3tDSOInSXiBb1S8Mv++9gNwbXxSSfDea+hBO67HiTkyRtUE5gy/ltZE2 isOfFdJcSrsJmVl+IFqfC7WhnUGHAdcNmCL49fT9Nkvcl+PWmmRBqBqg2OnLfv90pdX8 G8bOp5LwTu8N1rsTvKiOxchxcJBLKaHCmB8HVSrMmd9jU7ygoI5/uyqqkEfzie3lMNGu rvCKoLmNAT1dpoUMEW8JHPyUs2mMO97HTNTkbWunZ2MEKwVRzGGqZuPOq+fjcMT030+y lsow== X-Gm-Message-State: AJIora+SOzEOSIftTIVqJt5I/mihoKA+mg1MHYaVhD5oj/Hoju7fppnd Sa5h6nFZicKirTWayXppu+68VQZjJ3UIfi82d2lslTnIdlfXx5GkTaO4G5wX3+ILms2gsIup7xa FM76O67d4BLGOxwjP+hMpsP1ql3NQtjGulg== X-Received: by 2002:a05:6808:1a23:b0:33a:7888:9c3b with SMTP id bk35-20020a0568081a2300b0033a78889c3bmr8440905oib.265.1659441263225; Tue, 02 Aug 2022 04:54:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1viZBZZ1fKBgTVpIU7kM4ix7eGsdxtq4d6DUQlZJX2R9VpHwm0V7tezQ5HSkb6rJx6Ii2LGTWpw3Ptn2/FXSp0= X-Received: by 2002:a05:6808:1a23:b0:33a:7888:9c3b with SMTP id bk35-20020a0568081a2300b0033a78889c3bmr8440894oib.265.1659441262997; Tue, 02 Aug 2022 04:54:22 -0700 (PDT) MIME-Version: 1.0 References: <04261.122080204410800126@us-mta-529.us.mimecast.lan> In-Reply-To: From: Aldy Hernandez Date: Tue, 2 Aug 2022 13:54:12 +0200 Message-ID: Subject: Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader To: Richard Biener Cc: gcc-patches , "MacLeod, Andrew" , Jeff Law X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2022 11:54:29 -0000 On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > Unfortunately, this was before my time, so I don't know. > > > > That being said, thanks for tackling these issues that my work > > triggered last release. Much appreciated. > > Ah. But it was your r12-324-g69e5544210e3c0 that did > > - else if (n_insns > 1) > + else if (!m_speed_p && n_insns > 1) > > causing the breakage on the 12 branch. That leads to a simpler > fix I guess. Will re-test and also backport to GCC 12 if successful. Huh. It's been a while, but that looks like a typo. That patch was supposed to be non-behavior changing. Aldy