From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1E16C3858C54 for ; Mon, 7 Nov 2022 12:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E16C3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667825323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yDkYlvkNdlYNiLS8NPcFI5wqEEosruRSvvmlXlxgiWM=; b=Z9dptSUeecfzczdpQQZBbOLzz7B1pLqfIuEruqR2IUmuDZugzJV1L4x5PNsRkAHPDat04F dLd+3EyM+GIx1q4FUzMfg44irI2XTAZ87Fqr956EcGapFotjwKq61qwOxYUIWKA4xg3Qx6 jRyb/fNP9VvnQAxwHlxeSM3zM6EIqng= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-615-8I28YdB6OumNbnrxl_6L2A-1; Mon, 07 Nov 2022 07:48:40 -0500 X-MC-Unique: 8I28YdB6OumNbnrxl_6L2A-1 Received: by mail-ua1-f70.google.com with SMTP id a11-20020ab0494b000000b0041123ae77cdso5128628uad.1 for ; Mon, 07 Nov 2022 04:48:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yDkYlvkNdlYNiLS8NPcFI5wqEEosruRSvvmlXlxgiWM=; b=pBt2jSqdmb8RUkek2wGfF6R0Ih1EieOx8hcBTah/s0SwBZfhidKbBAA/Ww4A9YgjE9 357bfFclbkKB3Q99CmNxrPxxwt1F1M7iTHdUcfokm2cZkTyNxZzuoQrd/rcsev925SoW /pWzJzZgqNgJG3qwOFsLz7fq2EbQIlFHfYFCE5TlALdUg7TVf5+xFjxOVAOdQ4/SytrD mhSVAZX8zyYrYNj3S3FnHt5r2m1maxtv+kbIPO74CIfTKJUYIu2gDenThAGLclFEzfBY 4AFUiT3IH9cX5oSMJbYQ7JjuOmc0QDZzCPfm1lHaAqIIK/HW14po4hjK9M/9jzQP+l33 DLJg== X-Gm-Message-State: ACrzQf0u52RkvTDox7C2mbf29o+4UDvnWOLThcQkeTaGH71qF+rRRf0n hyBeoWbFX7CztW0eLSreYTsAZoUWIAzyqdMpFNqHcpX2Qc7Y3I8WFNhur9DSMsSce8uwJpU+fP6 275FZMOsxEPlWVUS5EJyEsDQYaD7yKbslWw== X-Received: by 2002:a67:a247:0:b0:3ad:847a:a43c with SMTP id t7-20020a67a247000000b003ad847aa43cmr9147160vsh.2.1667825320114; Mon, 07 Nov 2022 04:48:40 -0800 (PST) X-Google-Smtp-Source: AMsMyM53KtYuYvGxdX/ApvK/b+UNtzchZ5er0sZeEpALAWBn0COiwCVBru+U2EADOWQR7PtRJqu2gBXzqu5RzPb1yOg= X-Received: by 2002:a67:a247:0:b0:3ad:847a:a43c with SMTP id t7-20020a67a247000000b003ad847aa43cmr9147154vsh.2.1667825319901; Mon, 07 Nov 2022 04:48:39 -0800 (PST) MIME-Version: 1.0 References: <20221013123649.474497-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Mon, 7 Nov 2022 13:48:28 +0100 Message-ID: Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. To: Jakub Jelinek Cc: "MacLeod, Andrew" , GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 7, 2022 at 1:43 PM Jakub Jelinek wrote: > > On Mon, Nov 07, 2022 at 01:35:35PM +0100, Aldy Hernandez wrote: > > Let me see if I understand you correctly... > > > > real_isdenormal is always returning false for our uses in frange? So > > instead of using real_isdenormal in flush_denormals_to_zero, perhaps > > we should be using: > > > > REAL_EXP (r) < REAL_MODE_FORMAT (mode)->emin > > > > ?? > > > > Could we perhaps make real_isdenormal always work for all values? Is > > that possible? > > Yes. Or have real_isdenormal_target for the uses in real.cc > which would be private to real.cc and would do what real_isdenormal > currently does, and then real_isdenormal with the above definition > (well, r->cl == rvc_normal && ...). If the REAL_EXP(r)... definition works for everyone, can't we just use that? Or do you think there'd be a measurable performance impact? Aldy