From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 817C738582B2 for ; Thu, 22 Sep 2022 15:02:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 817C738582B2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663858953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=Mt5ZJibgjV4S4zcPAxLjcnITUyAN53QyS+X6De4hasE=; b=P7uf09UYqq2CNbePiR/LZpfF9gMBvEDyosxcyqhf10i75FBLfRWSvClNbaWeqyWTZ/uWbW wylVpZzkZOuBmdnUtPC0kdPk9u4hZyZCGm2DAUxBE5yoscltM6/1Z8Y5kxoEhd8kq9YzTF asx1qrYFUyaqCP3+d3jNmAoiIrjt1VY= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-584-hG8Fli_OM5CjyczSCSj5LA-1; Thu, 22 Sep 2022 11:02:31 -0400 X-MC-Unique: hG8Fli_OM5CjyczSCSj5LA-1 Received: by mail-oi1-f198.google.com with SMTP id bl2-20020a056808308200b0035028763f44so4694540oib.19 for ; Thu, 22 Sep 2022 08:02:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=Mt5ZJibgjV4S4zcPAxLjcnITUyAN53QyS+X6De4hasE=; b=U3FVVrfH4bpeQwYBSUpsyB109d3W5etSmUy5MioQi26vSEExUlcpgOeE859O9wnxxI FETcKH/EvTzrasSq5lH6iOnx9AI6GGTf22mNsad6h8xEPZbhRPdywDhDK1nld8nMao2w q1YGRw2MXX0dyagGZNCqtZ14NqJDBVlJuiD12//XBcSUU7Ogm0FqN+uq8aWL4AWk1RFZ JXN06FdXWmmuWr6JvkZw2E3GFfNXtoiOKSaY5YMuBCh4E1+jtoyTmmRlgHPWCGhQ7icB a/Fl7Z8/ZLu5HVqyY+XHAPsBc4Yt+GUGl/tSKP69HLdjwKYc88EMLZk7RW65LBl/O1eq r2Nw== X-Gm-Message-State: ACrzQf2w8xUwclHJBGGHgTrMSziS4iFU9ECKsyNIqHmTzftsKlHHggT2 pCGk2pFP4MGWQRoCTBvvZb0fbXlGPilQRjc3veJzNzdWsqMYLgDmwgic3+qUY3E2BRNvtSoOm11 DAjDtGj6YM2j9ODC47gs9TVafjL1n1TN6Yg== X-Received: by 2002:a05:6870:160c:b0:12b:9663:67ca with SMTP id b12-20020a056870160c00b0012b966367camr8499606oae.36.1663858950720; Thu, 22 Sep 2022 08:02:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4N50qRjiIAc01uiz4X0Qp5u2DAlO0oLpODjm8BA5PzReSbLZpIq7lQovubt61Egz7j8t2Fdzk4zS8JTCBsJlI= X-Received: by 2002:a05:6870:160c:b0:12b:9663:67ca with SMTP id b12-20020a056870160c00b0012b966367camr8499568oae.36.1663858950310; Thu, 22 Sep 2022 08:02:30 -0700 (PDT) MIME-Version: 1.0 From: Aldy Hernandez Date: Thu, 22 Sep 2022 17:02:19 +0200 Message-ID: Subject: TYPE_{MIN/MAX}_VALUE for floats? To: Richard Biener , Jakub Jelinek , gcc-patches , "MacLeod, Andrew" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000b0c69e05e945598e" X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b0c69e05e945598e Content-Type: text/plain; charset="UTF-8" It has always irritated me that we don't have TYPE_MIN_VALUE and TYPE_MAX_VALUE for floats (and for pointers for that matter). This means, we have to recalculate it ad-nauseum in vrp_val_min and vrp_val_max. I know we have dconstinf and dconstninf for floats, which we can just wrap around a TREE_REAL_CST, but it still seems like we should be more consistent here. If we know the endpoint for a type, we should cache it in it. Furthermore, just the way we're chopping off NANs in the frange::set() routine, we should be able to chop off things outside the min/max representable range, at least for -ffinite-math-only. For example, the endpoints to VR_VARYING for a float in -ffinite-math-only should be real_{min/max}_representable(), which REAL_VALUE_TYPE already provides. I am testing a patch to do this, but am unhappy that we have recalculate things. Is there a reason we can't store these in the type? I tried the naive attached approach, but I quickly ran into LTO woes: FAIL: gcc.c-torture/execute/ieee/20001122-1.c compilation, -O2 -flto -fno-use-linker-plugin -flto-partition=none (internal compiler error: 'verify_type' failed) $ ./xgcc -B./ a.c -O2 -flto -w lto1: error: type variant differs by TYPE_MAX_VALUE So I clearly don't know what I'm doing. Would folks be ok with filling TYPE_MIN_VALUE and friends for floats, and if so, could someone give me a hand here? What am I missing? Thanks. Aldy p.s. Now that we're onto this subject, in the distant future, I'd actually like to store a vrange in the tree type. I mean, they are first class citizens in the SSA name now, and we have a typeless way of storing ranges in GC space. Anywho, that's for the future, cause I like the pain... just wanted to gauge the temperature on that one as well. --000000000000b0c69e05e945598e Content-Type: text/x-patch; charset="US-ASCII"; name="float-endpoints.patch" Content-Disposition: attachment; filename="float-endpoints.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8d6dpw20 ZGlmZiAtLWdpdCBhL2djYy9zdG9yLWxheW91dC5jYyBiL2djYy9zdG9yLWxheW91dC5jYwppbmRl eCA4ODkyM2M0MTM2Yi4uOThmMjY4ZDlmNWEgMTAwNjQ0Ci0tLSBhL2djYy9zdG9yLWxheW91dC5j YworKysgYi9nY2Mvc3Rvci1sYXlvdXQuY2MKQEAgLTQzLDYgKzQzLDcgQEAgYWxvbmcgd2l0aCBH Q0M7IHNlZSB0aGUgZmlsZSBDT1BZSU5HMy4gIElmIG5vdCBzZWUKICNpbmNsdWRlICJhdHRyaWJz LmgiCiAjaW5jbHVkZSAiZGVidWcuaCIKICNpbmNsdWRlICJjYWxscy5oIgorI2luY2x1ZGUgInJl YWwuaCIKIAogLyogRGF0YSB0eXBlIGZvciB0aGUgZXhwcmVzc2lvbnMgcmVwcmVzZW50aW5nIHNp emVzIG9mIGRhdGEgdHlwZXMuCiAgICBJdCBpcyB0aGUgZmlyc3QgaW50ZWdlciB0eXBlIGxhaWQg b3V0LiAgKi8KZGlmZiAtLWdpdCBhL2djYy90cmVlLmNjIGIvZ2NjL3RyZWUuY2MKaW5kZXggNDE2 NWNiZDdjM2IuLjdhMWZjNmM0ODg4IDEwMDY0NAotLS0gYS9nY2MvdHJlZS5jYworKysgYi9nY2Mv dHJlZS5jYwpAQCAtNzYyMCw2ICs3NjIwLDMxIEBAIGJ1aWxkX29mZnNldF90eXBlICh0cmVlIGJh c2V0eXBlLCB0cmVlIHR5cGUpCiAgIHJldHVybiB0OwogfQogCisvKiBDcmVhdGUgYSBmbG9hdGlu ZyBwb2ludCB0eXBlIHdpdGggUFJFQ0lTSU9OLiAgKi8KKwordHJlZQorYnVpbGRfZmxvYXRfdHlw ZSAodW5zaWduZWQgcHJlY2lzaW9uKQoreworICB0cmVlIHR5cGUgPSBtYWtlX25vZGUgKFJFQUxf VFlQRSk7CisgIFRZUEVfUFJFQ0lTSU9OICh0eXBlKSA9IHByZWNpc2lvbjsKKyAgbGF5b3V0X3R5 cGUgKHR5cGUpOworCisgIGlmIChmbGFnX2Zpbml0ZV9tYXRoX29ubHkpCisgICAgeworICAgICAg UkVBTF9WQUxVRV9UWVBFIG1pbiwgbWF4OworICAgICAgcmVhbF9taW5fcmVwcmVzZW50YWJsZSAo Jm1pbiwgdHlwZSk7CisgICAgICByZWFsX21heF9yZXByZXNlbnRhYmxlICgmbWF4LCB0eXBlKTsK KyAgICAgIFRZUEVfTUlOX1ZBTFVFICh0eXBlKSA9IGJ1aWxkX3JlYWwgKHR5cGUsIG1pbik7Cisg ICAgICBUWVBFX01BWF9WQUxVRSAodHlwZSkgPSBidWlsZF9yZWFsICh0eXBlLCBtYXgpOworICAg IH0KKyAgZWxzZQorICAgIHsKKyAgICAgIFRZUEVfTUlOX1ZBTFVFICh0eXBlKSA9IGJ1aWxkX3Jl YWwgKHR5cGUsIGRjb25zdG5pbmYpOworICAgICAgVFlQRV9NQVhfVkFMVUUgKHR5cGUpID0gYnVp bGRfcmVhbCAodHlwZSwgZGNvbnN0aW5mKTsKKyAgICB9CisgIHJldHVybiB0eXBlOworfQorCiAv KiBDcmVhdGUgYSBjb21wbGV4IHR5cGUgd2hvc2UgY29tcG9uZW50cyBhcmUgQ09NUE9ORU5UX1RZ UEUuCiAKICAgIElmIE5BTUVEIGlzIHRydWUsIHRoZSB0eXBlIGlzIGdpdmVuIGEgVFlQRV9OQU1F LiAgV2UgZG8gbm90IGFsd2F5cwpAQCAtOTQyNywxNyArOTQ1Miw5IEBAIGJ1aWxkX2NvbW1vbl90 cmVlX25vZGVzIChib29sIHNpZ25lZF9jaGFyKQogCiAgIHBvaW50ZXJfc2l6ZWRfaW50X25vZGUg PSBidWlsZF9ub25zdGFuZGFyZF9pbnRlZ2VyX3R5cGUgKFBPSU5URVJfU0laRSwgMSk7CiAKLSAg ZmxvYXRfdHlwZV9ub2RlID0gbWFrZV9ub2RlIChSRUFMX1RZUEUpOwotICBUWVBFX1BSRUNJU0lP TiAoZmxvYXRfdHlwZV9ub2RlKSA9IEZMT0FUX1RZUEVfU0laRTsKLSAgbGF5b3V0X3R5cGUgKGZs b2F0X3R5cGVfbm9kZSk7Ci0KLSAgZG91YmxlX3R5cGVfbm9kZSA9IG1ha2Vfbm9kZSAoUkVBTF9U WVBFKTsKLSAgVFlQRV9QUkVDSVNJT04gKGRvdWJsZV90eXBlX25vZGUpID0gRE9VQkxFX1RZUEVf U0laRTsKLSAgbGF5b3V0X3R5cGUgKGRvdWJsZV90eXBlX25vZGUpOwotCi0gIGxvbmdfZG91Ymxl X3R5cGVfbm9kZSA9IG1ha2Vfbm9kZSAoUkVBTF9UWVBFKTsKLSAgVFlQRV9QUkVDSVNJT04gKGxv bmdfZG91YmxlX3R5cGVfbm9kZSkgPSBMT05HX0RPVUJMRV9UWVBFX1NJWkU7Ci0gIGxheW91dF90 eXBlIChsb25nX2RvdWJsZV90eXBlX25vZGUpOworICBmbG9hdF90eXBlX25vZGUgPSBidWlsZF9m bG9hdF90eXBlIChGTE9BVF9UWVBFX1NJWkUpOworICBkb3VibGVfdHlwZV9ub2RlID0gYnVpbGRf ZmxvYXRfdHlwZSAoRE9VQkxFX1RZUEVfU0laRSk7CisgIGxvbmdfZG91YmxlX3R5cGVfbm9kZSA9 IGJ1aWxkX2Zsb2F0X3R5cGUgKExPTkdfRE9VQkxFX1RZUEVfU0laRSk7CiAKICAgZm9yIChpID0g MDsgaSA8IE5VTV9GTE9BVE5fTlhfVFlQRVM7IGkrKykKICAgICB7CmRpZmYgLS1naXQgYS9nY2Mv dHJlZS5oIGIvZ2NjL3RyZWUuaAppbmRleCAyNjZlMjRhMDU2My4uYjgzZmFjMTdmMWEgMTAwNjQ0 Ci0tLSBhL2djYy90cmVlLmgKKysrIGIvZ2NjL3RyZWUuaApAQCAtNDcyOSw2ICs0NzI5LDcgQEAg ZXh0ZXJuIHRyZWUgYnVpbGRfdmFyYXJnc19mdW5jdGlvbl90eXBlX2FycmF5ICh0cmVlLCBpbnQs IHRyZWUgKik7CiBleHRlcm4gdHJlZSBidWlsZF9tZXRob2RfdHlwZV9kaXJlY3RseSAodHJlZSwg dHJlZSwgdHJlZSk7CiBleHRlcm4gdHJlZSBidWlsZF9tZXRob2RfdHlwZSAodHJlZSwgdHJlZSk7 CiBleHRlcm4gdHJlZSBidWlsZF9vZmZzZXRfdHlwZSAodHJlZSwgdHJlZSk7CitleHRlcm4gdHJl ZSBidWlsZF9mbG9hdF90eXBlICh1bnNpZ25lZCk7CiBleHRlcm4gdHJlZSBidWlsZF9jb21wbGV4 X3R5cGUgKHRyZWUsIGJvb2wgbmFtZWQgPSBmYWxzZSk7CiBleHRlcm4gdHJlZSBhcnJheV90eXBl X25lbHRzIChjb25zdF90cmVlKTsKIAo= --000000000000b0c69e05e945598e--