From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8C12E3858D33 for ; Mon, 26 Jun 2023 09:23:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C12E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687771421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eUbiyhbM+It/2WM/hUq6pcMZV+7sHe+7df756+g+kUw=; b=ewxvBF5odnalz2G5ROb2RgL02r1SeY+BpoxOSJlobYBQr+/jFHKG3nSQVt/HAWQWdcKedE 9t+rcpDLl/ZcX2V8T8L8HRNslQ9EnKGPC5BFBEZKk6QoldhBlDCJs36ZjdRLyy2yoyJ0Qw 6aLg0EkloPmNKboxXQ78QqpJ7Nuv4xE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-nNDSDEjLMJu6RtpFd4P1rw-1; Mon, 26 Jun 2023 05:23:36 -0400 X-MC-Unique: nNDSDEjLMJu6RtpFd4P1rw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fa7b245a75so13463025e9.0 for ; Mon, 26 Jun 2023 02:23:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687771415; x=1690363415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eUbiyhbM+It/2WM/hUq6pcMZV+7sHe+7df756+g+kUw=; b=C4yMw6m6/QEOFwH8EEN4u64ABLoRDP7Di2CNEfk5Irhi6erRcaOLDdlU0u4prvSgJP Ys/T6/jpSvLmYJguKxY7hZdLVHvI/hzGM3dHq7plgLicLm2dD27dBawi6LVgLfNv2Bg2 Ffe+DwtBOSzWOHpkkn6cEO+hUnvtjtY1Nmd6+sxYWMWlg7bj9CdBRS0lLxAAdC0GE7Mf aWiroN83YEHLWgMinDlzbmRA3YXHdAMduEqUMqe93CaU4XZ5GvXfdeLpJDecKSehj4/Y uHylxhT1VeSDjc3li/a4t+2Y1HshHFQnwbclA/rTldLbgY/PJTjJW7jTJjacz80e7llC 8rmQ== X-Gm-Message-State: AC+VfDyOD2FEmp3bSyh3wfNNaeC+GL4V31d7MQjygddx6t64KwnHzMH8 Nj9zPixJa3+acnzWEQjs3ew3WsFQgxb3lA21V/HOJcDjhDVn7vmR/VACxwBjADx1k3FVftbKhU+ ylTzLxNYCY9L8y3fwE3YpaT2ZCT79Ji5UOA== X-Received: by 2002:a05:600c:4309:b0:3fa:8522:283 with SMTP id p9-20020a05600c430900b003fa85220283mr5324530wme.13.1687771415655; Mon, 26 Jun 2023 02:23:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5gNL6Ri1p2FeOC7rQWYvDH2eEvszZOfstFinbw2Dd337NoHfU5npbo6wIm/vx1blR7ZXIsYfz2tDZFphjKm8A= X-Received: by 2002:a05:600c:4309:b0:3fa:8522:283 with SMTP id p9-20020a05600c430900b003fa85220283mr5324520wme.13.1687771415421; Mon, 26 Jun 2023 02:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20230522185622.537454-1-aldyh@redhat.com> <20230522185622.537454-2-aldyh@redhat.com> <3feb043e-bae6-513d-247b-ed0c23d0d21a@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Mon, 26 Jun 2023 11:23:24 +0200 Message-ID: Subject: Re: [PATCH] Implement ipa_vr hashing. To: Martin Jambor , GCC patches Cc: Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Errr, sorry about this ping. I was meant to re-ping my IPA patches after 7 days, but just realized it had been only 4. My bad. Aldy On Mon, Jun 26, 2023 at 11:22=E2=80=AFAM Aldy Hernandez = wrote: > > PING*3 > > On Thu, Jun 22, 2023 at 7:49=E2=80=AFAM Aldy Hernandez = wrote: > > > > Ping*2 > > > > On Wed, Jun 14, 2023, 14:11 Aldy Hernandez wrote: > >> > >> PING > >> > >> On Sat, Jun 10, 2023 at 10:30=E2=80=AFPM Aldy Hernandez wrote: > >> > > >> > > >> > > >> > On 5/29/23 16:51, Martin Jambor wrote: > >> > > Hi, > >> > > > >> > > On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote: > >> > >> Implement hashing for ipa_vr. When all is said and done, all the= se > >> > >> patches incurr a 7.64% slowdown for ipa-cp, with is entirely cove= red by > >> > >> the similar 7% increase in this area last week. So we get type a= gnostic > >> > >> ranges with "infinite" range precision close to free. > >> > > > >> > > Do you know why/where this slow-down happens? Do we perhaps want = to > >> > > limit the "infiniteness" a little somehow? > >> > > >> > I addressed the slow down in another mail. > >> > > >> > > > >> > > Also, jump functions live for a long time, have you looked at how = memory > >> > > hungry they become? I hope that the hashing would be good at prev= enting > >> > > any issues. > >> > > >> > On a side-note, the caching does help. On a (mistaken) hunch, I had > >> > played around with removing caching for everything but UNDEFINED/VAR= YING > >> > and zero/nonzero to simplify things, but the cache hit ratio was sti= ll > >> > surprisingly high (+80%). So good job there :-). > >> > > >> > > > >> > > Generally, I think I OK with the patches if the impact on memory i= s not > >> > > too bad, though I guess they depend on the one I looked at last we= ek, so > >> > > we may focus on that one first. > >> > > >> > I'm not sure whether this was an OK for the other patches, given you > >> > approved the first patch, so I'll hold off until you give the go-ahe= ad. > >> > > >> > Thanks. > >> > Aldy