From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EDDC03857340 for ; Tue, 25 Jul 2023 06:32:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDDC03857340 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690266742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y6opFtbn87lDdzKrBZqjjuF+By+oIJZVA7+TusRemRc=; b=f+jsX6oXa7zIxFc3t5CSqEnkxnyjjHNQOOGDxOIHYs6Mfl9kz/3VcfrbGsriYaS5to03C9 fQMW+Rpe772YI5ZvB0yRkCvLxgL4c1FypU8OMIVS+G4J33Akrxf/+AnQRUw4eP0j+880zR /SBwWlIeF/oIKZHY0wTdYDI6dQB10W0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Egke_bTGNY2u3jr2ZWn9cQ-1; Tue, 25 Jul 2023 02:32:20 -0400 X-MC-Unique: Egke_bTGNY2u3jr2ZWn9cQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-993831c639aso349957766b.2 for ; Mon, 24 Jul 2023 23:32:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690266739; x=1690871539; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y6opFtbn87lDdzKrBZqjjuF+By+oIJZVA7+TusRemRc=; b=dngdammmAliJ8H8bVDPHxc/7UI+TBSuKAk6fn8jQZj6zYwXr9FUUtSdHiJzBQI27gl xF9NVxhPWnIiTgLpoCAUeRiR9TEhvlLWInjPqoLbQRuv/HLCEDDGXJ7KYFbx1VP0VeF3 tRWwmejhdRYsdN1ttliEf59dmt3iYUs6QgkKhOxXluFfqixPZMIxJVf7woLGL8iEOIYO xigbkNEtj10fdH30yf/XzB0HyOVNQrJ3xK/PirJFHckRuaQtjtz2Gzd9t1hwD9Chsglj YAglbu1R+GfzNhp6KcOFnYH0Pcq7s4xfW+GVViWyVqAir31UlSZY0yEPyVMQHXc/BYNM dG0Q== X-Gm-Message-State: ABy/qLaGXWwmwsqbD43pMZnsHK7kOk7hfYAqkvME2CPt6+XQ1+OO0eIx tdEUOz2NN8wSokbBjkO+MtLbzWmBmpMyrxehMrKxs8631XqF+vcws5k/W0hVaK/79SGuElmsUl1 SYlRsH8xJ5u2MONoNG8tkCwCAlUtUXqzKHcgCUqXaPw== X-Received: by 2002:a17:906:189:b0:991:f207:411e with SMTP id 9-20020a170906018900b00991f207411emr10815040ejb.69.1690266739396; Mon, 24 Jul 2023 23:32:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlG1NLPRFLVc3rxzEGskaJtnAll7cQkBP/mltFOXEm78D+58XX99Ibut0qbZJQpYD/vkzl1prDVp17zYPFit2jE= X-Received: by 2002:a17:906:189:b0:991:f207:411e with SMTP id 9-20020a170906018900b00991f207411emr10815008ejb.69.1690266738488; Mon, 24 Jul 2023 23:32:18 -0700 (PDT) MIME-Version: 1.0 References: <20230717131411.330650-1-aldyh@redhat.com> In-Reply-To: <20230717131411.330650-1-aldyh@redhat.com> From: Aldy Hernandez Date: Tue, 25 Jul 2023 08:32:06 +0200 Message-ID: Subject: Re: [PATCH] Read global value/mask in IPA. To: GCC patches Cc: Andrew MacLeod , Martin Jambor X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000860eca060149e493" X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000860eca060149e493 Content-Type: text/plain; charset="UTF-8" Ping On Mon, Jul 17, 2023, 15:14 Aldy Hernandez wrote: > Instead of reading the known zero bits in IPA, read the value/mask > pair which is available. > > There is a slight change of behavior here. I have removed the check > for SSA_NAME, as the ranger can calculate the range and value/mask for > INTEGER_CST. This simplifies the code a bit, since there's no special > casing when setting the jfunc bits. The default range for VR is > undefined, so I think it's safe just to check for undefined_p(). > > OK? > > gcc/ChangeLog: > > * ipa-prop.cc (ipa_compute_jump_functions_for_edge): Read global > value/mask. > --- > gcc/ipa-prop.cc | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/gcc/ipa-prop.cc b/gcc/ipa-prop.cc > index 5d790ff1265..4f6ed7b89bd 100644 > --- a/gcc/ipa-prop.cc > +++ b/gcc/ipa-prop.cc > @@ -2402,8 +2402,7 @@ ipa_compute_jump_functions_for_edge (struct > ipa_func_body_info *fbi, > } > else > { > - if (TREE_CODE (arg) == SSA_NAME > - && param_type > + if (param_type > && Value_Range::supports_type_p (TREE_TYPE (arg)) > && Value_Range::supports_type_p (param_type) > && irange::supports_p (TREE_TYPE (arg)) > @@ -2422,15 +2421,14 @@ ipa_compute_jump_functions_for_edge (struct > ipa_func_body_info *fbi, > gcc_assert (!jfunc->m_vr); > } > > - if (INTEGRAL_TYPE_P (TREE_TYPE (arg)) > - && (TREE_CODE (arg) == SSA_NAME || TREE_CODE (arg) == > INTEGER_CST)) > + if (INTEGRAL_TYPE_P (TREE_TYPE (arg)) && !vr.undefined_p ()) > { > - if (TREE_CODE (arg) == SSA_NAME) > - ipa_set_jfunc_bits (jfunc, 0, > - widest_int::from (get_nonzero_bits (arg), > - TYPE_SIGN (TREE_TYPE > (arg)))); > - else > - ipa_set_jfunc_bits (jfunc, wi::to_widest (arg), 0); > + irange &r = as_a (vr); > + irange_bitmask bm = r.get_bitmask (); > + signop sign = TYPE_SIGN (TREE_TYPE (arg)); > + ipa_set_jfunc_bits (jfunc, > + widest_int::from (bm.value (), sign), > + widest_int::from (bm.mask (), sign)); > } > else if (POINTER_TYPE_P (TREE_TYPE (arg))) > { > -- > 2.40.1 > > --000000000000860eca060149e493--