From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 678783858297 for ; Sun, 26 Jun 2022 15:38:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 678783858297 Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-292-M2t3eH5JMzqXObVFk2gy8Q-1; Sun, 26 Jun 2022 11:38:32 -0400 X-MC-Unique: M2t3eH5JMzqXObVFk2gy8Q-1 Received: by mail-oi1-f199.google.com with SMTP id l184-20020aca3ec1000000b0032f091d1761so4864562oia.6 for ; Sun, 26 Jun 2022 08:38:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jAG6CLqXhC9agge/EY2M9OEI+qOoYYPzdNa2WVSOc+4=; b=E781+SC8RDQOc/zuiM16Wq1X3rY3FxJb6iqDQMShA8xgKUf4Xv12RxwQz6Qnw5fI+3 sPfez1+sfSOdR1EijQDM/sNKDXS7jOul5ttC449qQ1HGda2+rnAq0nww7PKJpxWXnfph vR9OCod9fk51AQEyLp7yVVmHrKQ2cwSvDzNV041Q+uvTMoFJQAZN9Zcqr9g+MMDC30tq BgHa5jfap5NshphQBMtvBII4HTiZJZwl4v1nRBZHFdgddIRD7ZapEPabcSoHQOzJKzVI y3yE7ZM/DpFSuHUN52yIg6DPHvyfUkdmlb2CENC7d35iEkgLWyNxPFhgmV4H/+YqxTV6 HyFw== X-Gm-Message-State: AJIora+5ytrhXRLJ7rX6ZUF1QO/ElR7vWhvM2gH+8SKGn45IGogWarNi GCtHfGlIk9cXciB+oYc1O+8VL6jgaE1JkrwuMgXvUVV1p1JkQXY4yllNhzKcB9WLeeOabqRVlOH g0gczIqQ/8/PVBre9XgcnNWlObfRPhf7qwA== X-Received: by 2002:a05:6808:1a26:b0:335:63ee:7c32 with SMTP id bk38-20020a0568081a2600b0033563ee7c32mr2101750oib.36.1656257911522; Sun, 26 Jun 2022 08:38:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vusHSnmyvpiYdibMMSbkZKQ28PTG89JAK8sty6NPy0Owt/jRMXBnR58qiTq9WQ7Q/SeilHw9GUDe/7yhTQRjQ= X-Received: by 2002:a05:6808:1a26:b0:335:63ee:7c32 with SMTP id bk38-20020a0568081a2600b0033563ee7c32mr2101737oib.36.1656257911288; Sun, 26 Jun 2022 08:38:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aldy Hernandez Date: Sun, 26 Jun 2022 17:38:20 +0200 Message-ID: Subject: Re: Pushed patch to convert DOM from EVRP to Ranger To: Jeff Law , "MacLeod, Andrew" Cc: GCC Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000075fb3605e25b9863" X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2022 15:38:35 -0000 --00000000000075fb3605e25b9863 Content-Type: text/plain; charset="UTF-8" Thanks for pushing this. The patch triggered a (known) regression on g++.dg/warn/Wstringop-overflow-4.C. In the original submission I mentioned I would XFAIL it, but forgot to do so. I have pushed the attached patch. Note that since this was the last user of EVRP, I think it is now safe to remove its code, along with any options on params.def. Andrew, are you OK with removing the legacy evrp code (gimple-ssa-evrp-analyze.*, and any relevant bits)? Of course, the core VRP code would still remain, as VRP1 still uses it. Aldy On Sun, Jun 26, 2022 at 1:08 AM Jeff Law wrote: > > This is 99.99% Aldy's work. My only real contribution was twiddling one > MIPS specific test in response to a regression after adding this patch > to my tester. > > In simplest terms, this patch converts DOM to use the Ranger > infrastructure rather than the EVRP infrastructure. I'd basically > approved it before Aldy went on PTO and it's been sitting in my tester > ever since. So I figured it was time to go ahead and push it. > > Jeff --00000000000075fb3605e25b9863 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-XFAIL-a-test-in-g-.dg-warn-Wstringop-overflow-4.C.patch" Content-Disposition: attachment; filename="0001-XFAIL-a-test-in-g-.dg-warn-Wstringop-overflow-4.C.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4vh1pt20 RnJvbSA4MGFjZTkxODVkYzUzNGU0ZDZjYjE5NTA2MzAwYzRmY2FkNGJkOTE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogU3VuLCAyNiBKdW4gMjAyMiAxNzozMDoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFhGQUlM IGEgdGVzdCBpbiBnKysuZGcvd2Fybi9Xc3RyaW5nb3Atb3ZlcmZsb3ctNC5DCgpBcyBwZXIgdGhl IGV4cGxhbmF0aW9uIGluIHRoZSB0ZXN0LCBhbmQgaW4gdGhlIERPTSBjb252ZXJzaW9uIHRvCnJh bmdlciBwYXRjaCwgdGhpcyBpcyBhIGtub3duIHJlZ3Jlc3Npb24uICBJIGhhZCBtZW50aW9uZWQg SSB3b3VsZApYRkFJTCB0aGlzIHRlc3QsIGJ1dCBmb3Jnb3QgdG8gZG8gc28uICBUaGVyZSBpcyBh biBhbmFseXNpcyBpbiB0aGUKdGVzdCBpdHNlbGYgYXMgdG8gd2hhdCBpcyBnb2luZyBvbi4KClRl c3RlZCBvbiB4ODYtNjQgTGludXguCgpnY2MvdGVzdHN1aXRlL0NoYW5nZUxvZzoKCgkqIGcrKy5k Zy93YXJuL1dzdHJpbmdvcC1vdmVyZmxvdy00LkM6IFhGQUlMIGEgdGVzdC4KLS0tCiBnY2MvdGVz dHN1aXRlL2crKy5kZy93YXJuL1dzdHJpbmdvcC1vdmVyZmxvdy00LkMgfCAyICstCiAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nY2Mv dGVzdHN1aXRlL2crKy5kZy93YXJuL1dzdHJpbmdvcC1vdmVyZmxvdy00LkMgYi9nY2MvdGVzdHN1 aXRlL2crKy5kZy93YXJuL1dzdHJpbmdvcC1vdmVyZmxvdy00LkMKaW5kZXggZWI0ODAxOTE4ZmMu LmM5ZDYzOTMyOTc3IDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2crKy5kZy93YXJuL1dzdHJp bmdvcC1vdmVyZmxvdy00LkMKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvd2Fybi9Xc3RyaW5n b3Atb3ZlcmZsb3ctNC5DCkBAIC0xOTUsNyArMTk1LDcgQEAgdm9pZCB0ZXN0X3N0cmNweV9uZXdf aW50MTZfdCAoc2l6ZV90IG4sIGNvbnN0IHNpemVfdCB2YWxzW10pCiAgICAgICBpZnRtcC4yXzMz ID0gXzQ1ICogMjsJCQkJOzsgaWZ0bXAuMl8zMyA9IDAKICAgICAgIF8zNCA9IG9wZXJhdG9yIG5l dyBbXSAoaWZ0bXAuMl8zMyk7CQk7OyBuZXcgW10gKDApCiAgICovCi0gIFQgKFMgKDIpLCBuZXcg aW50MTZfdFtyX2RtaW5fZG1heCArIDFdKTsKKyAgVCAoUyAoMiksIG5ldyBpbnQxNl90W3JfZG1p bl9kbWF4ICsgMV0pOyAvLyB7IGRnLWJvZ3VzICJpbnRvIGEgcmVnaW9uIG9mIHNpemUiICIiIHsg eGZhaWwgKi0qLSp9IH0KICAgVCAoUyAoOSksIG5ldyBpbnQxNl90W3JfZG1pbl9kbWF4ICogMiAr IDFdKTsKIH0KIAotLSAKMi4zNi4xCgo= --00000000000075fb3605e25b9863--