From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A8E0C3858423 for ; Fri, 29 Oct 2021 20:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8E0C3858423 Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-7pNX2vRCNlqylgqNk0Qq5A-1; Fri, 29 Oct 2021 16:04:59 -0400 X-MC-Unique: 7pNX2vRCNlqylgqNk0Qq5A-1 Received: by mail-lj1-f198.google.com with SMTP id v13-20020a2e2f0d000000b0021126b5cca2so3553512ljv.19 for ; Fri, 29 Oct 2021 13:04:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3SHT01TumENC6/nPVtlHHV0AwreTavMK7/BpN8Ol1XY=; b=MeomKNA95hcF6+cuLwahEjCS2DI4Egb6gAoU9FAma/36HfGyuxS58a4KjoNONjU229 FKATtCODKrgQbZEMqMwiICHAZ05hf35RWsMLToTTHgRHRFsx8JtO4yGkjzPEXsXX3gbr 98CN+vT74Bm2Gxo2HhM1kOw4qsM1QSL6pSym4g4UWWBltosicPVkX5LIzb+lTeCifpWs 7hHHFDqTZ9AnHvathjgZqLTjQ2pOKewLXe6ctmXwphGSXgBPFxi+j/Hcu47Zd7zaZsJJ TbsFePdryX6Uho3VqJyQr2HKE3RHZg6h0CC+X80yViw6hoEJaMMrPGYQ3iNktt4nO7Fh PExA== X-Gm-Message-State: AOAM533PlNXsBRxeshPwtsJR5A07HBTufNE9KMf/NcK17LowuQ7Q4mkQ cydSCzukb8OchCO/X0MQXZBe9za2mK8IL9sENxJ/T4RUBcTBVuNUJAQLNH2+YhQ4aS9u9RNS5uS 22L14OWBzp/Mi1c90Gz2tdusLObxoMLBo2w== X-Received: by 2002:a2e:6a13:: with SMTP id f19mr13454362ljc.360.1635537898180; Fri, 29 Oct 2021 13:04:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHjg6nod5p6NtpcY4AI98d1uCYy+MMoLubp1e9mJ8BeXhrc5MjoZSfXuf7Qu/FdsErPT3FSMrqiBXPE8021Z8= X-Received: by 2002:a2e:6a13:: with SMTP id f19mr13454334ljc.360.1635537897921; Fri, 29 Oct 2021 13:04:57 -0700 (PDT) MIME-Version: 1.0 References: <20211008151222.37790-1-aldyh@redhat.com> <2952e615-3607-7d6a-d214-739c90744397@gmail.com> In-Reply-To: From: Aldy Hernandez Date: Fri, 29 Oct 2021 22:04:46 +0200 Message-ID: Subject: Re: [PATCH] Convert strlen pass from evrp to ranger. To: Andrew MacLeod , Jakub Jelinek Cc: Martin Sebor , GCC patches , Jeff Law X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 20:05:03 -0000 On Fri, Oct 15, 2021, 12:39 Aldy Hernandez wrote: > > > On 10/15/21 2:47 AM, Andrew MacLeod wrote: > > On 10/14/21 6:07 PM, Martin Sebor via Gcc-patches wrote: > >> On 10/9/21 12:47 PM, Aldy Hernandez via Gcc-patches wrote: > >>> We seem to be passing a lot of context around in the strlen code. I > >>> certainly don't want to contribute to more. > >>> > >>> Most of the handle_* functions are passing the gsi as well as either > >>> ptr_qry or rvals. That looks a bit messy. May I suggest putting all > >>> of that in the strlen pass object (well, the dom walker object, but we > >>> can rename it to be less dom centric)? > >>> > >>> Something like the attached (untested) patch could be the basis for > >>> further cleanups. > >>> > >>> Jakub, would this line of work interest you? > >> > >> You didn't ask me but since no one spoke up against it let me add > >> some encouragement: this is exactly what I was envisioning and in > >> line with other such modernization we have been doing elsewhere. > >> Could you please submit it for review? > >> > >> Martin > > > > I'm willing to bet he didn't submit it for review because he doesn't > > have time this release to polish and track it... (I think the threader > > has been quite consuming). Rather, it was offered as a starting point > > for someone else who might be interested in continuing to pursue this > > work... *everyone* is interested in cleanup work others do :-) > > Exactly. There's a lot of work that could be done in this area, and I'm > trying to avoid the situation with the threaders where what started as > refactoring ended up with me basically owning them ;-). > > That being said, I there are enough cleanups that are useful on their > own. I've removed all the passing around of GSIs, as well as ptr_qry, > with the exception of anything dealing with the sprintf pass, since it > has a slightly different interface. > > This is patch 0001, which I'm formally submitting for inclusion. No > functional changes with this patch. OK for trunk? > > Also, I am PINGing patch 0002, which is the strlen pass conversion to > the ranger. As mentioned, this is just a change from an evrp client to > a ranger client. The APIs are exactly the same, and besides, the evrp > analyzer is deprecated and slated for removal. OK for trunk? > Ping * 2 for patch 2, although I'm sure it needs massaging after Martin Sebor's in the same area. Aldy