From: Lawrence Crowl <crowl@googlers.com>
To: Diego Novillo <dnovillo@google.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [cxx-conversion] gimplify_ctx::temp_htab hash table
Date: Mon, 03 Dec 2012 20:14:00 -0000 [thread overview]
Message-ID: <CAGqM8fZxOksQgUp9WTM=UuyMbopgvo5VrwdepVHw0A-z57dgXg@mail.gmail.com> (raw)
In-Reply-To: <50BD04F2.80305@google.com>
On 12/3/12, Diego Novillo <dnovillo@google.com> wrote:
> On 2012-12-01 20:44 , Lawrence Crowl wrote:
>> Index: gcc/gimple-fold.c
>> ===================================================================
>> --- gcc/gimple-fold.c (revision 193902)
>> +++ gcc/gimple-fold.c (working copy)
>> @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3.
>> #include "tree-ssa-propagate.h"
>> #include "target.h"
>> #include "gimple-fold.h"
>> +#include "gimplify-ctx.h"
>>
>> /* Return true when DECL can be referenced from current unit.
>> FROM_DECL (if non-null) specify constructor of variable DECL was
>> taken from.
>> Index: gcc/tree-mudflap.c
>> ===================================================================
>> --- gcc/tree-mudflap.c (revision 193902)
>> +++ gcc/tree-mudflap.c (working copy)
>> @@ -43,6 +43,7 @@ along with GCC; see the file COPYING3.
>> #include "ggc.h"
>> #include "cgraph.h"
>> #include "gimple.h"
>> +#include "gimplify-ctx.h"
>>
>> extern void add_bb_to_loop (basic_block, struct loop *);
>>
>> Index: gcc/tree-inline.c
>> ===================================================================
>> --- gcc/tree-inline.c (revision 193902)
>> +++ gcc/tree-inline.c (working copy)
>> @@ -48,6 +48,7 @@ along with GCC; see the file COPYING3.
>> #include "value-prof.h"
>> #include "tree-pass.h"
>> #include "target.h"
>> +#include "gimplify-ctx.h"
>
> I don't follow. It seems that factoring into gimplify-ctx.h does
> not actually buy much. The files using it are just including
> *another* file. Whereas previously, they were getting that
> content from gimple.h.
>
> Unless we can stop including gimple.h from these files, I don't
> see a lot of gain in this factoring. Am I missing something?
There at least 70 files that include gimple.h, and only 5 that need
gimple-ctx.h. By splitting it out, at least 65 files will not need
to parse the gimplify_ctx struct, the gimple_temp_hash_elt struct,
the gimplify_hasher template struct, and may not need to include
hash-table.h.
It's all about avoiding superfluous compilation in other files.
--
Lawrence Crowl
next prev parent reply other threads:[~2012-12-03 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 1:44 Lawrence Crowl
2012-12-03 20:01 ` Diego Novillo
2012-12-03 20:14 ` Lawrence Crowl [this message]
2012-12-04 9:23 ` Richard Biener
2012-12-04 14:06 ` Diego Novillo
2012-12-04 19:11 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGqM8fZxOksQgUp9WTM=UuyMbopgvo5VrwdepVHw0A-z57dgXg@mail.gmail.com' \
--to=crowl@googlers.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).