From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30484 invoked by alias); 27 Aug 2014 22:19:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30465 invoked by uid 89); 27 Aug 2014 22:19:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-la0-f54.google.com Received: from mail-la0-f54.google.com (HELO mail-la0-f54.google.com) (209.85.215.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 27 Aug 2014 22:19:44 +0000 Received: by mail-la0-f54.google.com with SMTP id b17so163432lan.41 for ; Wed, 27 Aug 2014 15:19:41 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.169.35 with SMTP id ab3mr35076773lbc.41.1409177981085; Wed, 27 Aug 2014 15:19:41 -0700 (PDT) Received: by 10.112.94.70 with HTTP; Wed, 27 Aug 2014 15:19:41 -0700 (PDT) In-Reply-To: References: Date: Wed, 27 Aug 2014 22:19:00 -0000 Message-ID: Subject: Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr From: Jonathan Wakely To: Siva Chandra Cc: gcc-patches , "libstdc++" , Doug Evans Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-08/txt/msg02518.txt.bz2 On 27 August 2014 22:39, Siva Chandra wrote: > The attached patch addresses Jonathan Wakely's comments on the > previous version of the patch: > https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02426.html > > On Tue, Aug 26, 2014 at 10:58 AM, Jonathan Wakely wrote: >> Shouldn't there be a change to python/Makefile.am so that xmethods.py >> gets installed alongside printers.py? Otherwise you can use these new >> xmethods in the libstdc++ testssuite, but they're not available to >> users. > > Ah, sorry I missed that. Added in the attached patch. Great, I'll try this new version tomorrow. >> I'd also expect something to call the register_libstdcxx_xmethods >> function automatically, as in the attached patch, although this >> doesn't work for me. > > gdb.xmethod is a module. Hence, hasattr(gdb, 'xmethod') in your > suggestion will not return True. I have modified this in the attached > patch to something which should work. OK thanks. > I had something in hook.in in my very first patch but Tom Tromey said > it was not required anymore: > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02405.html Interesting, I wonder how they should have been found then. I think I did test with the files installed, but they weren't used. I'll test again with the new patch.