From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely.gcc@gmail.com>
Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636])
	by sourceware.org (Postfix) with ESMTPS id 4C3633846473;
	Sat, 12 Nov 2022 11:27:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C3633846473
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x636.google.com with SMTP id t25so17860037ejb.8;
        Sat, 12 Nov 2022 03:27:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=exDued8LQ7cz0yUyZLXvcq10BwEzyd/hQC9O9g4Bg60=;
        b=NKOi191Gol+E+CxNbJNgAFRuO2ZQG4nWgcPfNe2gxW0QOBqcftQmJIwVN0QqsQJ9S4
         +9+chM/IkNi5+thGzRB0qRKFElUu0J8Epy58Z1cJwDzm22BZlerGaeeszBd/Bm/o9Ct1
         pM6FE5bEKvA+8a1ExcOP0L+QJ+iO+VkWz5l54O8dU6KaAhFVKH7LkfRKDkNHEm2Tjs7a
         yqIa0QEqItEcG9NR7Jp6pO/wmm2s2lq0wAOyIaQzR3+TnYAokY27TvwnwHZNg71n5un+
         kYavk13sQ56ozQiSvMVktaXtcPLNvzr7EUw+d0nR6kZhS0f6cvKie9c+d0HqhDhIEjbc
         85Lg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=exDued8LQ7cz0yUyZLXvcq10BwEzyd/hQC9O9g4Bg60=;
        b=oR1XsyG7BEWj7EK6wF0qRQgSJMURJDSEGyRifT4mRaFp2Rnn08/77Qx/GifMBABec/
         LEznwmf4c4PvCw4tM+YbYyDwsJu4Aty9EDlc8ELk6VHM+lLFzl63Tw2LpeHeS9nU8vrn
         u+cyFbQv5yJ0F10P5EvBpQ1ghS2S86KSvWEb//Fh8gtOH+AM3JG/+656Q3djKtIwxiLK
         1ys0PyX4DVqCzXF4YYvf0b1/mkaumU8HIhofJhEJAyiLOJ9vmdHFiHDrgybiDoGBgMjA
         XUogdh2us6OjmGuzUx9LFFJmBPH+3ZW28Kox0RzVTb5rdpYa5/josuriNmDKHUPrlydl
         RJZw==
X-Gm-Message-State: ANoB5plDUv9N1cdm+l445mjQgCSyLowtsYLaHLlW43sYHn5wWA+wm/Oa
	1Krxvzigalg22rQ7dV0/vmI0nf07arNmu3njdiQ=
X-Google-Smtp-Source: AA0mqf4V3F9EFkE2LFTQekBUZVgL0CFUi6QGUiiw24DB6cZSQ/4BBr7XIUTq2oIidxzCF1lOBmsP4/Z1dV6n3TSfiOI=
X-Received: by 2002:a17:906:1597:b0:7ad:ba48:7e7f with SMTP id
 k23-20020a170906159700b007adba487e7fmr4798347ejd.215.1668252453931; Sat, 12
 Nov 2022 03:27:33 -0800 (PST)
MIME-Version: 1.0
References: <Y29dkunenk2cCh7w@tucnak>
In-Reply-To: <Y29dkunenk2cCh7w@tucnak>
From: Jonathan Wakely <jwakely.gcc@gmail.com>
Date: Sat, 12 Nov 2022 11:27:21 +0000
Message-ID: <CAH6eHdQ2DYcWXxxTqnDPqvaYvUiEG11_vEAr0556=296do9Vvg@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: Fix up to_chars ppc64le _Float128 overloads [PR107636]
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jonathan Wakely <jwakely@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>, 
	"libstdc++" <libstdc++@gcc.gnu.org>
Content-Type: multipart/alternative; boundary="000000000000e98eb205ed444ab5"
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

--000000000000e98eb205ed444ab5
Content-Type: text/plain; charset="UTF-8"

On Sat, 12 Nov 2022, 08:47 Jakub Jelinek via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:

> Hi!
>
> As reported, I've misplaced __extension__ keywords in these cases
> (wanted not to have them on the whole inlines because _Float128 is
> completely standard now while __float128 is not, but before return
> it is a syntax error.
> I've verified on a short testcase that both g++ and clang++ accept
> __extension__ after return keyword.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux (admittedly
> not powerpc64le-linux with new glibc), ok for trunk?
>

OK, thanks



> 2022-11-12  Jakub Jelinek  <jakub@redhat.com>
>
>         PR libstdc++/107636
>         * include/std/charconv (to_chars): Fix up powerpc64le _Float128
>         overload __extension__ placement.
>
> --- libstdc++-v3/include/std/charconv.jj        2022-11-11
> 08:15:45.696183293 +0100
> +++ libstdc++-v3/include/std/charconv   2022-11-11 16:32:52.992693605 +0100
> @@ -892,23 +892,25 @@ namespace __detail
>    inline to_chars_result
>    to_chars(char* __first, char* __last, _Float128 __value) noexcept
>    {
> -    __extension__
> -    return to_chars(__first, __last, static_cast<__float128>(__value));
> +    return __extension__ to_chars(__first, __last,
> +                                 static_cast<__float128>(__value));
>    }
>    inline to_chars_result
>    to_chars(char* __first, char* __last, _Float128 __value,
>            chars_format __fmt) noexcept
>    {
> -    __extension__
> -    return to_chars(__first, __last, static_cast<__float128>(__value),
> __fmt);
> +
> +    return __extension__ to_chars(__first, __last,
> +                                 static_cast<__float128>(__value), __fmt);
>    }
>    inline to_chars_result
>    to_chars(char* __first, char* __last, _Float128 __value,
>            chars_format __fmt, int __precision) noexcept
>    {
> -    __extension__
> -    return to_chars(__first, __last, static_cast<__float128>(__value),
> __fmt,
> -                   __precision);
> +
> +    return __extension__ to_chars(__first, __last,
> +                                 static_cast<__float128>(__value), __fmt,
> +                                 __precision);
>    }
>  #else
>    to_chars_result to_chars(char* __first, char* __last, _Float128 __value)
>
>         Jakub
>
>

--000000000000e98eb205ed444ab5--