From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 5FAE93858D28; Sat, 19 Nov 2022 13:11:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5FAE93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x534.google.com with SMTP id i29so3083901edj.11; Sat, 19 Nov 2022 05:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yOfcVLmfLJGKTIrZyI5gxS18aGzW49kujG8wWudzLNg=; b=M2dG6d9Wqx01AJTVy/yWaEm226EKPyqnu2ef0gTHuhygp7NpLUZQWWMCX6PcKGIWpB C+9tHn8Usp4NcbBcwmvZQFbhmJQm+MfbGONLqjYOLoOh07Hg7g15AZYtXB3C7wEcYymR AAZ69/KgBLXIItebV0N/U4kVoz8evMHnt1Hn5fWknXyyfCJpk2ybSWYimGKwEF7BWbPR QmSWF/dhTb2rO1XsCvQpxifFeq0/wSu6RURYSFxtcIbvILA8q34oisJVwToUa/+XTfEc 4AP8bj+pKnNo8RPmEsJXuJUjHp/ZVNT7/g66lXQDmwF2xBo5EGnEulZT9j7iw40wAnhc cFHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yOfcVLmfLJGKTIrZyI5gxS18aGzW49kujG8wWudzLNg=; b=WAGgY4Tj0JF3o2QQ7krkpiKYKKuoUECSLHwfilNf6+8qZlfBn0XgcvjmOBNhkEeNqg v8jVKT1GapKdEDR97FX9dZCQqeCNsgA3spYNlgQEOm0MYI99X9hv1MNUzDfqk3f1fQwu 2cNa5JZV/JSpNoZ41QwuBXJOYaInYCGunItnvpFXFEzGNgsdb9UayapXy31cuPdjvDao E7fSZLbdWrF3PvefYXPLSx3ea8fdNqFYREsaf4vtQKpB1xhuYWRltXkhKLplT0wLlDsG OEh+WCdMlkMNCJmpkCvChnKzCPexa1ZiI1ynUyVBMkPEBnAf/6S6ph0+ZU8vXllgU7sM fEAw== X-Gm-Message-State: ANoB5pnwZhqCECeKEwbsPh01eMfXgqYHnqgX/Z8Tfqf698cOa5M5CH5b vlpA0bsjvwh8Sa1gq7KGzciZdKMW2uqvoeec0A8= X-Google-Smtp-Source: AA0mqf4MC11g4ge2Wz19CgHXQYThvrg8SmaS7SI27Mum+ChLH0N19FoVlws/ZUPy/lxx8JC3PAD2Vx5w7FU3WprqzxE= X-Received: by 2002:a05:6402:24a1:b0:463:e963:5149 with SMTP id q33-20020a05640224a100b00463e9635149mr9621368eda.219.1668863499893; Sat, 19 Nov 2022 05:11:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Sat, 19 Nov 2022 13:11:28 +0000 Message-ID: Subject: Re: [PATCH] Fix in _GLIBCXX_INLINE_VERSION mode To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 19 Nov 2022 at 13:03, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > Without this qualification I have this in _GLIBCXX_INLINE_VERSION mode: > > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/bits/locale_facets.h:2649: > note: candidate: 'template bool std::__9::isxdigit(_CharT, > const locale&)' > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/bits/locale_facets.h:2649: > note: template argument deduction/substitution failed: > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/format:1540: > note: candidate expects 2 arguments, 1 provided > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/format:1630: > error: no matching function for call to 'isxdigit(const > std::__9::basic_string_view::value_type&)' > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/bits/locale_facets.h:2649: > note: candidate: 'template bool std::__9::isxdigit(_CharT, > const locale&)' > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/bits/locale_facets.h:2649: > note: template argument deduction/substitution failed: > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/format:1630: > note: candidate expects 2 arguments, 1 provided > compiler exited with status 1 > FAIL: 17_intro/headers/c++2020/all_attributes.cc (test for excess errors) > Excess errors: > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/format:1540: > error: no matching function for call to 'isxdigit(const > std::__9::basic_string_view::value_type&)' > /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/inc= lude/format:1630: > error: no matching function for call to 'isxdigit(const > std::__9::basic_string_view::value_type&)' > > It sounds like the most reasonable fix as this is how toupper is being > called. I think the real problem is that include/c_global/cctype is missing the NAMESPACE_VERSION macros. All declarations of std::isxdigit etc should be in the same namespace, precisely so we don't need to do this. > > libstdc++: Add missing std qualification on isxdigit calls > > libstdc++-v3/ChangeLog > > * include/std/format: Add std qualification on isxdigit call= s. > > Ok to commit ? Yes, OK.