From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: Paolo Carlini <paolo.carlini@oracle.com>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Unordered container insertion hints
Date: Fri, 28 Jun 2013 12:13:00 -0000 [thread overview]
Message-ID: <CAH6eHdQASRGRn6+XV74fgB+pR_OZ5P6nNvwpMfg-rsR-4PcYkg@mail.gmail.com> (raw)
In-Reply-To: <CAH6eHdRnJ_tQu5pPM21cSNbtjNpm-YBbb19N1Rt5OrXssGjrng@mail.gmail.com>
On 23 June 2013 13:51, Jonathan Wakely wrote:
> On 19 June 2013 20:56, François Dumont wrote:
>> Still no chance to have a look ?
>
> I'll try to finish reviewing it today, thanks for the reminder.
Sorry for the delay. The patch is OK, with a few small changes to the new docs:
Please change "rational" to "rationale"
"can require to update the bucket" should be "can require updating the bucket"
"need to compute following node hash code." should be "need to compute
the following node's hash code."
"won't compute next element hash code" should be "won't compute the
next element's hash code"
"bench" should be "benchmark"
I would say "more harm than good" instead of "more bad than good"
Thanks!
next prev parent reply other threads:[~2013-06-28 11:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 19:49 François Dumont
2013-05-23 20:02 ` François Dumont
2013-05-23 23:00 ` Paolo Carlini
2013-06-06 20:33 ` François Dumont
2013-06-12 20:12 ` François Dumont
2013-06-19 19:56 ` François Dumont
2013-06-23 12:52 ` Jonathan Wakely
2013-06-28 12:13 ` Jonathan Wakely [this message]
2013-06-29 12:16 ` François Dumont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdQASRGRn6+XV74fgB+pR_OZ5P6nNvwpMfg-rsR-4PcYkg@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).