From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 6E9BC3858D28; Thu, 21 Mar 2024 06:20:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E9BC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6E9BC3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711002040; cv=none; b=QBYT/MB00w6K+T8avxy7FG7oSEMghM0XhkU+0Iz1blXz4ulEmFdekWm9rGQOpB4TTISEH0V4S4Clc3do/K3lNzIGNqWydhRw8kUcvAXdB9J8ShSD2s7uA0HeAUPIRyvA+V8TMPBjP2Z/uZAdl7bct80mjZcLmR5f3MeEeHoAHk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711002040; c=relaxed/simple; bh=ne1qYnFF/s49D4nG7N5mfUhq+ULlUfh/n2rpz/kk/Wc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=XDErSUO98zPXdMVehazOpGYsIcsTd1JPO5dhvqYZ5jNG0xA0weN6KFffbjQdSaCu59PkE5y6RT3nXTkRWXVA3cWDIzPuFTKPIYnOPjTdoeR+kKj7Y9f8bGnkwbgUw179l5+OPHOkWHse+Hj+IU8DGEi+u7+WqFZQdtedABaa3co= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so68584466b.0; Wed, 20 Mar 2024 23:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711002037; x=1711606837; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9LyfMggYHr0tlHN1lk7Xq3xStv9katumMrygfOOrLf4=; b=J2njoIeoxI93gAL6C7uTSyhEke0zb9qbBj4UAcNjJeNdsHR5gieUzNdqE6a8Qcre/y FPI+SL8gMkXCLoZp1BK9fNqyhfuYiBfz+Ea30f6Yj5HgOtApu6GiUuWy4r2pfNp2Thrl 1+6N+HWJLs4cG4EfqWI7E+uZcot+J2d4CVqnjrF7AiExSXQauNOMZVNWq09lI6d8UkO4 Er0GyxWoIiqsWlYIahNG+Y02Wtnl057JZgrMfHClRzAF3ACRIoVrsYjSHKvyeSMOL6IH jrc5jf966z9Bm+oNRCnECodu5id+fdC1HGsTgjZroESr6GJjxGz6FZuNjB4NzxueUuE+ 5fdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711002037; x=1711606837; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9LyfMggYHr0tlHN1lk7Xq3xStv9katumMrygfOOrLf4=; b=DDE8PEqF2r19mxLCct0hbGnaow8DriQ6W2lwNTlfjLg9dNoqVIllknCGpt5MiFIc94 sbEnEbeDl68dh2ZasodXuQYtwYbXmCUAN/TanjAjhWQchVfHA0edLcrbfZibnX6bEZJE 3t4toSzZXGnRiltp2F82CvEmJFZgDGvDlEvJG9C+jnLjiCM6/0tTSLX67A/RjTViFYbs nbCw7Yn5z56WjnJM8are8dilwRS8fc+1KQ5bRUUU9CgrV9PMmM6hkcXXQLWqE6t9y/oA lO8JxHe3DQuyBkPHptqjs9tBLP3/9Wio2wwWGiWbLHZNmp6JsHrqZGytVpEQ/A3VgBoY IyhQ== X-Forwarded-Encrypted: i=1; AJvYcCVBaUyZ6ffYgArfMPn2leHR3EbNSJatXJ/OES9h0WHclvLJoXXYnSLGuIRfQVH4UdOaBeWgrGNqMj+mKTYklDTsgSrq3fIivlSYru2m598JNSJmitMPa603/GyM5tP9 X-Gm-Message-State: AOJu0Yx0F0cC8yPIWK2G205C/J/K8JtoKniG4QHxKoptMXOKbCQ4qWWc Qv6bUuL34M/P/XwPBxWzywsmuMh2UNm+GmIEXvx/4emEZzZ833xsUgcn/qeaonqJse58TohmslU sorpPtybi4upwnBsRdktXiyzf1B0= X-Google-Smtp-Source: AGHT+IGbWDUD0Pk/4QC9oSwZkLXFgqPKW4tiA4My7zXZdUN859dic8CRfZxaKH0StQuzurNsOL45oLvKnm71iuCSlUA= X-Received: by 2002:a17:906:f189:b0:a47:add:79e3 with SMTP id gs9-20020a170906f18900b00a470add79e3mr693476ejb.7.1711002036919; Wed, 20 Mar 2024 23:20:36 -0700 (PDT) MIME-Version: 1.0 References: <73AC0523-2237-46FD-9885-7AE3F8663DF2@gmail.com> <28CE4FD1-FFB0-4300-81CA-C3CB07E436A6@gmail.com> <19f5939a-9341-4237-90d9-4f1279f03a88@gmail.com> <2f29d2f2-a21b-42bb-997f-3918935d0dba@gmail.com> <4374668e-f7e9-4912-a8e6-a50710999d4b@gmail.com> <114c9cc7-6990-48be-87b9-b8ac02015531@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 21 Mar 2024 06:20:25 +0000 Message-ID: Subject: Re: _LIBCXX_DEBUG value initialized singular iterators assert failures in std algorithms [PR104316] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 20 Mar 2024 at 18:11, Fran=C3=A7ois Dumont wrote: > > As proposed below I also updated gcc-13 branch. Great, thanks. > > libstdc++: [_GLIBCXX_DEBUG] Define __cpp_lib_null_iterators > > _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we > can define > __cpp_lib_null_iterators macros like the normal mode. > > libstdc++-v3/ChangeLog: > > * include/std/iterator (__cpp_lib_null_iterators): Define > regardless of > _GLIBCXX_DEBUG. > * include/std/version (__cpp_lib_null_iterators): Likewise. > > Fran=C3=A7ois > > > On 20/03/2024 10:02, Jonathan Wakely wrote: > > On Wed, 20 Mar 2024 at 05:59, Fran=C3=A7ois Dumont wrote: > >> Thanks to you doc: > >> > >> libstdc++: [_GLIBCXX_DEBUG] Define __[glibcxx,cpp_lib]_null_iter= ators > >> > >> _GLIBCXX_DEBUG has now fully N3344 compliant iterator checks, we > >> can define > >> __glibcxx_null_iterators and __cpp_lib_null_iterators macros lik= e > >> the normal > >> mode. > >> > >> libstdc++-v3/ChangeLog: > >> > >> * version.def (null_iterators): Remove extra_cond. > >> * version.h: Regenerate. > >> > >> Ok to commit ? > > Please don't bother talking about __glibcxx_null_iterators in the > > commit message, that's an implementation detail that always mirrors > > the standard-defined __cpp_lib_null_iterators one. The first line of > > the commit will be much easier to read without that. > > > > OK with that change, thanks. > > > >> I already noticed that GCC 13 has no version.h file so no backport que= stion. > > It has no version.h but it still has the macros: > > > > include/std/iterator:# define __cpp_lib_null_iterators 201304L > > include/std/version:# define __cpp_lib_null_iterators 201304L > > > > Those definitions can be made to not depend on _GLIBCXX_DEBUG. > >