From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [libstdc++] [testsuite] xfail dbl from_chars for aarch64 rtems ldbl
Date: Thu, 15 Jun 2023 13:44:10 +0300 [thread overview]
Message-ID: <CAH6eHdQLNa4sotTKmX8b-N4FPtFW+eZ_9k0V0SJTmpswUEpAdg@mail.gmail.com> (raw)
In-Reply-To: <ormt11y80p.fsf@lxoliva.fsfla.org>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
On Thu, 15 Jun 2023, 01:49 Alexandre Oliva via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
>
> rtems, like vxworks, uses fast-float doubles for from_chars even for
> long double, so it loses precision, so expect the long double bits to
> fail on aarch64.
>
> Regstrapped on x86_64-linux-gnu, also tested on aarch64-rtems6. Ok to
> install?
>
OK, thanks
>
> for libstdc++-v3/ChangeLog
>
> * testsuite/20_util/from_chars/4.cc: Skip long double on
> aarch64-rtems.
> ---
> libstdc++-v3/testsuite/20_util/from_chars/4.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> b/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> index 206e18daeb229..76e07df9d2bf3 100644
> --- a/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> +++ b/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> @@ -18,7 +18,7 @@
> // <charconv> is supported in C++14 as a GNU extension
> // { dg-do run { target c++14 } }
> // { dg-add-options ieee }
> -// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target
> aarch64-*-vxworks* x86_64-*-vxworks* } }
> +// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-rtems*
> aarch64-*-vxworks* x86_64-*-vxworks* } }
>
> #include <charconv>
> #include <string>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
>
prev parent reply other threads:[~2023-06-15 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 22:49 Alexandre Oliva
2023-06-15 10:44 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdQLNa4sotTKmX8b-N4FPtFW+eZ_9k0V0SJTmpswUEpAdg@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).