From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 1B43D38654A3; Fri, 17 Feb 2023 11:01:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B43D38654A3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x532.google.com with SMTP id ec30so3059471edb.2; Fri, 17 Feb 2023 03:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uIcmhEXEIc4HsRae84yzIc1Ra813zX2ptyBa/xz+UCY=; b=W22COxvcMnVWY5r7UPRoJ4gXLXQmteoOKKo4Qr1GPsMT0u/vqRFF8GPSMTEp+ElC62 9ciPJGHAGk7h9IwVAr1gFnlVurEZxToZKSNDok2mpvATEPmpuOMy82Ty8uZh6UwWjnaq uxQdRJzDlb5a4M8IaYZ9L/t2USrWOjFc9yN9qWdhDQu148QprH56eSFs2uM3QrtOCsuq OEJFGbIa5VGKFOx3mMyXxiB79E0KTLg+IWa1m4K88n2JZw0kI81XqZCMv9SpTPeBQhoH TsRBs/h4tgXzILWb6kPEmHKcTqzPw7mT+8ceyvh8RJ2nqO4rB6cve/dzG+ezAjSvraXw lQvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uIcmhEXEIc4HsRae84yzIc1Ra813zX2ptyBa/xz+UCY=; b=ZMYLvely2IMheDV86IbCBlfLYR5bmrJqp4j80kdB8gUZP2njLfbMfkdAwdlNOODHdA Oq/A/LIbVpqCgz+BKXmrig40rorQ4lOcS5aX1hdKOV8L35+2wUdssESc5KPY/F0PrVoo pLayv6xiJXV07BVoVQ7UU/X2kZ3X0CH9RIBdKbsa7BdB+WXYLDA6GvMjU26u5pCmZsWb waLY4tPN8IWdQPZaoO1AS2WRsdEX+sLlh52+znKZH1mTs0AtP4Bz5MMmUtJSVKX1xtlW jq5WzdOTlYqUdJhtK/WqxJqXFSuNl3JW1t2GXgf3+benOgxhLPyrzl8TAUXG6tfpTW5D sZ3w== X-Gm-Message-State: AO0yUKUTOsR+IThm0bLoxHVE8+YSJG4Ot/LagmeGm/dAqxe/8UkVVROL BnCRyxE8+fw7HqpyXqGkaSDfQXU236hAcBLgSkjG7tLb X-Google-Smtp-Source: AK7set/6R4106Xhl/qGU4X92CglqF3CxgQCvFSrxX50SGFhhx1vlEOzqk25SWNmfM/4Y0sbmKriZKUjUpeKO9bT8hsc= X-Received: by 2002:a50:8ad6:0:b0:4ad:23b:6f51 with SMTP id k22-20020a508ad6000000b004ad023b6f51mr531619edk.5.1676631666752; Fri, 17 Feb 2023 03:01:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Fri, 17 Feb 2023 11:00:54 +0000 Message-ID: Subject: Re: [PATCH] [libstdc++] xfail noreplace tests on vxworks To: Alexandre Oliva Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000ea801a05f4e33acd" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ea801a05f4e33acd Content-Type: text/plain; charset="UTF-8" On Fri, 17 Feb 2023, 07:40 Alexandre Oliva via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > > vxworks ignores O_EXCL in open, so noreplace open succeeds when it is > expected to fail. xfail the tests. > > Regstrapped on x86_64-linux-gnu. > Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install? > OK, thanks. (We need a similar change for hp-ux and Solaris, at least. Which means we need to change the impl to not assume it works.) > for libstdc++-v3/ChangeLog > > * testsuite/27_io/basic_ofstream/open/char/noreplace.cc: xfail > on vxworks. > * testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc: > Likewise. > --- > .../27_io/basic_ofstream/open/char/noreplace.cc | 2 +- > .../27_io/basic_ofstream/open/wchar_t/noreplace.cc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc > b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc > index 56ff2d7cead3c..2e99707df86d0 100644 > --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc > +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc > @@ -1,4 +1,4 @@ > -// { dg-do run } > +// { dg-do run { xfail *-*-vxworks* } } > > #include > > diff --git > a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc > b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc > index f0425cdab3d23..ddb7fd691608c 100644 > --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc > +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc > @@ -1,4 +1,4 @@ > -// { dg-do run } > +// { dg-do run { xfail *-*-vxworks* } } > > #include > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about > --000000000000ea801a05f4e33acd--