public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org,
		Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] libstdc++: Add mem_order_hle_acquire/release to atomic.h v2
Date: Mon, 14 Jan 2013 12:30:00 -0000	[thread overview]
Message-ID: <CAH6eHdQrFGc3eHJQSJFZo7avxZ+FNVcsgPCrA6JVNBjdLVQp0Q@mail.gmail.com> (raw)
In-Reply-To: <1358143565-29558-1-git-send-email-andi@firstfloor.org>

On 14 January 2013 06:06, Andi Kleen  wrote:
>
> The underlying compiler supports additional __ATOMIC_HLE_ACQUIRE/RELEASE
> memmodel flags for TSX, but this was not exposed to the C++ wrapper.
> Handle it there.
>
> These are additional flags, so some of assert checks need to mask
> off the flags before checking the memory model type.
>
> This is a reworked version over the version last year, including
> using operator overloading as suggested by Jonathan Wakely
> and a real test case
>
> Needs the earlier __atomic_clear/store HLE fix patch to make
> the test case succeed.
>
> Passes bootstrap and testsuite on x86_64-linux.

This looks good, thanks for reworking it.

I think the new testcase should only have 2013 in the copyright dates,
and does atomic_base.h need 2013 added?

As the earlier version was first posted some time ago I think it's OK
even though the trunk's now in release branch mode.  Please wait 24
hours in case anyone else objects and if not it can be committed.

Thanks.

  reply	other threads:[~2013-01-14 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14  6:06 Andi Kleen
2013-01-14 12:30 ` Jonathan Wakely [this message]
2013-01-21 14:06 ` Jakub Jelinek
2013-01-22 17:01   ` [PATCH] libstdc++: Fix up explicit-hle.cc test Jakub Jelinek
2013-01-22 17:13     ` Jonathan Wakely
2013-01-22 17:23     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH6eHdQrFGc3eHJQSJFZo7avxZ+FNVcsgPCrA6JVNBjdLVQp0Q@mail.gmail.com \
    --to=jwakely.gcc@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).