From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30698 invoked by alias); 29 Oct 2012 00:08:33 -0000 Received: (qmail 30685 invoked by uid 22791); 29 Oct 2012 00:08:28 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Oct 2012 00:08:22 +0000 Received: by mail-ie0-f175.google.com with SMTP id c13so6340506ieb.20 for ; Sun, 28 Oct 2012 17:08:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.15.132 with SMTP id x4mr7798824igc.58.1351469302244; Sun, 28 Oct 2012 17:08:22 -0700 (PDT) Received: by 10.42.158.202 with HTTP; Sun, 28 Oct 2012 17:08:22 -0700 (PDT) In-Reply-To: References: Date: Mon, 29 Oct 2012 00:43:00 -0000 Message-ID: Subject: Re: [patch] fix outdated path in cpp.texi From: Jonathan Wakely To: Gerald Pfeifer Cc: gcc-patches Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg02548.txt.bz2 On 28 October 2012 22:21, Gerald Pfeifer wrote: > On Sun, 21 Oct 2012, Jonathan Wakely wrote: >>> I was going to say "Ack", since it's a doc patch, but somehow my >>> own tests on various platforms (FreeBSD, GNU/Linux,...) did not >>> confirm /usr/include/c++ in the search path. >>> >>> Or do you mean that it's at the root of some search paths, that >>> is /usr/include/c++/... instead of /usr/include/g++-v3 ? (I >>> definitely have not seen the latter anywhere, so if it's this, >>> then it looks okay.) >> I get: >> >> echo | g++ -v -E -x c++ - 2>&1 | sed -n '/#include <...> search >> starts/,/End of search list/p' >> #include <...> search starts here: >> /usr/lib/gcc/x86_64-redhat-linux/4.6.3/../../../../include/c++/4.6.3 >> /usr/lib/gcc/x86_64-redhat-linux/4.6.3/../../../../include/c++/4.6.3/x86_64-redhat-linux >> /usr/lib/gcc/x86_64-redhat-linux/4.6.3/../../../../include/c++/4.6.3/backward >> /usr/lib/gcc/x86_64-redhat-linux/4.6.3/include >> /usr/local/include >> /usr/include >> End of search list. >> >> And: >> >> readlink -f /usr/lib/gcc/x86_64-redhat-linux/4.6.3/../../../../include/c++/4.6.3 >> /usr/include/c++/4.6.3 > > Yep, just I first read the text as /usr/include/c++ itself being in > the include path (which it is not). Of course, g++-v3 is even more > incorrecot :-), so the patch is fine. > > Perhaps you can rephrase it a bit to help clarify that? (But that > is optional; in any case, your patch improves what is currently there.) Yes, libdir/gcc/target/version/../../../../include/c++/version would be more accurate, because libdir is not necessarily /usr I'll come up with something better ...