From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23590 invoked by alias); 15 Jan 2014 17:17:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23572 invoked by uid 89); 15 Jan 2014 17:17:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-la0-f51.google.com Received: from mail-la0-f51.google.com (HELO mail-la0-f51.google.com) (209.85.215.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 17:17:32 +0000 Received: by mail-la0-f51.google.com with SMTP id c6so1662489lan.38 for ; Wed, 15 Jan 2014 09:17:28 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.112.169.42 with SMTP id ab10mr44462lbc.87.1389806245147; Wed, 15 Jan 2014 09:17:25 -0800 (PST) Received: by 10.112.132.168 with HTTP; Wed, 15 Jan 2014 09:17:25 -0800 (PST) In-Reply-To: <52D6BDC7.1000803@gmail.com> References: <52D6BDC7.1000803@gmail.com> Date: Wed, 15 Jan 2014 17:17:00 -0000 Message-ID: Subject: Re: experimental testsuite patch From: Jonathan Wakely To: =?ISO-8859-1?Q?Fran=E7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-01/txt/msg00896.txt.bz2 On 15 January 2014 16:56, Fran=E7ois Dumont wrote: > Hi > > Here is a patch to partially fix 2 string_view tests. It looks like we > can't use 2 dg-options into the same source, one override the over, the > dg-options directives have been merged into 1. I also update a script to > make the experimental folder part of the folders to look for tests. I don= 't > know if it was intentionally omitted because of the experimental aspect of > what is tested, if so just tell me I won't apply this part. I think it's OK. > Remaining failures in string_view tests in debug mode are all coming > from this kind of code: > > constexpr const _CharT& > operator[](size_type __pos) const > { > _GLIBCXX_DEBUG_ASSERT(__pos <=3D this->_M_len); > return *(this->_M_str + __pos); > } > > In debug mode the _GLIBCXX_DEBUG_ASSERT is activated and the operator > cannot be a constexpr anymore. Maybe Ed can tell what should be done, > remove the assertion or remove the constexpr (maybe only in debug mode ?)= ? I think we decided we want functions to be constexpr in debug mode if they are constexpr in normal mode. I think std::array has solved the same problem without losing the constexpr qualifier. > 2014-01-15 Fran=E7ois Dumont > > * scripts/create_testsuite_files: Add testsuite/experimental in > the list of folders to introspect for tests. s/introspect/inspect/ The patch is OK with that change, thanks.,