From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76842 invoked by alias); 22 Feb 2019 19:03:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76811 invoked by uid 89); 22 Feb 2019 19:03:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-DKIM-Signature:PqD, H*Ad:U*jwakely X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 19:03:46 +0000 Received: by mail-wr1-f65.google.com with SMTP id v13so3516444wrw.5; Fri, 22 Feb 2019 11:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cS++opeEiQHjwNo7htcD66L45gb8sA6+Qg2d+UWOaBk=; b=FTUaUcS7DPwN+hWvQM7Fo64N9lf55DPOACDYydV7n+2w/9ZcdhVtHUk7W7kvtFUfIT Q1WvM8MitXjUTY9AnmMudA4fFF5LI8b64TINMY+jyyxV558DiVGrbgmXa2ULIF18aWu7 rtY9lc/xdllGXPutLn6/Cx476WHYbrygR9yHn0ttKs1p49RF+/qDGTQjgYXqwqRP4737 EdEjsaW+Fw+FrVkWD7I2KDY8kvVvYi4/NOyZVlzvMXYMxwcLIy0d7bskpjpN6SmUb+fX GxFO1HbrQqriCE1NSbNljgwdae6/sNPJFww4ZrRp8GOsx1qLC5xHK+YTOFr7AYS5YtmP VFWw== MIME-Version: 1.0 References: <20190220080731.GC2135@tucnak> <20190222011032.GA29002@redhat.com> <20190222184736.GF7611@tucnak> In-Reply-To: <20190222184736.GF7611@tucnak> From: Jonathan Wakely Date: Fri, 22 Feb 2019 19:19:00 -0000 Message-ID: Subject: Re: [PATCH] Fix -Wattributes warning in libstdc++ (PR libstdc++/89402) To: Jakub Jelinek Cc: Jonathan Wakely , Martin Sebor , gcc-patches , "libstdc++" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-02/txt/msg01850.txt.bz2 On Fri, 22 Feb 2019 at 18:47, Jakub Jelinek wrote: > > On Fri, Feb 22, 2019 at 08:35:25AM -0700, Martin Sebor wrote: > > > /home/jwakely/src/gcc/libstdc++-v3/src/c++98/compatibility-ldbl.cc:78= :65: > > > warning: =E2=80=98pure=E2=80=99 attribute on function returning =E2= =80=98void=E2=80=99 [-Wattributes] > > > 78 | _GLIBCXX_PURE __attribute__((alias ("_ZNKSt3tr14hashIeEclEe= "))); > > > | = ^ > > > > Are the attributes on this alias ever considered in calls to it? > > If not (and assuming there's a way to tell, which I think there > > should be but haven't verified it) the warning could be relaxed > > There is no point in relating this, this alias is just a hack in a hack > to save a few bytes of code. > > I've now finally bootstrapped/regtested on {powerpc64le,s390x}-linux > following patch, without it I indeed get those > ../../../../libstdc++-v3/src/c++98/compatibility-ldbl.cc:78:65: warning: = 'pure' attribute on function returning 'void' [-Wattributes] > warnings, with the patch I don't get any warnings on compatibility-ldbl.cc > anymore. Ok for trunk? OK, thanks.