From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Results for 8.0.1 20180316 (experimental) [trunk revision 258610] (GCC) libstdc++ testsuite on x86_64-pc-linux-gnu
Date: Tue, 20 Mar 2018 21:44:00 -0000 [thread overview]
Message-ID: <CAH6eHdRhFvBi8_EbNLymPPZK=2zpmb-oehRmUZbpxgHkLkNBMw@mail.gmail.com> (raw)
In-Reply-To: <075b9c05-fc02-5d89-45ce-cde812bbca3f@gmail.com>
On 20 March 2018 at 21:02, François Dumont wrote:
> On 20/03/2018 19:20, Jonathan Wakely wrote:
>>
>> On 17 March 2018 at 09:01, Jonathan Wakely wrote:
>>>
>>> Native configuration is x86_64-pc-linux-gnu
>>>
>>> === libstdc++ tests ===
>>>
>>>
>>> Running target unix/-std=gnu++11/-D_GLIBCXX_ASSERTIONS
>>>
>>> === libstdc++ Summary for
>>> unix/-std=gnu++11/-D_GLIBCXX_ASSERTIONS ===
>>>
>>> # of expected passes 12330
>>> # of expected failures 71
>>> # of unsupported tests 579
>>>
>>> Running target unix/-std=gnu++11/-D_GLIBCXX_DEBUG
>>> XPASS: 21_strings/basic_string_view/element_access/char/2.cc execution
>>> test
>>> XPASS: 21_strings/basic_string_view/element_access/wchar_t/2.cc execution
>>> test
>>> FAIL: 23_containers/bitset/hash/1.cc (test for excess errors)
>>> UNRESOLVED: 23_containers/bitset/hash/1.cc compilation failed to produce
>>> executable
>>
>> These debug mode failures are regressions, reported as
>> https://gcc.gnu.org/PR84998
>>
>> I think they all have the same root cause (Nathan fixed a bug in G++).
>>
> I had already prepared this patch. Thanks for explaining why we have this
> problem now.
Ah I was just about to commit my own fix.
> Note that I chose to use full specialization with std::hash<> for
> std::bitset and std::vector<bool>.
Great, that's an improvement over my patch.
> It also fix a versioned namespace issue when partially specializing
> std::hash for debug vector<bool>.
Even better.
> Tested under Linux x86_64 normal, debug and versioned namespace modes.
>
> Ok to commit ?
Yes please!
Please be sure to add "PR libstdc++/84998" to the changelog entry so
it updates bugzilla.
Thanks very much.
next prev parent reply other threads:[~2018-03-20 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5aacd955.W97SAA9Qc1hoHlKB%jwakely.gcc@gmail.com>
[not found] ` <CAH6eHdQZr1uB5ADsuj+A688mWbAObBmhuWQ_PQNpsOuA75gjFw@mail.gmail.com>
2018-03-20 21:03 ` François Dumont
2018-03-20 21:44 ` Jonathan Wakely [this message]
2018-03-21 12:33 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdRhFvBi8_EbNLymPPZK=2zpmb-oehRmUZbpxgHkLkNBMw@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).