From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Stephan Bergmann <sberg.fun@gmail.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 1/2] libstdc++: Handle extended alignment in std::get_temporary_buffer [PR105258]
Date: Tue, 18 Jun 2024 20:38:13 +0100 [thread overview]
Message-ID: <CAH6eHdSBcJBLV0tVLUO6uLjji4DK0s+6nm6J_kUhbTOC3AiTUw@mail.gmail.com> (raw)
In-Reply-To: <d4422211-7feb-4f9b-9bac-a54ad7f58983@gmail.com>
On Tue, 18 Jun 2024 at 19:05, Stephan Bergmann <sberg.fun@gmail.com> wrote:
>
> On 6/3/24 22:22, Jonathan Wakely wrote:
> > Pushed to trunk now.
>
> Just a heads-up that this started to cause Clang (at least 18/19) to
> emit a -Wdeprecated-declarations now,
Yes, I saw this too.
> (There already is another such pragma diagnostic ignored a bit further
> down in that file, so I assume that's the way to go there?)
Yes, the call to get_temporary_buffer used to be in that function
further down in the file. I moved it elsewhere in the file, but didn't
move the pragma to go with it, oops.
So we can remove those later pragmas, and move them earlier in the
file. I'm already testing a patch locally.
next prev parent reply other threads:[~2024-06-18 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 10:25 [PATCH " Jonathan Wakely
2024-06-01 10:25 ` [PATCH 2/2] libstdc++: Reuse temporary buffer utils in <stacktrace> Jonathan Wakely
2024-06-03 20:22 ` Jonathan Wakely
2024-06-01 11:19 ` [PATCH v2 1/2] libstdc++: Handle extended alignment in std::get_temporary_buffer [PR105258] Jonathan Wakely
2024-06-03 20:22 ` Jonathan Wakely
2024-06-18 18:04 ` Stephan Bergmann
2024-06-18 19:38 ` Jonathan Wakely [this message]
2024-06-19 13:08 ` [committed] libstdc++: Fix warning regressions in <bits/stl_tempbuf.h> Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdSBcJBLV0tVLUO6uLjji4DK0s+6nm6J_kUhbTOC3AiTUw@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=sberg.fun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).