From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id E1C3E3858C31; Mon, 20 Nov 2023 11:55:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1C3E3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1C3E3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700481338; cv=none; b=X/7yoJNB62PcVzjdISumpwqgmtM9ipFmuXSYkuDIQBZ3Vg3phksZkXl6MplZplpR/w87Hn96UvCGedROPSQtx0hWBsnLPUrKfQ1NlBhKIDYOlDJCO2DGDHs7Rt8BgeWsOGwVxcJmb3sxtm2x2+5c6kG5H8Yf/0oZJAopJTLVzSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700481338; c=relaxed/simple; bh=ptB3ELXv/qJ5CqZHthTdwiogsYqQVAf5lcMsJU9XP0A=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=aFUe+WBQ4ZWnOJ4WYRqNpN9qjCjwKZcSdPPXsJqL1Wikp0HqWfhJy05rvseNznUxcULpwdopU27nPNPrBVX9nhKinzPHcG4tRKwbuF9rLVjiCr8VeJRzS2Tq4GPOGIPn7i6p9DoyTCYpbVz5LxRornq3WFU8TU9V73gNYX6uUDk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9c603e2354fso806476166b.1; Mon, 20 Nov 2023 03:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700481334; x=1701086134; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W+kt1+xqhZGCNEjxHCJjYzT0aTeDRc+qZPI3PtyxITE=; b=nE5kiLl42i+tl/585hi9I4l7AkcNXDcY5kdt1C3U6Xi62cg/D/lzJhiHHdmofObRle 7OBduN6WfOkG+2nWGyTLbsx3EuBWruX+ySDEGEROKJbwLvlm6ldLyIaJGpmzghc9dsme uXXZJ6A1TfUqSjfowD35seQEyYEUz1xV2itZFyVabp6XBV2rbTuaorYbY+vYNeNr2yTO UORC2Y88Hjslog+aUMzKlhX1dDcqW0z8/2sVE7h/jRCJOKRhRnOfARvSKOFIZzTED6f7 LGqsI8Q0/IxuhjiAiSK+bOw/rt/22ZEcr1Yb+/UsRFY9u4pe+Isf2BfYDM5DC8aj8C6B dRVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700481334; x=1701086134; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W+kt1+xqhZGCNEjxHCJjYzT0aTeDRc+qZPI3PtyxITE=; b=Y+/bxaWZH3VRxgNSb9oly1+uiOoSjGFAUalqehIJhkYcmwufsWmaYXMMKgErzDwoMr GeBYJik4yM44SKbRQW0JL6b6/l0NEBI9igwVzfD1J1ZWRCH56QiowKPHnhfJmwH6mZqc I7u99NfiZBT8mkzGjczHaG3UornsYHLkvIahXBKMDm6tdbUh9k74n5po8ZWL6Kz4n2rO rKrqE1/6HfeTwSNIx7YZOrrtc3Tqi5Wq27/aWUF1pAOFdw6Nky9k4m+vuhV6fvJJLMfZ ieBcWsZm1EIa1UGZrAkdCmRTYAKRoeiZ0I93j4n+fa5OCbQVBhK0G3kskeYSnjFkEwxe FEJg== X-Gm-Message-State: AOJu0YwwYU58qpGwEFuTeUznpw7/PR7PTf4mTARFz0Ciq9F1uy1qZY7j J2yNA4hQuCyO6ARv6rMclzjquIRhKoxH6QGxh8M= X-Google-Smtp-Source: AGHT+IH3KMwEJEgeOAWBDulwiAgCguKLvP+1cvoCm3FSjHcLCvJFjLSRaOFXUyUuHp6fu6CGJI1lqxlUPYKtp8ncRuM= X-Received: by 2002:a17:906:a097:b0:9fa:caf4:f4a with SMTP id q23-20020a170906a09700b009facaf40f4amr1632168ejy.32.1700481334258; Mon, 20 Nov 2023 03:55:34 -0800 (PST) MIME-Version: 1.0 References: <20231116172021.1344351-1-jwakely@redhat.com> <20231120021257.630B72041D@pchp3.se.axis.com> In-Reply-To: <20231120021257.630B72041D@pchp3.se.axis.com> From: Jonathan Wakely Date: Mon, 20 Nov 2023 11:55:22 +0000 Message-ID: Subject: Re: [committed] libstdc++: Fix aligned formatting of stacktrace_entry and thread::id [PR112564] To: Hans-Peter Nilsson Cc: Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 20 Nov 2023 at 02:13, Hans-Peter Nilsson wrote: > > > From: Jonathan Wakely > > Date: Thu, 16 Nov 2023 17:20:09 +0000 > > > PR libstdc++/112564 > > * include/std/stacktrace (formatter::format): Format according > > to format-spec. > > * include/std/thread (formatter::format): Use _Align_right as > > default. > > * testsuite/19_diagnostics/stacktrace/output.cc: Check > > fill-and-align handling. Change compile test to run. > > * testsuite/30_threads/thread/id/output.cc: Check fill-and-align > > handling. > > You already know this, so JFTR: this introduced a regression > for some targets, logged as PR112630. > > Was this change deliberate: > > > --- a/libstdc++-v3/testsuite/19_diagnostics/stacktrace/output.cc > > +++ b/libstdc++-v3/testsuite/19_diagnostics/stacktrace/output.cc > > @@ -1,4 +1,5 @@ > > -// { dg-do compile { target c++23 } } > > +// { dg-options "-lstdc++exp" } > > +// { dg-do run { target c++23 } } > > // { dg-require-effective-target stacktrace } > > // { dg-add-options no_pch } > > i.e. changing from dg-compile to dg-run? Yes, it was always supposed to be a run test, the old dg-do was a typo that I only noticed when fixing the formatting bug (PR 112564). > I'm guessing so. Though the changelog entry and post isn't > explicit, the use of VERIFY is rather clear and most tests > in 19_diagnostics/stacktrace are dg-run. The changelog entry does say "Change compile test to run." > > If so, can the "dg-run-ness" of the test please move to a > separate test and let 19_diagnostics/stacktrace/output.cc be > just dg-compile? This particular test may not warrant the > consideration, but more so a pattern to follow for other > tests. I don't see any point in doing that here, being able to compile code doing I/O on stacktraces but not run it isn't useful. It needs to be a run test. We do it elsewhere if it's meaningful, e.g. several testsuite/std/format/* tests, and the ones I just added in r14-5562-g568eb2d25c8f79 are all 'compile' only. > > brgds, H-P > PS. Sorry, I have no idea why regarding the underlying multi-target problem I have some vague speculation in PR 112541.