From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely.gcc@gmail.com>
Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com
 [IPv6:2607:f8b0:4864:20::12a])
 by sourceware.org (Postfix) with ESMTPS id 449C83858D34;
 Tue,  2 Jun 2020 13:57:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 449C83858D34
Received: by mail-il1-x12a.google.com with SMTP id a13so8177273ilh.3;
 Tue, 02 Jun 2020 06:57:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=7CPAeakwwvu9Cpz7gatDKzpAcHi/9mQxndZh5RkiaOI=;
 b=uJirYrwhpZvUiFHiiOoTa4npbOQ6nyvvAke0OYvjN9fPARFI9xGnxCV/L9CxxM0gtO
 7KEc2nJFUqA38IShGabl8Zi69NE34z7x+kXVsZEnJFYr/SmN24W2uvQ6iDtf2Km2nDB6
 iq1bFC094G9WTHWWJPczQUjIRY39rN923AzP2Zx0z34Lwo6kVT0Gdu55TINhGrqYKR0x
 Vv+RutfnM3znhK6BRVurf7VuA6JOWndeIhbNFtJwIFe0CqVfqY6zM/NBF+ZN0ZQPY93W
 DQqzuLyJ3mj1730uhVdBGOF9THdwzley9VasAWqo7WZ9hZ0fDS78eAURn2873tbeJx99
 AdJA==
X-Gm-Message-State: AOAM530qj3QzLWSraMjGBA/MVv+gajhuhlh+WCurcnh0zsF1xhsoDyae
 xZ42RIMfiIAEqRBmAOOks8y1URd9SbGTJpHgl7w=
X-Google-Smtp-Source: ABdhPJxgL9YLeBurvh102ZwtCQIBTCEu9m2Wdo24e0nrBPnLhz/6fx7s9J8ZwRry5Erl21RqBXzj1Q0JS7n/T4hRW/Y=
X-Received: by 2002:a05:6e02:1203:: with SMTP id
 a3mr660530ilq.30.1591106229754; 
 Tue, 02 Jun 2020 06:57:09 -0700 (PDT)
MIME-Version: 1.0
References: <20200525224858.GO8462@tucnak>
 <CAH6eHdRHmuHom9tF6NUDQAzApRH=EqwzY8QLvj4ODZDyPgU7=Q@mail.gmail.com>
 <alpine.LSU.2.22.394.2006021252590.5447@anthias.pfeifer.com>
 <CAH6eHdSvLLsYeSt-PuQsCVqnrrgSkqYLpkgvweeFhKK-3d4sug@mail.gmail.com>
 <CAH6eHdRHBwJyS3rcVK77LQdO=tjFmZD84uBo4FgQsZaW7fMY+w@mail.gmail.com>
 <CAH6eHdT3PqaF8yKw9tC7g7wRDvzz-O7NznNsWMsE_nEsH+f5jw@mail.gmail.com>
 <58fa71e3-cbc1-7bbd-47ef-fd4f226fc7a5@suse.cz>
 <f5e6d559-2ad4-d561-68a5-497f2f3cf428@suse.cz>
In-Reply-To: <f5e6d559-2ad4-d561-68a5-497f2f3cf428@suse.cz>
From: Jonathan Wakely <jwakely.gcc@gmail.com>
Date: Tue, 2 Jun 2020 14:56:57 +0100
Message-ID: <CAH6eHdSR+eo95x41=q0k6CQxMT-NF1KTwtdPY27ce2HJE5zaHQ@mail.gmail.com>
Subject: Re: [IMPORTANT] ChangeLog related changes
To: =?UTF-8?Q?Martin_Li=C5=A1ka?= <mliska@suse.cz>
Cc: Gerald Pfeifer <gerald@pfeifer.com>, Jakub Jelinek <jakub@redhat.com>, 
 "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jun 2020 13:57:13 -0000

On Tue, 2 Jun 2020 at 14:16, Martin Li=C5=A1ka <mliska@suse.cz> wrote:
>
> On 6/2/20 1:48 PM, Martin Li=C5=A1ka wrote:
> > I tend to this approach. Let me prepare a patch candidate for it.
>
> There's a patch for it. Can you please Jonathan take a look?

Looks great, thanks!

+                if name not in wildcard_prefixes:
+                    msg =3D 'unsupported wilcard prefix'

Typo "wilcard"

+            if pattern not in used_patterns:
+                self.errors.append(Error('a file pattern not used in a pat=
ch',
+                                         pattern))

If the script printed this error I don't think I'd know what it was
complaining about. How about "pattern doesn't match any changed files"
?

I find the existing error 'file not changed in a patch' to be
suboptimal too. We're checking revisions (or commits), not patches.