From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44373 invoked by alias); 27 Jun 2019 12:58:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43870 invoked by uid 89); 27 Jun 2019 12:58:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.221.68, H*i:sk:e15c61a, H*f:sk:e15c61a, H*RU:209.85.221.68 X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jun 2019 12:58:39 +0000 Received: by mail-wr1-f68.google.com with SMTP id n4so2431961wrw.13; Thu, 27 Jun 2019 05:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eXwUYbjO5bpomXjI1ztNLIpWXLXd7yFbctouwHrc1xo=; b=EUo0QTXosLLiPBPOvnSLGA9ytOvbB7mT7r2cSjRzyoUINW+iKGCcEK4ZuxEsv7WyQO TXMpD6Ky13h4uEsx1RCDkcclx55/4M9o92ZAHUknYMRmIHmR7YV1Otk+xnZVHiiwN2CI ztNhQ9gPWnxfqpcvCKb2DA4M5xvcCsPMhL2Tpr8vr0w7ozdml9xzgSCw4OgDmY5kdSIl ZHpSl0+H0ym+a7PjxVWf4irmw9+6YtXF8ToWKGjrfR2kydm8q5EOnEibzPitxWz4+V4t 0X6pNoHdRQmIhl2VJGDhAB/TySJ+FI1TVHI2sAbsPpi8t2wH35EpuDU2EyjPrayZNm2k ZB1A== MIME-Version: 1.0 References: <884b9feb-3e71-db00-8c72-8e096bf75c1e@suse.cz> <69a11998-93c1-d61d-ba31-ac93bcbb353a@suse.cz> <20190621115838.GX815@tucnak> <79fcb5a4-0eba-d39f-e7ca-389f371cd48c@suse.cz> <20190621141309.GY815@tucnak> In-Reply-To: From: Jonathan Wakely Date: Thu, 27 Jun 2019 12:58:00 -0000 Message-ID: Subject: Re: [PATCH] Deprecate -frepo option. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Richard Biener , Jakub Jelinek , Iain Sandoe , "gcc@gcc.gnu.org" , David Edelsohn , Jan Hubicka , GCC Patches , Jason Merrill Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-06/txt/msg01768.txt.bz2 On Thu, 27 Jun 2019 at 13:30, Martin Li=C5=A1ka wrote: > > On 6/21/19 4:28 PM, Richard Biener wrote: > > On Fri, Jun 21, 2019 at 4:13 PM Jakub Jelinek wrote: > >> > >> On Fri, Jun 21, 2019 at 04:04:00PM +0200, Martin Li=C5=A1ka wrote: > >>> On 6/21/19 1:58 PM, Jakub Jelinek wrote: > >>>> On Fri, Jun 21, 2019 at 01:52:09PM +0200, Martin Li=C5=A1ka wrote: > >>>>> On 6/21/19 1:47 PM, Jonathan Wakely wrote: > >>>>>> On Fri, 21 Jun 2019 at 11:40, Martin Li=C5=A1ka wrote: > >>>>>>> Yes, I would be fine to deprecate that for GCC 10.1 > >>>>>> > >>>>>> Would it be appropriate to issue a warning in GCC 10.x if the opti= on is used? > >>>>> > >>>>> Sure. With the patch attached one will see: > >>>>> > >>>>> $ gcc -frepo /tmp/main.cc -c > >>>>> gcc: warning: switch =E2=80=98-frepo=E2=80=99 is no longer supported > >>>>> > >>>>> I'm sending patch that also removes -frepo tests from test-suite. > >>>>> I've been testing the patch. > >>>> > >>>> IMHO for just deprecation of an option you don't want to remove it f= rom the > >>>> testsuite, just match the warning it will generate in those tests, a= nd > >>>> I'm not convinced you want to remove it from the documentation (rath= er than > >>>> just saying in the documentation that the option is deprecated and m= ight be > >>>> removed in a later GCC version). > >>> > >>> Agree with you. I'm sending updated version of the patch. > >>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >> > >> I'm also not convinced about the Deprecated flag, seems like that is a= flag > >> that we use for options that have been already removed. > >> So, instead there should be some proper warning in the C++ FE for it, > >> or just Warn. > > > > In principle -frepo is a nice idea - does it live up to its promises? = That is, > > does it actually work, for example when throwing it on the libstdc++ > > testsuite or a larger C++ project? > > @Jonathan, Jason: Do we know whether it really work? I don't know. It's nearly 20 years since I've tried it, but apparently a few people try using it: https://stackoverflow.com/search?q=3Dfrepo+c%2B%2B The first result was answered by me in 2012 saying nobody uses it: https://stackoverflow.com/a/11832613/981959