public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: debug container patch
Date: Fri, 18 Apr 2014 10:59:00 -0000	[thread overview]
Message-ID: <CAH6eHdSV9Lz_PXDq+ncSkndABN53bODxN_-QeLEjpN_j1e-kUg@mail.gmail.com> (raw)
In-Reply-To: <53503D01.5000007@gmail.com>

On 17 April 2014 21:43, François Dumont wrote:
> Hi
>
>     Here is a patch to globally enhance debug containers implementation.
>
>     I have isolated all code of special functions in a base class so that in
> C++11 we can use default implementations for the debug containers. This way
> implementation is simpler and inherit from the noexcept qualifications.

Excellent.

>     I had to put a _IsCpp11AllocatorAware template parameter to this new
> type for types that are not yet C++11 allocator aware. We will be able to
> simplify it later.

Minor: we switch from using "cpp" to "cxx", meaning "cpp" can
unambiguously refer to the preprocessor, so I would use _IsCxx11...
for that.

>     I noticed also that in std/c++11/debug.cc we have some methods qualified
> with noexcept while in a C++03 user code those methods will have a throw()
> qualification. Is that fine ?

Yes, an empty throw() is compatible with noexcept(true).

I'll review the rest of the patch over the weekend, thanks!

  reply	other threads:[~2014-04-18 10:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 20:52 François Dumont
2014-04-18 10:59 ` Jonathan Wakely [this message]
2014-04-27 14:43 ` Jonathan Wakely
2014-04-28 21:14   ` François Dumont
2014-05-02 20:33     ` François Dumont
2014-05-06 14:05     ` Jonathan Wakely
2014-05-07  1:15       ` Paolo Carlini
2014-05-07 13:17         ` Ramana Radhakrishnan
2014-05-07 13:22           ` Jonathan Wakely
2014-05-07 13:24             ` Ramana Radhakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH6eHdSV9Lz_PXDq+ncSkndABN53bODxN_-QeLEjpN_j1e-kUg@mail.gmail.com \
    --to=jwakely.gcc@gmail.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).