From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 772133858C50; Thu, 1 Jun 2023 21:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 772133858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9745baf7c13so55033466b.1; Thu, 01 Jun 2023 14:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685656662; x=1688248662; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EjxbMX0lBc2oI88vYSsztXSF7T4KOaeajveRFhpMbyU=; b=O8mNERnP0+VSdpiVTfnMr6FxC+zgR6mBzvnIEzbY1tyzZ7Mcia/XgCXUGYINQQlzPj jwA2h7Mc7jgzB0fYwKiKF2LDEw7UHMtOluaFrqdKYhjgVngzNCvNkCP23JA9bK/cjgUK 5Dn6xbs0jhiG+iTFEcOq11sCSZYL6dERZlDpqluqfrHlLfk4S8Ug3okq0Uc2QaigyeXV kdv7FqMRvw9/JIaMLyhJt4pqeoPRaU6cKmxZrIaKCNp8VxdvbLr496pPQwLwNRQRJ9XG 0Hr3Ox+DNSHGRb4M2zwtH0D112Jylb43nHR7CmB0fUff/mYPOP2REhaA+nKhQWuULlQi rxWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685656662; x=1688248662; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EjxbMX0lBc2oI88vYSsztXSF7T4KOaeajveRFhpMbyU=; b=FNDQe+I1kumHtsbP7JJhZflzR61wqJmERBgbhpk573q8pCP19by2Gij/KFRZAYPEEe oKkxZ74sD9D3T+gNIKuDhMe4EwGE5FbAPWCDfgycy050voveufYpzLsUGMQQfEmGgZvv Nh1XEkI8FJ4HV+O02vj1OKUoV1iZj1eJ42ivR9Kyf6pNItdlfstGFfBSwyftFsFPoWwj 3oh+d80no2tneBy3vn5HUGwdVVAzbW7APpOdB4RcUqMITEVrQ3+o3Khq4C05qpEnl6fq sgNaeTWjONxI4ywTlaGLwqajYNE0FXqMf1rJ7Ly7yU6aZQiE21ALefpdNn46F4MCklsf jLIg== X-Gm-Message-State: AC+VfDwj5q0LzvbbeGRkxhLhFkcE+Pllhall40V+Saz6ewoAzMy0r/UP +ELakwLCYbZiKMMjStQG91UruIlAtgeaH/CSK0Y= X-Google-Smtp-Source: ACHHUZ4Um5YGRd2fex5pfstPgGrXB0HbeHdmS1rruQCrSOlrijnlXD1isRgsdMKabfKjMtd1LQXHJCwo7QekaSGRGKI= X-Received: by 2002:a17:907:980c:b0:933:868:413a with SMTP id ji12-20020a170907980c00b009330868413amr10279145ejc.15.1685656661978; Thu, 01 Jun 2023 14:57:41 -0700 (PDT) MIME-Version: 1.0 References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 1 Jun 2023 22:57:30 +0100 Message-ID: Subject: Re: [PATCH] Move std::search into algobase.h To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , Rainer Orth , Jonathan Wakely via Gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="0000000000008cf3b105fd1886fd" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000008cf3b105fd1886fd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 1 Jun 2023, 21:37 Fran=C3=A7ois Dumont via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > It's of course not as easy as I thought. > > I would never have detected this problem on my system because I'm > missing omp.h. > > I've implemented and added a: > > // { dg-require-effective-target omp } > > so that now those tests are UNRESOLVED rather than PASS. > > Now I've install OMP and try to rebuild lib to reproduce the failure. > You shouldn't need to install anything, just build gcc and don't configure it with --disable-libgomp > To be continued tomorrow... > > On 01/06/2023 14:05, Jonathan Wakely wrote: > > > > > > On Thu, 1 Jun 2023 at 12:52, Rainer Orth > > wrote: > > > > Jonathan Wakely via Gcc-patches writes: > > > > > On Wed, 31 May 2023 at 18:39, Fran=C3=A7ois Dumont via Libstdc++ < > > > libstdc++@gcc.gnu.org > wrote: > > > > > >> libstdc++: Reduce inclusion to > > >> > > >> > > >> Move the std::search definition from stl_algo.h to > > stl_algobase.h and use > > >> the later in . > > >> > > >> For consistency also move std::__parallel::search and > > associated helpers > > >> from > > >> to so that > > >> std::__parallel::search > > >> is accessible along with std::search. > > >> > > >> libstdc++-v3/ChangeLog: > > >> > > >> * include/bits/stl_algo.h > > >> (std::__search, std::search(_FwdIt1, _FwdIt1, > _FwdIt2, > > >> _FwdIt2, _BinPred)): Move... > > >> * include/bits/stl_algobase.h: ...here. > > >> * include/std/functional: Replace > > include by > > >> . > > >> * include/parallel/algo.h > > (std::__parallel::search<_FIt1, > > >> _FIt2, _BinaryPred>) > > >> (std::__parallel::__search_switch<_FIt1, _FIt2, > > >> _BinaryPred, _ItTag1, _ItTag2>): > > >> Move... > > >> * include/parallel/algobase.h: ...here. > > >> * include/std/functional: Remove > and > > >> > > >> includes. Include . > > >> > > >> Tested under Linux x86_64. > > >> > > >> Ok to commit ? > > >> > > > > > > OK > > > > This seems to have caused > > > > +FAIL: 17_intro/headers/c++2011/parallel_mode.cc (test for excess > > errors) > > +FAIL: 17_intro/headers/c++2014/parallel_mode.cc (test for excess > > errors) > > > > on i386-pc-solaris2.11: > > > > > > I think it affects all targets. > > > > > > Excess errors: > > > /var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstd= c++-v3/include/parallel/algobase.h:496: > > error: '__search_template' is not a member of '__gnu_parallel'; > > did you mean '__find_template'? > > > > Rainer > > > > -- > > > ------------------------------------------------------------------------= ----- > > Rainer Orth, Center for Biotechnology, Bielefeld University > > > --0000000000008cf3b105fd1886fd--