* [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc
@ 2015-05-06 8:09 Renlin Li
2015-06-01 15:00 ` [Ping][PATCH][libstdc++-v3] " Renlin Li
2015-06-01 15:58 ` [PATCH][libstdc++-v3] " Jonathan Wakely
0 siblings, 2 replies; 5+ messages in thread
From: Renlin Li @ 2015-05-06 8:09 UTC (permalink / raw)
To: gcc-patches; +Cc: libstdc++, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
Hi all,
This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test.
In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit()
function is nullified when either _GLIBCXX_RES_LIMITS or
_GLIBCXX_HAVE_LIMIT_FSIZE is not defined.
_GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however,
_GLIBCXX_HAVE_LIMIT_FSIZE is not checked.
The complete condition for correct execution of this test case is that,
those two macros are both defined.
Is Okay to commit?
Regards,
Renlin Li
libstdc++-v3/ChangeLog:
2015-05-06 Renlin Li <renlin.li@arm.com>
* testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: new-1.diff --]
[-- Type: text/x-patch; name=new-1.diff, Size: 477 bytes --]
diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
index b700868..69c0a6a 100644
--- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc
+++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
@@ -27,7 +27,7 @@
// Basic test for LFS support.
void test01()
{
-#ifdef _GLIBCXX_USE_LFS
+#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE)
using namespace std;
bool test __attribute__((unused)) = true;
^ permalink raw reply [flat|nested] 5+ messages in thread* [Ping][PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc
2015-05-06 8:09 [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc Renlin Li
@ 2015-06-01 15:00 ` Renlin Li
2015-06-01 15:58 ` [PATCH][libstdc++-v3] " Jonathan Wakely
1 sibling, 0 replies; 5+ messages in thread
From: Renlin Li @ 2015-06-01 15:00 UTC (permalink / raw)
To: gcc-patches; +Cc: libstdc++, Marcus Shawcroft
Ping~
Anybody can review this? Thank you!
Regards,
Renlin Li
On 06/05/15 09:09, Renlin Li wrote:
> Hi all,
>
> This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the
> test.
>
> In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit()
> function is nullified when either _GLIBCXX_RES_LIMITS or
> _GLIBCXX_HAVE_LIMIT_FSIZE is not defined.
> _GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however,
> _GLIBCXX_HAVE_LIMIT_FSIZE is not checked.
>
> The complete condition for correct execution of this test case is
> that, those two macros are both defined.
>
> Is Okay to commit?
>
> Regards,
> Renlin Li
>
> libstdc++-v3/ChangeLog:
>
> 2015-05-06 Renlin Li <renlin.li@arm.com>
>
> * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc
2015-05-06 8:09 [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc Renlin Li
2015-06-01 15:00 ` [Ping][PATCH][libstdc++-v3] " Renlin Li
@ 2015-06-01 15:58 ` Jonathan Wakely
2015-06-04 15:53 ` Renlin Li
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Wakely @ 2015-06-01 15:58 UTC (permalink / raw)
To: Renlin Li; +Cc: gcc-patches, libstdc++, Marcus Shawcroft
On 06/05/15 09:09 +0100, Renlin Li wrote:
>Hi all,
>
>This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test.
>
>In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit()
>function is nullified when either _GLIBCXX_RES_LIMITS or
>_GLIBCXX_HAVE_LIMIT_FSIZE is not defined.
>_GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however,
>_GLIBCXX_HAVE_LIMIT_FSIZE is not checked.
>
>The complete condition for correct execution of this test case is
>that, those two macros are both defined.
>
>Is Okay to commit?
OK.
>Regards,
>Renlin Li
>
>libstdc++-v3/ChangeLog:
>
>2015-05-06 Renlin Li <renlin.li@arm.com>
>
> * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.
>diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>index b700868..69c0a6a 100644
>--- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>+++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>@@ -27,7 +27,7 @@
> // Basic test for LFS support.
> void test01()
> {
>-#ifdef _GLIBCXX_USE_LFS
>+#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE)
> using namespace std;
> bool test __attribute__((unused)) = true;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc
2015-06-01 15:58 ` [PATCH][libstdc++-v3] " Jonathan Wakely
@ 2015-06-04 15:53 ` Renlin Li
2015-06-05 8:29 ` Jonathan Wakely
0 siblings, 1 reply; 5+ messages in thread
From: Renlin Li @ 2015-06-04 15:53 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: gcc-patches, libstdc++, Marcus Shawcroft
Hi Jonathan,
I have committed it on trunk.
Is it Okay for me to backport it to branch 5.0, 4.9 to remove failing noise?
Regards,
Renlin Li
On 01/06/15 16:58, Jonathan Wakely wrote:
> On 06/05/15 09:09 +0100, Renlin Li wrote:
>> Hi all,
>>
>> This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test.
>>
>> In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit()
>> function is nullified when either _GLIBCXX_RES_LIMITS or
>> _GLIBCXX_HAVE_LIMIT_FSIZE is not defined.
>> _GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however,
>> _GLIBCXX_HAVE_LIMIT_FSIZE is not checked.
>>
>> The complete condition for correct execution of this test case is
>> that, those two macros are both defined.
>>
>> Is Okay to commit?
> OK.
>
>> Regards,
>> Renlin Li
>>
>> libstdc++-v3/ChangeLog:
>>
>> 2015-05-06 Renlin Li <renlin.li@arm.com>
>>
>> * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.
>> diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>> index b700868..69c0a6a 100644
>> --- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>> +++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>> @@ -27,7 +27,7 @@
>> // Basic test for LFS support.
>> void test01()
>> {
>> -#ifdef _GLIBCXX_USE_LFS
>> +#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE)
>> using namespace std;
>> bool test __attribute__((unused)) = true;
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc
2015-06-04 15:53 ` Renlin Li
@ 2015-06-05 8:29 ` Jonathan Wakely
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Wakely @ 2015-06-05 8:29 UTC (permalink / raw)
To: Renlin Li; +Cc: Jonathan Wakely, gcc-patches, libstdc++, Marcus Shawcroft
On 4 June 2015 at 16:29, Renlin Li wrote:
> Hi Jonathan,
>
> I have committed it on trunk.
>
> Is it Okay for me to backport it to branch 5.0, 4.9 to remove failing noise?
I accidentally replied off-list yesterday.
Backporting this is OK, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-05 8:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-06 8:09 [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc Renlin Li
2015-06-01 15:00 ` [Ping][PATCH][libstdc++-v3] " Renlin Li
2015-06-01 15:58 ` [PATCH][libstdc++-v3] " Jonathan Wakely
2015-06-04 15:53 ` Renlin Li
2015-06-05 8:29 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).