From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id A92473858D20; Fri, 11 Nov 2022 18:27:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A92473858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id 21so8775761edv.3; Fri, 11 Nov 2022 10:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zvep6lZ3+dpkzijbIaabt2s35cN+xUV3ND9H0qaUIp4=; b=WwpnUesWy3c3mT28XgjPEWA307oZecEQmnJi5NUjavg/XHAx/APn9UoGnIPVTm0jPF FzX0UJ9IOJHM6Q1lohzKNrIGlvrZ9tB3eOJJQmv8trTprpxxD2FfckZF0tHSa7NFEVdF vOFWcMRwrq9p29nbHpAvqIo3qyq2mOr+9wgfL1uRIG6mxMl+9hkT4SF8HM3eyoxgwMOV rVuUkxhxkOSvX/ySKjVIOEq9jvOPWfGIQV9piioO9hYXEV0yFEBThSHFkPEZ4nyRa0Ua Pz2FfOZd1XDruxqJNqfsVntV6bNCD/ASFTu6toJ4xA1wg0n3Ir28b2jCkyV/v3u/Mjnm p+Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zvep6lZ3+dpkzijbIaabt2s35cN+xUV3ND9H0qaUIp4=; b=h7s7CsvzUuzpHB8hvE99rliOIvfJPtGsYggbvfxFVNDwCtE0OB6tObAEumm9QznxOr hMyr+a36GluRm9S0O6MZtRmJ8OSbWO9mH6/KVJqn4B2V3tKpVx3XvUMisdWdscUDbXwi f9zZZWsyP+sLj4gXFAwBBArcic+kf1L/gTvCE6yUr9Q1SPasI/1jaESDpaR47D4Evm9m k4X0DL7kFr/I9xN9PikeBgMn3IpP9PxglHUW7MEd8b857UXmJqLRUPKlNh24auqnScTi FrYB8+VIpVu8yo7iG+0LIh3KYMmMl3bICq4HKHS8hMfJgGvc5vwp7boPP8zljS+oYd6G lqvg== X-Gm-Message-State: ANoB5pmyp92m6+NMqKrJSqXTUe9tzQHxUzMhkMHsCzZNZA8uEXS7ZBGp CSJ1yx1bOiSiyj0ULD5EBfVgCAMQ/qwIWkM59ug= X-Google-Smtp-Source: AA0mqf6DQ7/bfZR37uBWIa2lFy2vamLSuj6Me0rj1hAv1a79XahICFzXjf/dcqKCb1DtOWK6CoiE9uGnorG0b42x6rA= X-Received: by 2002:aa7:d4d3:0:b0:45f:b80f:1fe8 with SMTP id t19-20020aa7d4d3000000b0045fb80f1fe8mr2531179edr.118.1668191232708; Fri, 11 Nov 2022 10:27:12 -0800 (PST) MIME-Version: 1.0 References: <8f15b063-9ec8-59e0-590b-20e416f68cb4@126.com> <98c69fc7-713f-a09a-8ca7-c3e64bdfd309@126.com> <0c6b1411-fa35-1c2f-16f2-f26b6e6cedaa@126.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 11 Nov 2022 18:27:01 +0000 Message-ID: Subject: Re: why does gccgit require pthread? To: LIU Hao Cc: Andrew Pinski , gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, David Malcolm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 11 Nov 2022 at 17:16, Jonathan Wakely wrote: > > On Mon, 7 Nov 2022 at 13:51, Jonathan Wakely wrote: > > > > On Mon, 7 Nov 2022 at 13:33, LIU Hao wrote: > > > > > > =E5=9C=A8 2022-11-07 20:57, Jonathan Wakely =E5=86=99=E9=81=93: > > > > It would be a lot nicer if playback::context met the C++ Lockable > > > > requirements, and playback::context::compile () could just take a > > > > scoped lock on *this: > > > > > > > > > > > > > > Yeah yeah that makes a lot of sense. Would you please just commit tha= t? I don't have write access to > > > GCC repo, and it takes a couple of hours for me to bootstrap GCC just= for this tiny change. > > > > Somebody else needs to approve it first. I'll combine our patches and > > test and submit it properly for approval. > > Here's a complete patch that actually builds now, although I'm seeing > a stage 2 vs stage 3 comparison error which I don't have time to look > into right now. A clean build fixed that. This patch bootstraps and passes testing on x86_64-pc-linux-gnu (CentOS 8 Stream). OK for trunk?