On Mon, 7 Nov 2022 at 13:51, Jonathan Wakely wrote: > > On Mon, 7 Nov 2022 at 13:33, LIU Hao wrote: > > > > 在 2022-11-07 20:57, Jonathan Wakely 写道: > > > It would be a lot nicer if playback::context met the C++ Lockable > > > requirements, and playback::context::compile () could just take a > > > scoped lock on *this: > > > > > > > > > > Yeah yeah that makes a lot of sense. Would you please just commit that? I don't have write access to > > GCC repo, and it takes a couple of hours for me to bootstrap GCC just for this tiny change. > > Somebody else needs to approve it first. I'll combine our patches and > test and submit it properly for approval. Here's a complete patch that actually builds now, although I'm seeing a stage 2 vs stage 3 comparison error which I don't have time to look into right now.