From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 9BB1C3858C52; Thu, 28 Sep 2023 18:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BB1C3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99de884ad25so1754622566b.3; Thu, 28 Sep 2023 11:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695927204; x=1696532004; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YZK6XVzYL5gwU91/E5nhzuoD2Oyy4sQSsII25niar2I=; b=LNeaLmdL+XseF3/WEt//sndhLEKssGgQr+QqddeIbiLMojVzZswVs18FRhQOLWEkuS bIje9//zvjsG0B2twdxPdichA/SNOho7x5f4JWmA9EmqN65/Fb/f/XehLpWmr4FSK13K kclelgKOqqndnRIvJreti0xyctJHAiO1YAUbwLuz8soxFKljiWHNuWJuYAvhiIjv7joh eSlp+utizn6wh3UQNhqCDAdZ+Mi/MY+tT+E/MUgS8+rpLkGsPfD9/mZsd0GxUrG8ypQl HQuWP+TNPv5GyuyIX/XWqBxqcEdrYtOk3cb71ZQu7NqTnuM37HDsDBZzOtcDfYaX5/8j JcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695927204; x=1696532004; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YZK6XVzYL5gwU91/E5nhzuoD2Oyy4sQSsII25niar2I=; b=IQXWnZnCLr2qa4prpeysooBAqmHjTXFcHTrOce36pWwvfhugbKaXAKVcc5qfuuptfe HAhbJxPOZkmDKYcKhPECpuxQ1RV48yW98jbOWpakvg7eMUwtz6DDMAN609Z0LfKb58it /ixTP/qFazTJVm/RV5dAV4g1sCCpm51NLDS9N81JCnX1wccIZXnHYnrTYQSSQySu/Ziq es5D7+iKphvA72X9slJsVqy0TETPkmeO5je321erYRY0oSpUQtNlT0+KwEFQP+EQcXt+ CYvww0pWPVLaVlmucjMfllSt2MguIKACMz+mcgGBKNrQSlXEICKIdFg4DdvHJ/NbCw/l Vw6A== X-Gm-Message-State: AOJu0Yzjkqf4in5pv5JS1zP92lrAIfoxMgn81WuCleQSfrQwMlQnl8+b ghcuNhAbjJetBwLtA0nQ6O6TJPZOnNZbS7dAJ5k= X-Google-Smtp-Source: AGHT+IH2iVoVktVtKW8E2UgH291e2ORCULpAxiC35vKOFDZ6dVLGO0Vpc5A2t8B26fcaqbp0XchJ/CDGMEFoPsKobvM= X-Received: by 2002:a17:906:104e:b0:9a1:bb8f:17de with SMTP id j14-20020a170906104e00b009a1bb8f17demr2412528ejj.35.1695927204187; Thu, 28 Sep 2023 11:53:24 -0700 (PDT) MIME-Version: 1.0 References: <20230928174630.4004388-1-tromey@adacore.com> <20230928174630.4004388-5-tromey@adacore.com> In-Reply-To: <20230928174630.4004388-5-tromey@adacore.com> From: Jonathan Wakely Date: Thu, 28 Sep 2023 19:53:12 +0100 Message-ID: Subject: Re: [PATCH 4/7] libstdc++: Remove unused locals from printers.py To: Tom Tromey Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="0000000000009220e006066fd2a6" X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000009220e006066fd2a6 Content-Type: text/plain; charset="UTF-8" On Thu, 28 Sept 2023, 18:50 Tom Tromey via Libstdc++, wrote: > flake8 pointed out some unused local variables in the libstdc++ > pretty-printers. This removes them. > OK, thanks. > libstdc++-v3/ChangeLog: > > * python/libstdcxx/v6/printers.py > (StdExpOptionalPrinter.__init__, lookup_node_type): > Remove unused variables. > --- > libstdc++-v3/python/libstdcxx/v6/printers.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py > b/libstdc++-v3/python/libstdcxx/v6/printers.py > index 8d44244afb0..6bf4fe891fd 100644 > --- a/libstdc++-v3/python/libstdcxx/v6/printers.py > +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py > @@ -169,7 +169,7 @@ def lookup_node_type(nodename, containertype): > valtype = valtype.strip_typedefs() > try: > return lookup_templ_spec(nodename, valtype) > - except gdb.error as e: > + except gdb.error: > # For debug mode containers the node is in std::__cxx1998. > if is_member_of_namespace(nodename, 'std'): > if is_member_of_namespace(containertype, 'std::__cxx1998', > @@ -1423,7 +1423,6 @@ class > StdExpOptionalPrinter(SingleObjContainerPrinter): > "Print a std::optional or std::experimental::optional" > > def __init__(self, typename, val): > - valtype = self._recognize(val.type.template_argument(0)) > typename = strip_versioned_namespace(typename) > self._typename = re.sub( > '^std::(experimental::|)(fundamentals_v\d::|)(.*)', > r'std::\1\3', typename, 1) > -- > 2.40.1 > > --0000000000009220e006066fd2a6--