From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [libstdc++] [testsuite] intro/names.cc: undef func on vxw7krn
Date: Fri, 17 Feb 2023 10:59:21 +0000 [thread overview]
Message-ID: <CAH6eHdSubmMk23xjOe5tUYpUzs6Se0pzqR6+TKMTe_vzGY--uA@mail.gmail.com> (raw)
In-Reply-To: <ormt5cu86w.fsf@lxoliva.fsfla.org>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Fri, 17 Feb 2023, 06:19 Alexandre Oliva via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
>
> The '#define func' added in 2021, to test that system headers don't
> violate the user namespace, exposes such a bug in the vxworks sysLib.h
> header, so add yet another such annotated workaround.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
>
OK, thanks.
> for libstdc++-v3/ChangeLog
>
> * testsuite/17_intro/names.cc: Undef func on vxworks >= 7 in
> kernel mode.
> ---
> libstdc++-v3/testsuite/17_intro/names.cc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libstdc++-v3/testsuite/17_intro/names.cc
> b/libstdc++-v3/testsuite/17_intro/names.cc
> index d3e0db9bab6b9..c2d67ebe01276 100644
> --- a/libstdc++-v3/testsuite/17_intro/names.cc
> +++ b/libstdc++-v3/testsuite/17_intro/names.cc
> @@ -329,6 +329,8 @@
> #undef d
> #undef e
> #undef f
> +// in sysLib.h, func appears as a formal parameter name
> +#undef func
> #endif // __RTP__
>
> #endif // VxWorks Major >= 7
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
>
prev parent reply other threads:[~2023-02-17 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 6:17 Alexandre Oliva
2023-02-17 10:59 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdSubmMk23xjOe5tUYpUzs6Se0pzqR6+TKMTe_vzGY--uA@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).