From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 441 invoked by alias); 25 Jan 2013 00:15:59 -0000 Received: (qmail 384 invoked by uid 22791); 25 Jan 2013 00:15:57 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jan 2013 00:15:22 +0000 Received: by mail-lb0-f169.google.com with SMTP id m4so7024889lbo.14 for ; Thu, 24 Jan 2013 16:15:20 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.122.133 with SMTP id ls5mr3534207lab.9.1359072920679; Thu, 24 Jan 2013 16:15:20 -0800 (PST) Received: by 10.112.125.71 with HTTP; Thu, 24 Jan 2013 16:15:20 -0800 (PST) In-Reply-To: References: Date: Fri, 25 Jan 2013 00:15:00 -0000 Message-ID: Subject: Re: [google gcc-4_7, integration] Scribble on destructed strings to catch invalid accesses. From: Jonathan Wakely To: libstdc++@gcc.gnu.org Cc: Paul Pluzhnikov , dnovillo@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01225.txt.bz2 On 24 January 2013 19:03, Marc Glisse wrote: > On Wed, 23 Jan 2013, Paul Pluzhnikov wrote: > >> This patch allows us to catch use of destructed strings. > > > Hello, > > while a number of the google debug patches are just cheaper versions (that > don't break the ABI) of what libstdc++'s debug mode provides, this > overwriting of classes on destruction is not as obviously redundant, and I > wonder whether something like it (done consistently for many classes) could > go to trunk... Thanks for pointing this out, Marc. This does look like something that could be included in debug mode, but probably not until we're back in Stage 1. Please either put it in Bugzilla (and CC me) or if you're diligent enough to remember please email us again during Stage 1 :-) Googlers, please include the libstdc++ list on patches to the libstdc++ code, even if it's only to a google branch. I don't read gcc-patches but am still interested in the changes you make to the code on your branch.