From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10020 invoked by alias); 18 Jan 2013 13:07:44 -0000 Received: (qmail 10005 invoked by uid 22791); 18 Jan 2013 13:07:43 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f177.google.com (HELO mail-lb0-f177.google.com) (209.85.217.177) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 13:07:37 +0000 Received: by mail-lb0-f177.google.com with SMTP id gm6so537640lbb.22 for ; Fri, 18 Jan 2013 05:07:35 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.112.40.3 with SMTP id t3mr3776921lbk.48.1358514455214; Fri, 18 Jan 2013 05:07:35 -0800 (PST) Received: by 10.112.125.71 with HTTP; Fri, 18 Jan 2013 05:07:35 -0800 (PST) In-Reply-To: References: Date: Fri, 18 Jan 2013 13:07:00 -0000 Message-ID: Subject: Re: [patch libstdc++]: Fix tests trying to override symbols in shared-library for mingw targets From: Jonathan Wakely To: Kai Tietz Cc: GCC Patches , "libstdc++" Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00961.txt.bz2 On 18 January 2013 12:09, Kai Tietz wrote: >>> + >>> + if { [llength $args] >= 3 } { >> >> Is this condition right or should it check for exactly three? > > Well, I copied stuff from gcc's testsuite. As we check some lines > about for args > 3 and error out, a test for == 3 makes sense, but > well, >= 3 is fine too. Ah OK, it's fine as it is then. Thanks again.