From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: unordered set design modification
Date: Mon, 22 Oct 2012 20:52:00 -0000 [thread overview]
Message-ID: <CAH6eHdTZVw=weD8x+_2z5pQGBU_mCBK=sLFWvSHvkgabJxB33Q@mail.gmail.com> (raw)
In-Reply-To: <5085A5AD.8030307@gmail.com>
On 22 October 2012 20:59, François Dumont wrote:
> Attached patch applied.
>
> 2012-10-22 François Dumont <fdumont@gcc.gnu.org>
>
>
> * include/bits/unordered_set.h (unordered_set<>): Prefer
> aggregation to inheritance with _Hashtable.
> (unordered_multiset<>): Likewise.
> * include/debug/unordered_set (operator==): Adapt.
> * include/profile/unordered_set (operator==): Adapt.
+ //@{
Do these comments work correctly?
I think it needs to be ///@{ for Doxygen to recognise it.
> I will now take care of unordered_map and unordered_multimap.
Thanks.
It occurs to me now that the copy and move operations could be
defaulted, since all they do is forward to the member, which is both
copyable and movable.
prev parent reply other threads:[~2012-10-22 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5083127B.6050306@gmail.com>
[not found] ` <5083C4C5.9010807@oracle.com>
2012-10-21 20:03 ` François Dumont
[not found] ` <CAH6eHdQgfc3hCEFD4gEvZUPVJRkjdLo0A9CBBZwSGJktuAqm5w@mail.gmail.com>
[not found] ` <5084504A.908@gmail.com>
[not found] ` <CAH6eHdQgN9YsiBixL0ub3GzgffSBo+J-R576vx+9nLkA7-GnEg@mail.gmail.com>
2012-10-22 20:30 ` François Dumont
2012-10-22 20:52 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdTZVw=weD8x+_2z5pQGBU_mCBK=sLFWvSHvkgabJxB33Q@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).