From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: LIU Hao <lh_mouse@126.com>, Andrew Pinski <pinskia@gmail.com>,
gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: why does gcc jit require pthread?
Date: Tue, 15 Nov 2022 19:01:27 +0000 [thread overview]
Message-ID: <CAH6eHdTerVf2sS_J5+A=QOsnPDv=j_vQfYSOXz0w=LUsLTxyGA@mail.gmail.com> (raw)
In-Reply-To: <63a9058d0bb20e40a8d3c24ecbc0c5da1b54faf5.camel@redhat.com>
On Tue, 15 Nov 2022 at 18:50, David Malcolm <dmalcolm@redhat.com> wrote:
>
> [Fixing typo in the Subject ("git" -> "jit" ); CCing jit mailing list]
>
> On Fri, 2022-11-11 at 17:16 +0000, Jonathan Wakely wrote:
> > On Mon, 7 Nov 2022 at 13:51, Jonathan Wakely wrote:
> > >
> > > On Mon, 7 Nov 2022 at 13:33, LIU Hao wrote:
> > > >
> > > > 在 2022-11-07 20:57, Jonathan Wakely 写道:
> > > > > It would be a lot nicer if playback::context met the C++
> > > > > Lockable
> > > > > requirements, and playback::context::compile () could just take
> > > > > a
> > > > > scoped lock on *this:
> > > > >
> > > > >
> > > >
> > > > Yeah yeah that makes a lot of sense. Would you please just commit
> > > > that? I don't have write access to
> > > > GCC repo, and it takes a couple of hours for me to bootstrap GCC
> > > > just for this tiny change.
> > >
> > > Somebody else needs to approve it first. I'll combine our patches
> > > and
> > > test and submit it properly for approval.
> >
> > Here's a complete patch that actually builds now, although I'm seeing
> > a stage 2 vs stage 3 comparison error which I don't have time to look
> > into right now.
>
> I confess that I'm not familiar with C++11's mutex and locking types,
> but having read through the relevant entries on cppreference.com, the
> patch looks correct to me.
>
> Are these classes well-supported on the minimum compiler version we
> support? (Jonathan, I defer to your judgement here)
std::mutex has been supported since 4.4.0 and is very simple. The
implementation on trunk is identical to the one in gcc 4.8.5 except
for adding 'noexcept' to mutex::native_handle (), which is not
relevant to this change.
> Jonathan: you said in your followup email that it "bootstraps and
> passes testing on x86_64-pc-linux-gnu (CentOS 8 Stream)". This is
> possibly a silly question, but did this testing include the jit
> testsuite? A gotcha here is that --enable-languages=all does *not*
> enable jit.
Yes, I built with --enable-languages=c,c++,jit --enable-host-shared
> The patch is OK for trunk if you have favorable answers for the above
> two questions.
>
> Thanks!
> Dave
>
next prev parent reply other threads:[~2022-11-15 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8f15b063-9ec8-59e0-590b-20e416f68cb4@126.com>
[not found] ` <CA+=Sn1ncp6hN8MnziZ+2f-6_UUqMwXeVGQLmft2NUeuXGOaBoA@mail.gmail.com>
2022-11-07 6:50 ` why does gccgit " LIU Hao
2022-11-07 7:03 ` Andrew Pinski
2022-11-07 7:10 ` LIU Hao
2022-11-07 12:57 ` Jonathan Wakely
2022-11-07 13:33 ` LIU Hao
2022-11-07 13:51 ` Jonathan Wakely
2022-11-11 17:16 ` Jonathan Wakely
2022-11-11 18:27 ` Jonathan Wakely
2022-11-14 10:54 ` LIU Hao
2022-11-15 18:50 ` why does gcc jit " David Malcolm
2022-11-15 19:01 ` Jonathan Wakely [this message]
2022-11-19 11:27 ` Jonathan Wakely
2022-11-19 12:51 ` LIU Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdTerVf2sS_J5+A=QOsnPDv=j_vQfYSOXz0w=LUsLTxyGA@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=lh_mouse@126.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).