public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Olivier Hainque <hainque@adacore.com>
Cc: Alexandre Oliva <oliva@adacore.com>,
	Jonathan Wakely <jwakely@redhat.com>,
	libstdc++@gcc.gnu.org,  gcc-patches@gcc.gnu.org,
	Matthias Kretz <m.kretz@gsi.de>
Subject: Re: [PATCH] [libstdc++] add _GLIBCXX_CLANG to workaround predefined __clang__
Date: Sat, 1 Jun 2024 09:18:43 +0100	[thread overview]
Message-ID: <CAH6eHdTzF5r2d6TXomvzNnMhqu8xP+sWCXAKq=7ANwoZmqZ+uA@mail.gmail.com> (raw)
In-Reply-To: <D80C7FCB-790C-4BE4-B049-548FB4737C6A@adacore.com>

On Sat, 1 Jun 2024 at 08:35, Olivier Hainque <hainque@adacore.com> wrote:
>
>
>
> > On 31 May 2024, at 17:52, Alexandre Oliva <oliva@adacore.com> wrote:
>
> >> Does the vxworks toolchain need to support the PSTL headers?
> >
> > Maybe we can do without them.  I really don't know.  Olivier?
>
> I have no indication that we can not-support these.
>
> We are seeing many cases of C++/Ada combined codebases in a variety
> of VxWorks contexts so actual uses seem likely.

If Intel TBB isn't supported on vxworks then the PSTL algos are not
very useful. You can use them, but you won't get any benefits. I'm
unsure of the status of the openmp and simd backends in PSTL, I think
only the TBB backend really works.

>
> >> If not, we could just ignore this file, so the local changes don't
> >> need to be re-applied when we import a new version of the header from
> >> upstream.
> >
> > That sounds desirable indeed.  This change is supposed to spare us
> > (AdaCore) from precisely this sort of trouble, so it wouldn't be fair if
> > it made this very kind of trouble for our upstream.
>
> Of course, 100% agreed!
>
> Thanks a lot for help in looking into this!
>
> Olivier
>
>

  reply	other threads:[~2024-06-01  8:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 14:07 Alexandre Oliva
2024-05-31 14:50 ` Jonathan Wakely
2024-05-31 15:52   ` Alexandre Oliva
2024-05-31 17:43     ` [PATCH v2] " Alexandre Oliva
2024-06-01  8:21       ` Jonathan Wakely
2024-06-01 16:07         ` Jakub Jelinek
2024-06-05 19:33           ` Olivier Hainque
2024-06-06  2:08         ` [FYI] [PATCH v3] " Alexandre Oliva
2024-06-01  7:35     ` [PATCH] " Olivier Hainque
2024-06-01  8:18       ` Jonathan Wakely [this message]
2024-06-01  8:19     ` Jonathan Wakely
2024-06-07  4:43     ` [PATCH] [libstdc++] drop workaround for clang<=7 (was: [libstdc++] add _GLIBCXX_CLANG to workaround predefined __clang__) Alexandre Oliva
2024-06-07  8:42       ` Jonathan Wakely
2024-05-31 15:55   ` [PATCH] [libstdc++] add _GLIBCXX_CLANG to workaround predefined __clang__ Matthias Kretz
2024-05-31 17:40     ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH6eHdTzF5r2d6TXomvzNnMhqu8xP+sWCXAKq=7ANwoZmqZ+uA@mail.gmail.com' \
    --to=jwakely.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hainque@adacore.com \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=m.kretz@gsi.de \
    --cc=oliva@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).