From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10879 invoked by alias); 17 Aug 2012 00:33:06 -0000 Received: (qmail 10863 invoked by uid 22791); 17 Aug 2012 00:33:05 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_50,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_GD X-Spam-Check-By: sourceware.org Received: from mail-lpp01m010-f47.google.com (HELO mail-lpp01m010-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Aug 2012 00:32:53 +0000 Received: by lagv3 with SMTP id v3so1803050lag.20 for ; Thu, 16 Aug 2012 17:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=iNN2bL1O3wswjLsXdtO94yf+nP2v3fku25CIMW84HCU=; b=F8FQpszvD6rFAntjMaVkwvVSl7DriURmnteUYAWOA0Ama3a6/AI+Z9sck9WpcWD/BH T1fWbYESSPDDBCD5uw9MIgddIyY+ICCI8q4xVyZ2E27RwrNo/St/eB6nrYqGFEqvtj8Z f6z3a0V1EyYagaPBXCNR73vwaKpX/30X1DNvxLqKDOeCZrLQcI6xZByVB/ypTPo4VoQa nfhOq5x+aNqRhTwggcXlP/bBXHDXi/m4JsY2onDWk5RAJQkAL2ZbKfLBk0xQGfAW3VOl BX1BDkYUH3Nr5aZOf0dGZ1Lv1OuhySd2nW8DYIO/Ym8OSrj/A+UmkJgP4QK4H+0WPRX+ Ur+g== Received: by 10.152.146.67 with SMTP id ta3mr3012212lab.27.1345163571463; Thu, 16 Aug 2012 17:32:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.146.67 with SMTP id ta3mr3012201lab.27.1345163571324; Thu, 16 Aug 2012 17:32:51 -0700 (PDT) Received: by 10.112.59.168 with HTTP; Thu, 16 Aug 2012 17:32:51 -0700 (PDT) In-Reply-To: <20120816235247.DEDE11609D0@sterling.mtv.corp.google.com> References: <20120816235247.DEDE11609D0@sterling.mtv.corp.google.com> Date: Fri, 17 Aug 2012 00:33:00 -0000 Message-ID: Subject: Re: [Google 4.7] Generate pubnames compatible with gdb-index version 7. (issue6459099) From: Cary Coutant To: Sterling Augustine Cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQl0biRDGhwFbNvDD7ljc3qZPHzbVoat2HeLLIx9CbetIbSShobUfhriMo5lp5X+IUdP+ckQ4HFhc9D7F1ZYBPGe8Xv8lx9AQCfrdMfo+8ZMSfxgPViHq/dUbHXEZKvAr7Oazs23Bg15YnpWfXHezSVR9+FP2fH2LqN8/KhjTssP4S/oc5kv8AavXBvlVJHoVsIVBKu6 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg01117.txt.bz2 > +/* Output a single entry in the pubnames table. */ > + > +static void > +output_pubname (dw_offset die_offset, pubname_entry *entry) For this function, I'd suggest a comment to the effect that the logic is lifted from GDB. > @@ -2424,6 +2424,10 @@ gpubnames > Common RejectNegative Var(debug_generate_pub_sections, 1) > Generate DWARF pubnames and pubtypes sections. > > +ggnu-pubnames > +Common RejectNegative Var(debug_generate_pub_sections, 2) > +Generate DWARF pubnames and pubtypes sections. Instead of "RejectNegative", I think these three options should now use "Negative(...)" flags (each one naming the next, circularly). Not sure about that, though. (See the treatment of -gdwarf-, -gstabs, etc.) OK for google/gcc-4_7 branch. -cary